Bug 135981 - Wrong formatting when typing (like track & changes involved)
Summary: Wrong formatting when typing (like track & changes involved)
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.0.7.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Track-Changes
  Show dependency treegraph
 
Reported: 2020-08-21 09:34 UTC by Telesto
Modified: 2021-06-24 12:19 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot of the example file with changes visible (90.44 KB, image/png)
2021-06-24 11:06 UTC, NISZ LibreOffice Team
Details
Simplified example file without change tracking (21.58 KB, application/vnd.oasis.opendocument.text)
2021-06-24 12:16 UTC, NISZ LibreOffice Team
Details
The change tracking free document before deleting from B. to A. (106.77 KB, image/png)
2021-06-24 12:17 UTC, NISZ LibreOffice Team
Details
The change tracking free document after deleting from B. to A. and typing a bit (72.70 KB, image/png)
2021-06-24 12:19 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-08-21 09:34:36 UTC
Description:
Wrong formatting when typing (like track & changes involved)

Steps to Reproduce:
1. Open attachment 164521 [details]
2. Edit -> Track changes -> Accept all changes (but only to show it's even present after Accept all; only in that sessions) File reload and issue goes away
2. Start typing (don't move the cursor first) -> Green


Actual Results:
Green font

Expected Results:
Black font


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: <buildversion>
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

not in
Version: 6.4.0.0.beta1+ (x64)
Build ID: 20be5cd0bdc57d812bf34a2debfe48caa51de881
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: GL; VCL: win; 
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: CL
Comment 1 Kevin Suo 2020-11-07 03:42:16 UTC
Telesto:
The test document has track-changes enabled, so we you type in the document it is in track-changed mode. This is expected. Am I missing something?

Set to NEEDINFO. Please set back to UNCONFIRMED after you have provided clarification.
Comment 2 Aron Budea 2020-12-26 07:24:30 UTC
(In reply to Kevin Suo from comment #1)
> Telesto:
> The test document has track-changes enabled, so we you type in the document
> it is in track-changed mode. This is expected. Am I missing something?
Yes, the changes are tracked, but they aren't shown, that setting is turned off. Plus shown tracked edit is shown in yellow color.

What I see is that the font at that point is set to Lime color, however for me that difference persist back until 6.0, and it's black in 5.4. Telesto, are you sure the color is black as you would've expected in 6.1-6.4?
Comment 3 Aron Budea 2020-12-27 09:01:55 UTC
I skipped step 2, since as I understand that isn't necessary. The bug started with the following commit, bibisected to its 6.0 backport using repo bibisect-linux-64-6.0. Adding CC: to Michael Stahl.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=1c8efde4daea648204e3ba19f8edc01ef3e548bd
author		Michael Stahl <mstahl@redhat.com>	2018-02-14 12:57:49 +0100
committer	Michael Stahl <mstahl@redhat.com>	2018-02-15 09:56:55 +0100

tdf#83260 sw: call CompressRedlines() in ODF import
Comment 4 NISZ LibreOffice Team 2021-06-24 11:06:43 UTC
Created attachment 173157 [details]
Screenshot of the example file with changes visible

What happened here is that the text was deleted from the lower "Les algorithmes" paragraph backwards to the upped "Les Algorithmes" paragraph, which has the green color direct formatting.

This makes the bullet of the "Les Algorithmes" paragraph retain its direct formatting, so if you start typing after it, you get the green color of the bullet.
Comment 5 NISZ LibreOffice Team 2021-06-24 12:16:59 UTC
Created attachment 173163 [details]
Simplified example file without change tracking

This file shows that the behavior documented here is not specific to change tracking.

To test: highlight the text from the paragraph marked with B. to the beginning of A. (which is green) then press Delete. Start typing: the text is now green too.

In fact this behavior was ever present way back to 3.5. 
Since 6.0 the change tracking scenario follows this, before it did not follow.

We can argue whether this behavior is desirable (Word for example would let to delete the first bullet and apply all the formatting of the second), but I don't think there is a change tracking regression.
Comment 6 NISZ LibreOffice Team 2021-06-24 12:17:43 UTC
Created attachment 173164 [details]
The change tracking free document before deleting from B. to A.
Comment 7 NISZ LibreOffice Team 2021-06-24 12:19:30 UTC
Created attachment 173165 [details]
The change tracking free document after deleting from B. to A. and typing a bit