Bug 136415 - FILEOPEN DOCX Paragraph direct formatting settings not prioritized over style settings in VML shape
Summary: FILEOPEN DOCX Paragraph direct formatting settings not prioritized over style...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.0.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, filter:docx, regression
Depends on:
Blocks: OOXML-Doc-Themes VML-Shapes
  Show dependency tree / graph
 
Reported: 2020-09-02 20:23 UTC by NISZ LibreOffice Team
Modified: 2023-05-02 16:47 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Attachments
Screenshot of the original document side by side in Word and Writer (117.30 KB, image/png)
2020-09-02 20:23 UTC, NISZ LibreOffice Team 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description NISZ LibreOffice Team 2020-09-02 20:23:37 UTC 
Created attachment 165054 [details]
Screenshot of the original document side by side in Word and Writer

attachment #156848 [details] has a grouped VML shape with text formatted Normal style and also with direct formatting.
When opened in Writer the settings from the Normal style are used to display the text instead of the ones set with direct formatting.

Steps to reproduce:
    1. Open attachment #156848 [details] and look at the text

Actual results:
Font is MS Gothic, Alignment is Left, Left indent is 0, Right indent is 0, First line indent is 0, Spacing before is 0, Line spacing is single.

Expected results:
Font should be Calibri, Alignment should be justified, Left indent should be 0.23 cm, Right indent should be 0.24 cm, First line indent should be 0.42 cm, Spacing before should be 5.15 pt, Line spacing should be 1.15.

LibreOffice details:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: 1e0cfd5662d95cea84e80e4fe10d52c3b1101ae6
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL

Additional Information: 

Bibisected using bibisect-win64-7.0 to:
URL: https://cgit.freedesktop.org/libreoffice/core/commit/?id=334409fbde555a957cd34e295cc27f2c2bf6e194 
author	Justin Luth <justin.luth@collabora.com>	2019-10-22 15:50:19 +0300
committer	Miklos Vajna <vmiklos@collabora.com>	2019-11-22 10:47:44 +0100

tdf#128153 docx/VML: apply style properties to shape text

Adding CC to: Justin Luth 

Before the font name was correct, but the rest of the settings wasn’t.
Comment 1 Justin L 2020-09-03 11:48:47 UTC 
(In reply to NISZ LibreOffice Team from comment #0)
> Before the font name was correct, but the rest of the settings wasn’t.
Calibri is the system default - so that is an easy one to get right by accident.

When unzipping the document, there are only two references to Calibri - in fonttable and theme1. I don't see it as a direct formatting attribute at all. So is it coming from
<w:rFonts w:asciiTheme="minorHAnsi" w:hAnsiTheme="minorHAnsi" w:cstheme="minorHAnsi"/> ?

I don't think LO has any support for themes, except for GRAB_BAG round-tripping.

Even doing anything in MS Word like selecting a style changes it to Gothic. So I am going to say this exposed an existing problem or implementation lack.
Comment 2 Xisco Faulí 2020-12-07 18:04:38 UTC 
Reproduced in

Version: 7.2.0.0.alpha0+
Build ID: 84af20ef3ea72190784e9e7be820684c2558ba8c
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

Font is calibre in this version, the rest is still wrong
Comment 3 QA Administrators 2022-12-08 03:25:43 UTC Comment hidden (obsolete, spam)
Comment 4 Justin L 2023-05-02 16:47:32 UTC 
repro 7.6 - still not fixed even though lots of theme work has landed.