Bug 136453 - Duplication of content after undo (spurious)
Summary: Duplication of content after undo (spurious)
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.1.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Michael Stahl (allotropia)
URL:
Whiteboard: target:7.1.0 target:7.0.4
Keywords: bibisected, bisected, regression
Depends on:
Blocks: redlinehide-regressions
  Show dependency treegraph
 
Reported: 2020-09-03 20:59 UTC by Telesto
Modified: 2020-11-19 11:09 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file (9.36 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2020-09-03 20:59 UTC, Telesto
Details
Screencast (1.14 MB, video/mp4)
2020-09-03 21:00 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-09-03 20:59:17 UTC
Description:
Duplication of content after undo 

Steps to Reproduce:
1. Open the attached file
2. Select the list from bottom page 2 to bulleted list a on page 1
3. Press backspace
4. Press Undo

Actual Results:
Duplication

Expected Results:
Not so


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: e8b8e7be0b2ad693224cd94062a55610eb69df7e
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2020-09-03 20:59:46 UTC
Created attachment 165124 [details]
Example file
Comment 2 Telesto 2020-09-03 21:00:25 UTC
Created attachment 165125 [details]
Screencast
Comment 3 Telesto 2020-09-03 21:02:17 UTC
Not in
Version: 7.0.0.0.alpha1+ (x64)
Build ID: 99c4fefdbb6129a58421b9c7f...
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win; 
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 4 Telesto 2020-09-03 21:04:58 UTC
@Michael
Heads-up.. likely caused by recent change which maybe backported already (or will be)
Comment 5 Attila Baraksó (NISZ) 2020-09-16 07:12:25 UTC
Reproduced in:

Version: 7.1.0.0.alpha0+ (x64)
Build ID: 8c18cd6823ddf4ef5ba67801a84cee26c9b5a9a6
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: threaded
Comment 6 Attila Baraksó (NISZ) 2020-09-16 07:36:56 UTC
Bibisected using bibisect-win64-7.1 to:
URL: https://cgit.freedesktop.org/libreoffice/core/commit/?id=740f1796504f66408b692225a9676c9ee3d63722
author: Michael Stahl <Michael.Stahl@cib.de>
committer: Michael Stahl <michael.stahl@cib.de>
summary: tdf#134252 sw_redlinehide: fix SwUndoDelete for table before end of section
Comment 7 Michael Stahl (allotropia) 2020-10-28 07:01:50 UTC
fixed on master
Comment 8 Commit Notification 2020-10-28 07:02:56 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c4967928475f2be20ac2d79e3fa84ac435a7e560

tdf#136453 sw_redlinehide: SwUndoDelete: only create extra frames...

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Xisco Faulí 2020-10-28 12:20:14 UTC
Verified in

Version: 7.1.0.0.alpha1+
Build ID: 49a39d1abccc61b6dace3e92059ae50a6a2c298d
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

@Michael Stahl, thanks for fixing this issue!!
Comment 10 Commit Notification 2020-10-28 12:21:17 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/815f58fe60dca8ee41f362748a144fc16c89b1f9

tdf#136453 sw_redlinehide: SwUndoDelete: only create extra frames...

It will be available in 7.0.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.