Bug 136454 - Make Icon for LibreLogo Toolbar
Summary: Make Icon for LibreLogo Toolbar
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.1.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Rizal Muttaqin
URL:
Whiteboard: target:7.1.0
Keywords:
Depends on:
Blocks: Icon-Theme-Breeze Icon-Theme-Colibre Icon-Theme-KarasaJaga Icon-Theme-Elementary Icon-Request Icon-Theme-Sifr Icon-Theme-Sukapura
  Show dependency treegraph
 
Reported: 2020-09-03 23:47 UTC by Rizal Muttaqin
Modified: 2020-09-13 10:30 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rizal Muttaqin 2020-09-03 23:47:02 UTC
As tdf#92287 got resolved, so now we need support for each icon theme. Currently the icon that supports still Colibre, other themes need to be updated also


Step to reproduce:
1. Open Writer
2. Enable LibreLogo toolbar, go to View > Toolbar > Logo

Version: 7.1.0.0.alpha0+
Build ID: 6a9e01ed889e92772e32ad5255fc60bd6dd7ee2a
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: kf5
Locale: id-ID (id_ID.UTF-8); UI: id-ID
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2020-09-01_22:46:39
Calc: threaded
Comment 1 Commit Notification 2020-09-06 10:36:55 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d17b80d8a0c540a5add6e675a3b42f97c4737f98

Breeze, Colibre, elementary, KJ: tdf#136454 LibreLogo icons

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 2 Commit Notification 2020-09-07 03:38:43 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7cd3527b8e5bccd99eb171a8d35c554b774a050f

Sifr, Sukapura: tdf#136454 LibreLogo icons

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 BogdanB 2020-09-11 18:48:09 UTC
I verified just for for Sifr (OK), Sukapura (OK), Colibre (OK).
So, I supose everything is fine everywhere.


Version: 7.1.0.0.alpha0+
Build ID: 3a22f5a589e822e7ca8bbb00e38a3aff93ed7ba5
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-US (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 4 Rizal Muttaqin 2020-09-12 04:07:12 UTC
(In reply to BogdanB from comment #3)
> I verified just for for Sifr (OK), Sukapura (OK), Colibre (OK).
> So, I supose everything is fine everywhere.
> 

Icon theme verification should included all icon themes with all available icon sizes (small, large, extra large) ;). Thank you Bogdan
Comment 5 BogdanB 2020-09-12 05:22:22 UTC
I will do that. It is not complicated.
Comment 6 BogdanB 2020-09-12 17:24:09 UTC
I verified all versions in all formats.

One problems I can notice:
In KJ "Home" button is an arrow to the left.
I consider a home to a be a right icon for "Home".
Comment 7 BogdanB 2020-09-12 17:24:24 UTC
Everything else is ok.
Comment 8 Rizal Muttaqin 2020-09-13 01:53:32 UTC
(In reply to BogdanB from comment #6)
> I verified all versions in all formats.
> 
> One problems I can notice:
> In KJ "Home" button is an arrow to the left.
> I consider a home to a be a right icon for "Home".

The original icon from Galaxy theme actually use that kind of icon. If you think the action as a movement home means back to the first place. Just like in media player when we go to first song.
Comment 9 BogdanB 2020-09-13 04:59:43 UTC
Yes, but maybe this symbol was created long ago, now the menaing for Home is a home. If you consider to be ok, it's ok. All the other use a Home. This is the only exception.
Comment 10 Rizal Muttaqin 2020-09-13 10:30:59 UTC
(In reply to BogdanB from comment #9)
> Yes, but maybe this symbol was created long ago, now the menaing for Home is
> a home. If you consider to be ok, it's ok. All the other use a Home. This is
> the only exception.

Sifr also use arrow style FYI