Bug 136540 - Unwanted scroll when deleting all comments by an author
Summary: Unwanted scroll when deleting all comments by an author
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Writer-Comments Writer-View-Jumps
  Show dependency treegraph
 
Reported: 2020-09-07 09:25 UTC by Telesto
Modified: 2024-10-03 03:17 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file (204.83 KB, application/vnd.oasis.opendocument.text)
2020-09-07 09:25 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-09-07 09:25:34 UTC
Description:
Unwanted scroll when deleting all comments by an author 

Steps to Reproduce:
1. Open the attached file
2. Scroll to page 13
3. Select the drop down at the comment: Delete all comments by

Actual Results:
Scrolls up to page 2

Expected Results:
Stays at the position


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: e8b8e7be0b2ad693224cd94062a55610eb69df7e
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2020-09-07 09:25:46 UTC
Created attachment 165223 [details]
Example file
Comment 2 Telesto 2020-09-26 12:55:44 UTC
Code pointer: https://bugs.documentfoundation.org/show_bug.cgi?id=135244#c12

https://gerrit.libreoffice.org/c/core/+/99714 tdf#135244 fixes PDF export case.
https://gerrit.libreoffice.org/c/core/+/99715 is for print dialog.

I couldn't repro the problem with File->Save As - well, because it was fixed in tdf#41063.

And after looking into Edit -> Track changes -> Record case, I see that it's simply general case of changing track changing options - including view/hide - which may change the view; so jumping to the cursor is a reasonable thing to do in this case.

FTR: if one wants to fix some case, one needs to debug what is the call stack leading to the jump: put a breakpoint inside SwViewShell::MakeVisible (to ScrollMDI). Then find a place in the call stack that is reasonable to create a SfxObjectShell::LockAllViews to guard the place.
Comment 3 Thomas Lendo 2020-09-26 14:08:45 UTC
Confirmed with
Version: 7.1.0.0.alpha0+
Build ID: a8c218a52a639b0e7f689dea878a0421702628e0
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3
Locale: de-DE (de_DE.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2020-09-25_22:25:07
Calc: threaded
Comment 4 Thomas Lendo 2020-09-26 14:10:38 UTC
And the view jump exists not only when deleting all comments by an author but also when deleting all comments at all.
Comment 5 Telesto 2020-09-26 14:17:53 UTC
(In reply to Thomas Lendo from comment #4)
Is it possible to get this into they easy hack area [to nearly the whole list of the same..]

Enough examples around (I hope)
https://bugs.documentfoundation.org/show_bug.cgi?id=135244#c12
Comment 6 QA Administrators 2022-09-27 03:31:40 UTC Comment hidden (obsolete)
Comment 7 Roman Kuznetsov 2022-10-03 17:04:45 UTC
Still repro in

Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 48b9cbc742de3f6120986cb6cafc92eb5009da82
CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: ru-RU
Calc: threaded
Comment 8 QA Administrators 2024-10-03 03:17:15 UTC
Dear Telesto,

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
 
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug