Bug 136576 - Add Yaru icon theme to core
Summary: Add Yaru icon theme to core
Status: RESOLVED WONTFIX
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.1.0.0.alpha0+
Hardware: All Linux (All)
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-08 17:34 UTC by Heather Ellsworth
Modified: 2020-09-18 12:14 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Heather Ellsworth 2020-09-08 17:34:54 UTC
Description:
As a supported platform, LibreOffice for Ubuntu lacks a dedicated Yaru icon theme that blends natively into a system running this theme. Development on the Yaru icon theme for Libreoffice has been developed here and is ready for inclusion: https://github.com/ubuntu/libreoffice-style-yaru-fullcolor

- All these icons are based on the Yaru icon theme (derived from the Unity8 Suru icons and Suru icon theme) and the Breeze icons for Libreoffice.

- Has full SVG support, so likely it has big advantage for future needs, like HIDPi support etc.

Steps to Reproduce:
This is not a bug to be reproduced but rather an enhancement.

Actual Results:
This is not a bug to be reproduced but rather an enhancement.

Expected Results:
This is not a bug to be reproduced but rather an enhancement.


Reproducible: Always


User Profile Reset: No



Additional Info:
This is not a bug to be reproduced but rather an enhancement.
Comment 1 Heather Ellsworth 2020-09-08 17:36:15 UTC
The proposed Yaru icon theme changes can be found here:
https://gerrit.libreoffice.org/c/core/+/102273
Comment 2 Julien Nabet 2020-09-08 17:58:56 UTC
Hello Heather,

Could you provide your license statement (see https://wiki.documentfoundation.org/Development/GetInvolved, "License statement" part)?

Taking a look at the github repo, I don't know if it's fully compatible with MPLv2/LGPLv3+ dual license but I'm not an expert about license so it may be ok.

Heiko/Xisco: since it concerns UI thought you might have some opinion here.

Rizal: since it concerns icons theme, thought you might be interested too.

About icons, there's a thread here about some problems concerning png and svg, see http://document-foundation-mail-archive.969070.n3.nabble.com/Re-ESC-meeting-minutes-2020-09-03-tt4286711.html#a4286787
Should we ping other people?
Comment 3 Rizal Muttaqin 2020-09-08 22:34:27 UTC
Hello Heather, thanks for reporting.

I am fully agree that Ubuntu need a dedicated LibreOffice icon theme instead of using GNOME targeted elementary. We can see this in the past when Ubuntu has a dedicated Human icon theme, and then for many years LibreOffice became an "alien" by using Breeze and then elementary theme.

Another icon theme is a great addition for user choice, as long as it has a dedicated maintainer. But keep in mind that having many icon themes included to the core means much maintenance burden, and by now it is just me and Andreas Kainz who are actively keeping the breath of many icon themes (one person maintain many icon themes in fact). If we take a look to this Yaru's Github repository I see the passionate, looks so promising.

I have no strong objection to this request, except may be we should consider about much larger installer size. Another thing to be considered may be is the fact that this particular icon theme is targeted to a specific GNU/Linux distribution which means it won't be reused by another distribution. This is so different with Breeze and elementary that target DE level or Colibre and Sukapura that target OS level. But this question will against also to Karasa Jaga which has no real target environment and take the largest disk space. At the end if LibO community member do not agree with request, there is always chance for Ubuntu packaging team for distributing it for their user base and every single user can obtain it as an extension.
Comment 4 Heiko Tietze 2020-09-09 06:18:01 UTC
I'd prefer to not ship icon themes anymore (and remove as much as possible) in favor of extensions. We got the tight integration thing that should make the installation a piece of cake. (Presuming icon themes can be installed as extension, not sure about this.)
Comment 5 andreas_k 2020-09-09 06:36:49 UTC
I would like to read what the designer of the libreoffice-yaru think about an integration into core (which will mean that he has to contribute to the libreoffice core repository direct) or an extension support.

on github the designer is: Paul Kepinski Jupiter007-43

If there is a maintainer I don't have a problem in addition as it's always nice to get new contributors to libO core repository.

However it's very difficult to drop an icon theme from core. For example the oxygen icon theme was > 5 years without maintainer but we couldn't drop it.

As an icon theme designer for LibO I have to say
- it's nice to work direct in the upstream repository
- but have them available as extension give you more freedom.

Ordinary I would say, that we can waite, cause the 7.1 release is fare away, but the ubuntu release is in 1,5 months.
Comment 6 Julien Nabet 2020-09-09 06:43:22 UTC
(In reply to andreas_k from comment #5)
> ...
> Ordinary I would say, that we can waite, cause the 7.1 release is fare away,
> but the ubuntu release is in 1,5 months.

New major releases are about every 6/7 months (see https://wiki.documentfoundation.org/ReleasePlan). So 7.1.0 could be released in October. Now I'm quite astonished there's nothing about 7.1 branch for the moment in this page.
Comment 7 Roman Kuznetsov 2020-09-09 18:47:32 UTC
I don't like this idea. We already have icon themes for all main OS. We can to have this Yaru icon theme as an extension

So, -1 from me
Comment 8 Paul Kepinski 2020-09-16 13:34:34 UTC
Hi everyone,
I'm the maintainer of the LO Yaru icons pack, so if you have some question to ask me you can do it.

Personally I have a few questions if you allow:
- If the icons are merged to the core repo would I be obliged to push the modifications on core instead of Github?
- In the case of a merging scenario, should I clone the whole core repo? I have a really really bad connection (about 15-50 ko/s) so it will be very complicated for me.
- And finally how does it work to contribute to core as an icon maintainer (in fact I'm afraid it will become more constraining for me compared to the actual Github repo where I'm admin)?

Thanks in advance.
Comment 9 andreas_k 2020-09-17 19:21:23 UTC
(In reply to Paul Kepinski from comment #8)
> Personally I have a few questions if you allow:
> - In the case of a merging scenario, should I clone the whole core repo? I
> have a really really bad connection (about 15-50 ko/s) so it will be very
> complicated for me.

True that's a showstopper the LibreOffice core repository has > 2 GB and you have to download it.

So I think the best is to let you do what you did and you can release the icon theme on extensions.libreoffice.org/
Comment 10 Paul Kepinski 2020-09-17 22:37:45 UTC
(In reply to andreas_k from comment #9)
> True that's a showstopper the LibreOffice core repository has > 2 GB and you
> have to download it.
> 
> So I think the best is to let you do what you did and you can release the
> icon theme on extensions.libreoffice.org/

Thank you for the answer :-)
So I prefer to stay on Github for the moment.
I've already published it as an extension here: https://extensions.libreoffice.org/en/extensions/show/1042
Comment 11 Heiko Tietze 2020-09-18 12:14:49 UTC
(In reply to Paul Kepinski from comment #10)
> I've already published it as an extension here:
> https://extensions.libreoffice.org/en/extensions/show/1042

That's super cool. Plan is to have a button next to the icon theme selector that allows to load more themes from the extensions site. And yours will be among it. I'm an advocate of this method in general and would ship rather less artwork.

Resolving as WF since the extension solution is perfectly fine.