Bug 136620 - FILESAVE: DOC: TextWrap is lost after RT
Summary: FILESAVE: DOC: TextWrap is lost after RT
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.1.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Michael Stahl (allotropia)
URL:
Whiteboard: target:7.1.0 target:7.0.3
Keywords: bibisected, bisected, regression
: 136708 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-09-09 18:39 UTC by Xisco Faulí
Modified: 2020-09-23 15:48 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Comparison MSO 2010 and LibreOffice 7.1 master after RT (584.30 KB, image/png)
2020-09-09 18:39 UTC, Xisco Faulí
Details
attachment 57348 (88.19 KB, image/png)
2020-09-09 18:51 UTC, Xisco Faulí
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2020-09-09 18:39:51 UTC
Created attachment 165333 [details]
Comparison MSO 2010 and LibreOffice 7.1 master after RT

Steps to reproduce:
1. Open attachment 53799 [details] from bug 43193
2. Save it as DOC
3. Open the new generated file

-> Textboxes around the drawing have lost the textwrap. See comparison

Reproduced in

Version: 7.1.0.0.alpha0+
Build ID: 63d4d3421fec5a4e9e88dcee2992cda38cc7452a
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

[Bug found by office-interoperability-tools]
Comment 1 Xisco Faulí 2020-09-09 18:40:54 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=2cb90a5c87fe46737c8d840967d8836284f92ffd

author	Michael Stahl <Michael.Stahl@cib.de>	2020-08-07 15:26:48 +0200
committer	Michael Stahl <michael.stahl@cib.de>	2020-08-07 18:25:31 +0200
commit 2cb90a5c87fe46737c8d840967d8836284f92ffd (patch)
tree eda6fd4cc5635791fdd0a278d77a1ab2e108fa31
parent 1a13804092f93dd77b081ea063856d9896838a51 (diff)
filter: MSO export: convert TextWrap property to Escher_Wrap*

Bisected with: bibisect-linux64-7.1

Adding Cc: to Michael Stahl
Comment 2 Xisco Faulí 2020-09-09 18:41:20 UTC
@Justin Luth, I thought you might be interested in this issue
Comment 3 Xisco Faulí 2020-09-09 18:51:11 UTC
Created attachment 165334 [details]
attachment 57348 [details]

attachment 57348 [details] from bug 46361 is also affected by the same commit
Comment 4 Justin L 2020-09-10 06:14:30 UTC
(In reply to Xisco Faulí from comment #2)
> @Justin Luth, I thought you might be interested in this issue

Shapes and positioning is not really my area..., although the DOC format is important to me.
Comment 5 Michael Stahl (allotropia) 2020-09-18 14:25:59 UTC
*** Bug 136708 has been marked as a duplicate of this bug. ***
Comment 6 Commit Notification 2020-09-21 09:02:53 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/fdc8590032b292dcb8152b328401e591fea642a4

tdf#136620 tdf#136708 filter,oox,sw: fix export of 2 different wraps

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2020-09-21 11:15:36 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/c54d697e2ac379d4b1a3ff5acb6f06bff30cadd6

tdf#136620 tdf#136708 filter,oox,sw: fix export of 2 different wraps

It will be available in 7.0.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2020-09-22 14:56:37 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/456bc04c9879f8ca191bd633f7341241c3cea317

tdf#136620: sw_ww8export: Add unittest

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 BogdanB 2020-09-23 15:22:17 UTC
This bug is resolved but appear to be just assigned... Please change...
Comment 10 Michael Stahl (allotropia) 2020-09-23 15:32:35 UTC
fixed
Comment 11 BogdanB 2020-09-23 15:48:45 UTC
it's ok now.

Verified in
Version: 7.1.0.0.alpha0+
Build ID: 121771e37f7e2de41cd5643475861062bf25627b
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded