Created attachment 165715 [details] Underline lines not visible The lines in underline menu are not visible. See attached image for more info. Version: 7.0.1.2 Build ID: 00(Build:2) CPU threads: 2; OS: Linux 5.4; UI render: default; VCL: kf5 Locale: en-US (en_US.UTF-8); UI: en-US =7.0.1-1 Calc: threaded Operating System: Manjaro Linux KDE Plasma Version: 5.19.5 KDE Frameworks Version: 5.73.0 Qt Version: 5.15.0 Kernel Version: 5.4.64-1-MANJARO OS Type: 64-bit
don't repro in Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: c5ca46e75e28ba4245d8544ca53c71fea87d1bbd CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: en-US (ru_UA); UI: en-GB Calc: threaded
This problem is specific to Linux, you should install Manjaro KDE or Kubuntu or any Linux distro with KDE desktop manager and set OS theme to dark to test it.
It's still repro on KDE with VCL: fk5 Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: b60b6bfaafa1315e07108dba50f016975b619c59 CPU threads: 2; OS: Linux 5.4; UI render: default; VCL: kf5 (cairo+xcb) Locale: en-US (en_US.UTF-8); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-09-28_03:43:58 Calc: threaded Operating System: Manjaro Linux KDE Plasma Version: 5.22.5 KDE Frameworks Version: 5.85.0 Qt Version: 5.15.2 Kernel Version: 5.4.144-1-MANJARO (64-bit) Graphics Platform: X11
I can reproduce bad contrast for this case when using the Plasma Breeze Dark theme with Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 7a4250b74b53c8f5d650319dfe0509ce9dd80900 CPU threads: 12; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: en-GB (en_GB.UTF-8); UI: en-US Calc: threaded
So I just checked svx/uiconfig/ui/textunderlinecontrol.ui / svx/source/sidebar/text/TextUnderlineControl.cxx and unfortunately (because I can't fix it easily) found, that these lines aren't painted by LO, but are actually icons (icon-themes/*/svx/res/symphony/line*). So this needs new icons for the dark icon sets. Nothing VCL or even plugin specific. I would prefer an non-icon implementation, so the popup would select the correct line color and "just" paint the lines, like LO does for underlining the text, but that is much more work.
Ohh - icon-themes/colibre_dark*/svx/res/symphony/line* exists, so probably just copy that into other dark icon sets? Or some proper fallback for dark icon themes, so we just need these line icons once?
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/84706376e333ca5cf9ccb9a2c08daef93fa3b16d Breeze & Sifr tdf#136916 add dark underlines variant icons It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "libreoffice-7-3": https://git.libreoffice.org/core/commit/f56cbeccb35c569d6ca1c6ecffed160379845957 Breeze & Sifr tdf#136916 add dark underlines variant icons It will be available in 7.3.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.