Bug 137081 - page anchored shapes are mirrored on reopen in a RTL sheet
Summary: page anchored shapes are mirrored on reopen in a RTL sheet
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.1.0.0.alpha0+
Hardware: x86-64 (AMD64) Windows (All)
: medium normal
Assignee: Regina Henschel
URL:
Whiteboard: target:7.2.0 target:7.1.1
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-27 21:52 UTC by Regina Henschel
Modified: 2021-02-10 12:41 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2020-09-27 21:52:01 UTC
Start Calc. Set the writing direction to "right-to-left" in the page properties and set the sheet to "Right-To-Left" in menu Sheet.

Insert an asymmetric shape, for example "Flash" or "Corner Right Arrow".

Save the document and reopen it.

Error: The shape is mirrored.

I don't know yet, whether the error happens on save or load.
Comment 1 Martin Srdoš 2020-12-19 15:03:21 UTC
Hello Regina,

Thank you for reporting the bug. I can confirm that the bug is present in master.

Version: 7.2.0.0.alpha0+ (x64)
Build ID: 59301a1cadd87a63276650975252d14e8477e632
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: cs-CZ (cs_CZ); UI: en-US
Calc: threaded

also in

Version: 4.1.0.1
Build ID: 1b3956717a60d6ac35b133d7b0a0f5eb55e9155
Comment 2 Regina Henschel 2020-12-19 15:08:22 UTC
If Excel saves a RTL sheet with a shape, then it mirrors the shape horizontally. If LibreOffice opens such file, the shape looks the same as in Excel.
If LibreOffice saves a RTL sheet with a shape, then it does not mirror the shape and the shape looks wrong, when reopening the file.

Therefore I think, LibreOffice should mirror the shape on saving.
Comment 3 Martin Srdoš 2020-12-19 17:22:04 UTC
(In reply to Regina Henschel from comment #2)
> If Excel saves a RTL sheet with a shape, then it mirrors the shape
> horizontally. If LibreOffice opens such file, the shape looks the same as in
> Excel.
> If LibreOffice saves a RTL sheet with a shape, then it does not mirror the
> shape and the shape looks wrong, when reopening the file.
> 
> Therefore I think, LibreOffice should mirror the shape on saving.

For me, if I don't use excel, but only calc, then the pictures are mirrored every time, when I've saved them. It is bug. Second thing which show for bug is, it dont happen in LTR.
Comment 4 Commit Notification 2021-02-02 21:06:51 UTC
Regina Henschel committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/65129e0bc5abfe7afc612eb46f1434e627265a7d

tdf#137081, tdf137082 fixes shape handling in RTL sheets

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2021-02-10 12:41:42 UTC
Regina Henschel committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/7b2999ab91aa6fc6632dd87ca0bc950e5484c35a

tdf#137081, tdf137082 fixes shape handling in RTL sheets

It will be available in 7.1.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.