Bug 137162 - [DOCX] Number of Columns displayed in dialog Page Style>Columns is one too low
Summary: [DOCX] Number of Columns displayed in dialog Page Style>Columns is one too low
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
5.4 all versions
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, filter:docx, regression
Depends on:
Blocks: Page-Style-Dialog Page-Layout-Columns DOCX-Page
  Show dependency treegraph
 
Reported: 2020-09-30 14:07 UTC by Cor Nouws
Modified: 2022-12-08 06:12 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
docx with 2 columns (4.33 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2020-09-30 14:07 UTC, Cor Nouws
Details
odt with two columns (8.43 KB, application/vnd.oasis.opendocument.text)
2020-09-30 14:07 UTC, Cor Nouws
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Cor Nouws 2020-09-30 14:07:23 UTC
Created attachment 165980 [details]
docx with 2 columns

Create a file with two colunms.
Save as odt
Look at Format > Page > Columns ..
  > number is 2 = Good

Save as DOCX, close and reopen
Look at Format > Page > Columns ..
  > number is 1 = Wrong

Noticed in Version: 7.0.0.3
Build ID: 8061b3e9204bef6b321a21033174034a5e2ea88e
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: nl-NL (en_US.UTF-8); UI: en-US
Calc: threaded

Will attach testfiles
Comment 1 Cor Nouws 2020-09-30 14:07:53 UTC
Created attachment 165981 [details]
odt with two columns
Comment 2 Cor Nouws 2020-09-30 14:15:12 UTC
Ok in Version: 5.0.6.3
Build ID: 490fc03b25318460cfc54456516ea2519c11d1aa
Locale: en-US (en_US.UTF-8)

(and possibly some later - not in 6.2.8) > Regression
Comment 3 Dieter 2020-10-01 06:14:01 UTC
I confirm it with

Version: 7.0.1.2 (x64)
Build ID: 7cbcfc562f6eb6708b5ff7d7397325de9e764452
CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: threaded
Comment 4 Attila Baraksó (NISZ) 2020-10-03 13:51:30 UTC
FILEOPEN bug.

Bibisected using linux-64-5.4 to:
URL: https://cgit.freedesktop.org/libreoffice/core/commit/?id=4605bd46984125a99b0e993b71efa6edb411699f
author: Justin Luth <justin_luth@sil.org>
committer: Miklos Vajna <vmiklos@collabora.co.uk>
summary: tdf#103931 writerfilter breaktype: same for implicit and explicit
Comment 5 Justin L 2020-10-03 14:11:22 UTC
I'm not sure I see the problem.  I always see two columns.  (Whether the columns are defined in the page style or in the section should be irrelevant.)

Microsoft doesn't have the concept of a page style, just sections, so everything here is just emulation. LO can define columns in both page styles and sections. Importing columns into page styles caused all kinds of problems.

I tested both files using LO 6.4.6
Comment 6 Dieter 2020-10-03 14:16:22 UTC
(In reply to Justin L from comment #5)
> I'm not sure I see the problem.  I always see two columns.

That's true, but page style dialog shows "1" in columns setting (it should be "2").
Comment 7 Justin L 2020-10-03 16:13:01 UTC
(In reply to Dieter from comment #6)
> (In reply to Justin L from comment #5)
> That's true, but page style dialog shows "1" in columns setting (it should
> be "2").

No, it should be 1.  The section (Format -> Section -> Options) is where DOCX files define columns, so that is where you will find two columns defined.
Comment 8 Justin L 2020-11-17 10:43:13 UTC
NOTABUG. For interoperability, it is better to define columns in section settings, instead of page styles.
Comment 9 Cor Nouws 2020-11-18 15:17:23 UTC
(In reply to Justin L from comment #7)
> (In reply to Dieter from comment #6)
> > (In reply to Justin L from comment #5)
> > That's true, but page style dialog shows "1" in columns setting (it should
> > be "2").
> 
> No, it should be 1.  The section (Format -> Section -> Options) is where
> DOCX files define columns, so that is where you will find two columns
> defined.
Hi Justin,

Sorry to nag you ;)  Now when you
 -  open the docx, and set the nr of columns to 3 (in Format > Page ;) )
    you get 4...
 -  do Ctrl+Shft+R at the bottom there is another column..

A column within another column ? It behaves weird for me.
And it did not in older versions.
Comment 10 Justin L 2020-11-18 15:29:42 UTC
(In reply to Cor Nouws from comment #9)
> Sorry to nag you ;)  Now when you
>  -  open the docx, and set the nr of columns to 3 (in Format > Page ;) )

That sounds like a very bad idea to me. If the columns that are defined are defined in Format - Columns, then the only logical way to adjust the columns would be to change them in the same location - not by defining columns in two different ways (via page format too).
Comment 11 Cor Nouws 2020-11-18 15:33:24 UTC
(In reply to Justin L from comment #10)
> That sounds like a very bad idea to me. If the columns that are defined are
> defined in Format - Columns, then the only logical way to adjust the columns
> would be to change them in the same location - not by defining columns in
> two different ways (via page format too).
I'm not arguing that :) My report is about something different.

All I noticed: Columns via Format > Page, safe odt as docx, behaved consistent in the past.
Now it is a bit, well.. messy ;)
Comment 12 QA Administrators 2022-12-08 03:25:44 UTC Comment hidden (obsolete)
Comment 13 Dieter 2022-12-08 06:12:58 UTC
Retested with

Version: 7.4.3.2 (x64) / LibreOffice Community
Build ID: 1048a8393ae2eeec98dff31b5c133c5f1d08b890
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL

Steps:
1. Open attachment 165981 [details]
2. File contains a section with 2 columns and page style has one column (expected)
3. Save as odt-file => section with 2 columns and page style with one column (expected)
3. Save as docx-file => section with 2 columns and page style with one column (expected)

So I can't see the problem described in original bug report
=> RESOLVED WORKSFORME (please change back to UNCONFIRMED, if you disagree, Cor)

Additional information
I see the problem, that I can't enter text outside the section. But that might be a different problem.