Bug 137249 - Dashes not replaced by autocorrect
Summary: Dashes not replaced by autocorrect
Status: RESOLVED NOTABUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.3.0.3 rc
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2020-10-04 21:30 UTC by Telesto
Modified: 2020-10-09 08:10 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Bibisect log (3.37 KB, text/plain)
2020-10-06 14:54 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-10-04 21:30:38 UTC
Description:
Dashes not replaced by autocorrect

Steps to Reproduce:
1. Open Writer
2. Hold ----
3. Press Enter

Actual Results:
Dashes still present

Expected Results:
Dashes replaced by line


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: 7f16cabf00daa30e9284d2fb2494bd341352c25e
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
Locale: nl-NL (nl_NL); UI: nl-NL
Calc: threaded

and with
Version: 7.0.0.0.beta1+ (x64)
Build ID: 2891e91a513520d68ea2b8c59c14335861a15253
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

also with
6.4 -> but odd, based on bug 137245
Comment 1 Telesto 2020-10-06 14:54:56 UTC
Created attachment 166130 [details]
Bibisect log

Bisected to
author	Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>	2019-02-15 12:10:47 +0100
committer	Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>	2019-02-15 14:43:27 +0100
commit 3473e1df1fa3483bae68a3c01fdd1b18def99745 (patch)
tree af58b1c0b78f4a52e2a67e383fa28327636563fd
parent 18975274ddc585cc3e3e8b6ae5c2800b27723444 (diff)
Disable automatic border creation in sw
This "feature" would convert "___" to a full width paragraph border.

See e.g. https://ask.libreoffice.org/en/question/15711/stop-auto-line-formatting/
for problems caused by this.

So I strongly suggest to turn this "feature" off by default.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=3473e1df1fa3483bae68a3c01fdd1b18def99745
Comment 2 Telesto 2020-10-06 14:56:48 UTC
Adding CC: to Samuel Mehrbrodt

Replace dashes with line is enabled for autocorrect (by default) but not working anymore
Comment 3 Heiko Tietze 2020-10-07 08:29:06 UTC
Although there is no ticket with a discussion, the comment on the patch makes it pretty clear why this was done. And you didn't add an argument/use case to revert and enable the autocorrection. => WF
Comment 4 Telesto 2020-10-07 08:46:40 UTC
(In reply to Heiko Tietze from comment #3)
> Although there is no ticket with a discussion, the comment on the patch
> makes it pretty clear why this was done. And you didn't add an argument/use
> case to revert and enable the autocorrection. => WF

Tools -> Autocorrect -> Autocorrect options -> Options tab -> Replace dashes is being checked..so enabled.. 

So it appears to be disabled the wrong way :-). If this setting should be enabled or disabled by default is by itself another discussion.. MSO does the same thing (not sure how strong that argument is). And this being the behavior since.. long time (with some interval of being broken..)

However the 'boom' aspect as argued in the ask topic is pretty the same as markdown issue. However here this clearly being 'allowed' [sorry, keep bring this up until a compromise being found :-]

Not having a 'strong' preference.. could start about a kind of dialog with 'most common' configuration settings instead of being distributed across the place.

So to be short, this bugfix is incomplete or simply wrong. Aside of the topic if this the right thing to do.. but should be but on the UX agenda to get a kind of 'formal' decision, instead of sneaking it in.
Comment 5 Heiko Tietze 2020-10-07 09:58:21 UTC
Confirming, no effect whether the option is checked or not. Default should be off, as Samuel commented in his patch.
Comment 6 Heiko Tietze 2020-10-07 09:58:51 UTC
(In reply to Heiko Tietze from comment #5)
> Confirming...

Version: 6.4.6.2
Build ID: 6.4.6-2
CPU threads: 8; OS: Linux 5.8; UI render: default; VCL: kf5; 
Locale: de-DE (en_US.UTF-8); UI-Language: en-US
Calc: threaded
Comment 7 V Stuart Foote 2020-10-07 13:47:37 UTC
The check-box option is 'Apply Border' present in the while Typing column.

As with Samuel's commit setting it <False> it is now disabled by default.

The 'Replace dashes' is a different feature.

=-ref-=
https://help.libreoffice.org/7.1/en-US/text/shared/01/06040100.html?&DbPAR=WRITER&System=WIN
Comment 8 Heiko Tietze 2020-10-09 08:10:32 UTC
(In reply to V Stuart Foote from comment #7)
> The check-box option is 'Apply Border' present in the while Typing column.

That works. Confusing label, given that "Replace Dashes" is there too. How about "Apply border below paragraph for ---" and "Replace dashes (-- to –)" (or kind of since this option has no effect on --.

The help page is very informative, by the way. Great job, Olivier.