Bug 137318 - Redlinehide: Undo action displays content incorrectly.
Summary: Redlinehide: Undo action displays content incorrectly.
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.3.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Michael Stahl (allotropia)
URL:
Whiteboard: target:7.4.0 target:7.3.0.0.beta2 tar...
Keywords: bibisected, regression
Depends on:
Blocks: redlinehide-regressions
  Show dependency treegraph
 
Reported: 2020-10-07 17:58 UTC by Xisco Faulí
Modified: 2021-12-29 03:37 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
sample file (8.00 KB, application/vnd.oasis.opendocument.text)
2020-10-07 17:58 UTC, Xisco Faulí
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2020-10-07 17:58:41 UTC
Created attachment 166168 [details]
sample file

Steps to reproduce:
1. Open attached document ( basic document with a word and then Tracked changes enabled and not shown)
2. Put the cursor after the A and delete it
3. Press Enter twice
4. Undo

-> A is displayed on second paragraph. Nothing should be displayed instead

Reproduced in

Version: 7.1.0.0.alpha0+
Build ID: ff5ca4e5fc6a9fb24b0eb6eb629210b024473f67
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 1 Xisco Faulí 2020-10-07 18:00:09 UTC
The document started to crash deleting the word after https://cgit.freedesktop.org/libreoffice/core/commit/?id=d258fc29560baa5ecae03ebc2740e11420643e27. Later the crash was fixed in https://cgit.freedesktop.org/libreoffice/core/commit/?id=f609eba8b979620dc8f1c4a47d710360f8aae9e6.
Since then, this issue is reproducible

Adding Cc: to Michael Stahl
Comment 2 Xisco Faulí 2021-03-31 14:14:46 UTC
Dear Michael Stahl,
This bug has been in ASSIGNED status for more than 3 months without any
activity. Resetting it to NEW.
Please assign it back to yourself if you're still working on this.
Comment 3 Commit Notification 2021-12-17 18:08:38 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/31f51598fd08c2b76583a1baad0c0d6d4b336664

tdf#137318 sw_redlinehide: fix JoinNext() if deleted node contains redlines

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Michael Stahl (allotropia) 2021-12-20 11:12:58 UTC
fixed on master
Comment 5 Commit Notification 2021-12-20 14:19:30 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d246fcf94638604911ef11ff2f4bdc0c5ba8dbfc

tdf#137318 sw_redlinehide: fix assert on export moz715138-3.doc to ODF

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2021-12-21 08:32:54 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/66526bc24b884b361b06aea7529227b486423853

tdf#137318 sw_redlinehide: fix assert on export moz715138-3.doc to ODF

It will be available in 7.2.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2021-12-21 08:33:06 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/86f539a23b08d0cc9e5e9566ac31380e373be13f

tdf#137318 sw_redlinehide: fix assert on export moz715138-3.doc to ODF

It will be available in 7.3.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2021-12-23 10:09:41 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-7-2-5":

https://git.libreoffice.org/core/commit/5f6b1a350685e2935bc69a9dc1e0b32ed171db6b

tdf#137318 sw_redlinehide: fix JoinNext() if deleted node contains redlines

It will be available in 7.2.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2021-12-28 08:29:03 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-7-2-5":

https://git.libreoffice.org/core/commit/0832b5487ab41f850a73931ad31d85d989c7aa26

tdf#137318 sw_redlinehide: fix assert on export moz715138-3.doc to ODF

It will be available in 7.2.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.