Bug 137386 - Paragraph settings displayed after undo are not correct, if the undo selection is used when opening the dialog
Summary: Paragraph settings displayed after undo are not correct, if the undo selectio...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Undo-Redo Selection
  Show dependency tree / graph
 
Reported: 2020-10-11 05:23 UTC by Telesto
Modified: 2023-12-01 08:11 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Attachments
Example file (4.16 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2020-10-11 05:24 UTC, Telesto 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-10-11 05:23:49 UTC 
Description:
Page break setting doesn't show after undo, if the undo selection is used when opening the dialog

Steps to Reproduce:
1. Open the attached file
2. Drag hello to the second line
3. Undo
4. Format Paragraph page flow tab

Actual Results:
Break setting doesn't show

Expected Results:
Page break setting being active


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.1.0.0.alpha0+
Build ID: 64ab07edee8eba531fd05cbc5d92315cc2855e92
CPU threads: 4; OS: Mac OS X 10.12.6; UI render: default; VCL: osx
Locale: nl-NL (nl_NL.UTF-8); UI: en-US
Calc: threaded
Comment 1 Telesto 2020-10-11 05:24:22 UTC 
Created attachment 166261 [details]
Example file
Comment 2 Telesto 2020-10-11 11:02:34 UTC 
LibreOffice 3.3.0 
OOO330m19 (Build:6)
tag libreoffice-3.3.0.4
Comment 3 Kevin Suo 2020-10-12 08:24:41 UTC 
I do not reproduce.

By saying "Format Paragraph page flow tab" in step 4, do you mean the 1st paragraph or the 2nd one (i.e., the blank line)? The 1st paragraph does have page break set after the undo. The 2nd paragraph initially is not set to have page break, and does not have page break after the undo, which is expected.
Comment 4 Telesto 2020-10-12 09:16:57 UTC 
(In reply to Kevin Suo from comment #3)
> I do not reproduce.
> 
> By saying "Format Paragraph page flow tab" in step 4, do you mean the 1st
> paragraph or the 2nd one (i.e., the blank line)? The 1st paragraph does have
> page break set after the undo. The 2nd paragraph initially is not set to
> have page break, and does not have page break after the undo, which is
> expected.

1. Open the attached file
2. Select hello
3. Format -> Paragraph -> Text Flow Tab -> Notice break settings being set
4. Drag hello to the second line (new page is added)
5. CTRL+Z
6. Hello is selected caused by CTRL+Z. Now Format -> Paragraph -> Text Flow Tab -> Notice settings being empty
Comment 5 Kevin Suo 2020-10-12 10:37:26 UTC 
(In reply to Telesto from comment #4)

Now I can reproduce following your steps. It seems that the paragraph page break setting is correct, only the dialog opened after the ctrl-z is wrong. When manually select the text again and reopen the dialog, the settings is correct.

Set to New.
Comment 6 QA Administrators 2022-10-13 03:32:27 UTC Comment hidden (obsolete)
Comment 7 Stéphane Guillou (stragu) 2023-12-01 08:11:39 UTC 
Since 7.1 and Justin's fix for bug 118711 (c6e46a2fdef325a94ef2d43f5eb4a0ff47b28a14 / 8787a45f9cbb5dce61b20817ef0e549b5a227a95), the setting is not on at fileopen and has to be reapplied. But still reproduced as in comment 4.
Selecting "Hello" again by hand does show the right settings.

But seems to be a more general issue, not just about breaks. For example:
1. New file with two paragraphs
2. In first paragraph, type "test" and apply paragraph borders to it.
3. Select "test", drag-and-drop it to paragraph 2
4. Undo and look at Format > Paragraph > Borders without changing the selection: no borders set.
5. Select "test" again, open dialog again: settings match.

Changing the summary accordingly.