Bug 137503 - fix Undo/Redo of deletions of paragraphs in ShowChangesInMargin mode
Summary: fix Undo/Redo of deletions of paragraphs in ShowChangesInMargin mode
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.1.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.2.0 target:7.1.0.0.beta2
Keywords:
Depends on: 137684
Blocks: tracked-changes-in-margin
  Show dependency treegraph
 
Reported: 2020-10-15 13:34 UTC by László Németh
Modified: 2021-01-01 06:00 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description László Németh 2020-10-15 13:34:56 UTC
Undo/Redo is broken with the fix for Bug 34355 using the new ShowChangesInMargin mode.
Comment 1 NISZ LibreOffice Team 2020-11-12 09:22:32 UTC
One way to illustrate this:
* Have some loremipsum text in a new document when changes in margin mode is enabled
* Press backspace three times on a word (two is not enough to trigger this problem)
* Undo all these steps -> crash at the third.

Happens on a fresh nightly:
Version: 7.1.0.0.alpha1+ (x64)
Build ID: 693553210828538680408832157faad9654758c8
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL
Comment 2 Commit Notification 2020-11-26 07:55:31 UTC
László Németh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/586bd08fa2655ad90ef4777626ad8f17d6a2c4ce

tdf#137503 sw ChangesInMargin: fix Undo/Redo of deleted paragraph

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2020-11-26 12:01:52 UTC
László Németh committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/1a9ab76e9cc904ecad902f460e985b8721eb6fdd

tdf#137503 sw ChangesInMargin: fix Undo/Redo of deleted paragraph

It will be available in 7.1.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 NISZ LibreOffice Team 2020-12-10 10:21:52 UTC
Verifed in:

Version: 7.2.0.0.alpha0+ (x64)
Build ID: e4dc69b2b97dbd56bd55e514a5abcbd3c2a2f2fb
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Vulkan; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: threaded