Bug 137504 - fix Undo/Redo of Accept/Reject of deletions in ShowChangesInMargin mode
Summary: fix Undo/Redo of Accept/Reject of deletions in ShowChangesInMargin mode
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.1.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
: 151639 (view as bug list)
Depends on:
Blocks: tracked-changes-in-margin
  Show dependency treegraph
 
Reported: 2020-10-15 13:37 UTC by László Németh
Modified: 2024-09-10 16:02 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file from current Writer (18.45 KB, application/vnd.oasis.opendocument.text)
2021-07-15 10:58 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description László Németh 2020-10-15 13:37:16 UTC
Undo/Redo is broken with the fix for Bug 34355 using the new ShowChangesInMargin mode.
Comment 1 NISZ LibreOffice Team 2021-07-15 10:58:40 UTC
Created attachment 173593 [details]
Example file from current Writer
Comment 2 NISZ LibreOffice Team 2021-07-15 11:20:49 UTC
Attached file contains two insertions and two deletions. Undo-redo can break if:

* Select from the Track Changes toolbar the Deletions in Margin mode.
In the Manage Changes dialog, select a deletion.
- Accept it. OK, it disappears.
- On the toolbar, Undo. OK, it comes back as deletion.
- On the toolbar, Redo. Bad: the change does not disappear, stays deleted.

Reload, select a deletion.
- Reject it. OK, the text comes back.
- On the toolbar, Undo. OK, the text goes back to be a deletion.
- On the toolbar, Redo. Bad: the text does not come back, stays deleted.

Accepting and rejection insertions, then Undo-Delete works fine.
Comment 3 NISZ LibreOffice Team 2021-07-15 14:00:00 UTC
Another way is to enable the Insertions In Margin mode.

In the Manage Changes dialog select a deletion change.
- Accept it. OK, it disappears.
- On the toolbar Undo. OK, it comes back as deletion. But it is displayed on the margin.
- On the toolbar Redo. Bad: the deletion remains and is not accepted.

Reload, enable Insertions In Margin mode, then select a deletion change in Manage Changes.
- Reject it. OK, the text is no longer deleted.
- On the toolbar Undo. OK, it comes back as deletion. But it is displayed on the margin.
- On the toolbar, Redo. Bad: The deletion remains and is not rejected.

In this mode accepting/rejecting insertion changes works, but after Undo they appear in the text, not margin.
Comment 4 Xisco Faulí 2022-05-03 11:47:23 UTC
Dear László Németh,
This bug has been in ASSIGNED status for more than 3 months without any
activity. Resetting it to NEW.
Please assign it back to yourself if you're still working on this.
Comment 5 Roman Kuznetsov 2022-10-20 18:39:29 UTC
*** Bug 151639 has been marked as a duplicate of this bug. ***
Comment 6 Buovjaga 2024-09-10 16:02:11 UTC
Still repro with document.

Arch Linux 64-bit
Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 880096c3a970389de9f1272509d2d03df046570a
CPU threads: 8; OS: Linux 6.10; UI render: default; VCL: kf6 (cairo+wayland)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: CL threaded
Built on 10 September 2024