Bug 137637 - Object area for auto-layouts deselected after switching to Animation Sidebar deck
Summary: Object area for auto-layouts deselected after switching to Animation Sidebar ...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
7.0.0.3 release
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.3.0 target:7.1.6 target:7.2.1
Keywords: bibisected, bisected, regression
: 138939 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-10-20 18:58 UTC by Telesto
Modified: 2021-11-17 16:13 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-10-20 18:58:57 UTC
Description:
Object area for auto-layouts deselected after pressing + in animation tab

Steps to Reproduce:
1. Open Impress
2. Press Cancel on the wizard
3. Select the text box or more precise Object area for auto-layouts 
4. Select the animation tab -> Deselects
5. Select it again
6. Press + for effect -> Deselected

Actual Results:
Deselected

Expected Results:
Not so


Reproducible: Always


User Profile Reset: No



Additional Info:
Found in
7.1

not in
Version: 6.4.0.0.beta1+ (x64)
Build ID: 20be5cd0bdc57d812bf34a2debfe48caa51de881
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: GL; VCL: win; 
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: CL
Comment 1 Telesto 2020-10-20 21:08:47 UTC
Bibisected
1. Open Impress 
2. Cancel the wizard
3. Make sure properties tab deck is active, not animation. If animation active.. Switch to properties. And open impress again
4. Select the text box or more precise Object area for auto-layouts 
5. Select the animation tab -> Deselects

Bisected to:
author	Caolán McNamara <caolanm@redhat.com>	2020-03-24 11:44:16 +0000
committer	Caolán McNamara <caolanm@redhat.com>	2020-04-06 21:24:40 +0200
commit 21e8ce9ab9a522d25e95773af59b7ccccaee4e54 (patch)
tree 75e0730830aade810b84ccb3f51ba511faf03513
parent 01546c005eaf6bce8fe4066dbec92c5655190a2a (diff)
weld custom animation panel
and align animation panel and slide transitions panel padding/spacing

https://cgit.freedesktop.org/libreoffice/core/commit/?id=21e8ce9ab9a522d25e95773af59b7ccccaee4e54
Comment 2 Telesto 2020-10-20 21:11:47 UTC
Adding CC: to Caolán McNamara

Unconfirmed at the moment, but bibisected (note: I bisected the in comment 1 given steps; so not they title here.. (or step 5/6 in comment 0) but I assume it's related
Comment 3 Buovjaga 2021-07-27 12:30:25 UTC
Repro

NixOS
Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 67e47070a7580a17804adce812cc2f98bfe7b51f
CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: x11
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Comment 4 Commit Notification 2021-08-03 15:40:55 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/fcc0e6983f2e736022ecf22726cc34e50bd53f24

Resolves: tdf#137637 keep user selection during initialization

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Caolán McNamara 2021-08-03 15:43:31 UTC
backport to 7-2 and 7-1 in gerrit
Comment 6 Commit Notification 2021-08-08 10:31:26 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/9a3acd91284d40714fdf08868e34e64de6e8ad2b

Resolves: tdf#137637 keep user selection during initialization

It will be available in 7.1.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2021-08-08 10:32:39 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/6cd3c4c6cc7decd7a63ff891573ace858330b110

Resolves: tdf#137637 keep user selection during initialization

It will be available in 7.2.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Xisco Faulí 2021-08-18 09:00:37 UTC
*** Bug 138939 has been marked as a duplicate of this bug. ***
Comment 9 Xisco Faulí 2021-08-18 09:24:09 UTC
Verified in

Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 615a340fcf05845397ea3c9917e2eadf074b4514
CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

@Caolán, thanks for fixing this issue!!
Comment 10 Commit Notification 2021-11-17 16:13:22 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/041379f6420f6d67bfd2bb952968e8c183f13a9d

tdf#137637: sd: Add UItest

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.