Bug 137638 - No thumbnail preview in start center of specific docx document
Summary: No thumbnail preview in start center of specific docx document
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
5.4.0.3 release
Hardware: All All
: medium normal
Assignee: Miklos Vajna
URL:
Whiteboard: target:7.2.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2020-10-20 21:20 UTC by Telesto
Modified: 2020-12-15 17:03 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
The example file in LO 6.4.0 and 7.1 alpha (89.48 KB, image/png)
2020-10-26 13:10 UTC, NISZ LibreOffice Team
Details
Bibisect log (2.90 KB, text/plain)
2020-11-02 22:01 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-10-20 21:20:04 UTC
Description:
No thumbnail preview in start center of specific docx document

Steps to Reproduce:
1. Open attachment 166495 [details]
2. Close the document, back to start center -> Lacking a thumbnail


Actual Results:
No preview

Expected Results:
Should be so, working in 5.4


Reproducible: Always


User Profile Reset: No



Additional Info:
Found in
7.1

and in
6.2

not in
5.4
Comment 1 Telesto 2020-10-20 21:20:33 UTC
For the record
Version: 6.2.0.0.alpha0+
Build ID: 391134e4cc0cf444ac50c6df02073de57ad9c466
CPU threads: 2; OS: Linux 5.3; UI render: default; VCL: x11; 
Locale: en-US (en_US.UTF-8); Calc: group threaded
Comment 2 Attila Baraksó (NISZ) 2020-10-23 13:51:14 UTC
Reproduced in:

Version: 7.1.0.0.alpha0+
Build ID: f1d798151048dde3f48b124ef406416668d1e9c5
CPU threads: 6; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: threaded
Comment 3 NISZ LibreOffice Team 2020-10-26 13:10:22 UTC Comment hidden (off-topic)
Comment 4 Telesto 2020-11-02 22:01:54 UTC
Created attachment 166957 [details]
Bibisect log

Bisected to
author	Miklos Vajna <vmiklos@collabora.co.uk>	2017-01-06 13:49:06 +0100
committer	Jan Holesovsky <kendy@collabora.com>	2017-01-06 15:14:50 +0000
commit af313fc149f80adb0f1680ca20e19745ccb7fede (patch)
tree 41473579cea4f6b39310bf8747249b68e4fa52af
parent 600f22fa3e718c36f3d8f47710df1dbbe0d0c4c2 (diff)
tdf#105143 DOCX import: enable DoNotCaptureDrawObjsOnPage layout compat option
Because that's what Word does to show only part of the shape in the
bugdoc.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=af313fc149f80adb0f1680ca20e19745ccb7fede
Comment 5 Telesto 2020-11-02 22:03:10 UTC
Adding CC: to Miklos Vajna
Comment 6 Miklos Vajna 2020-11-10 16:43:48 UTC
Is this still reproducible after 0afba07a597bf1d361624e10968855a802b859a0?
Comment 7 Attila Baraksó (NISZ) 2020-11-16 11:27:59 UTC
(In reply to Miklos Vajna from comment #6)
> Is this still reproducible after 0afba07a597bf1d361624e10968855a802b859a0?

Hey Miklos,
Yes, still reproduced in:

Version: 7.1.0.0.alpha1+ (x64)
Build ID: 631974dd958fe4ca1d1f2164266e1e2c81b325ce
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: CL
Comment 8 Telesto 2020-11-17 19:08:31 UTC
Also they case for attachment 167355 [details] (assuming this being caused by the same flaw; based on similarity; so without bibisect)
Comment 9 Commit Notification 2020-12-01 08:04:39 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e5e3fc015520990df851e5d020219cb6c9d1eb11

tdf#137638 sw textbox: make sure layout doesn't mark the doc as modified

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Xisco Faulí 2020-12-15 17:01:21 UTC
Verified in

Version: 7.2.0.0.alpha0+
Build ID: 9a2a4bc5ed340ba187c8e27db5c8477c990c93af
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

@Miklos, thanks for fixing this issue!!
Comment 11 Xisco Faulí 2020-12-15 17:03:16 UTC
(In reply to Xisco Faulí from comment #10)
> Verified in
> 
> Version: 7.2.0.0.alpha0+
> Build ID: 9a2a4bc5ed340ba187c8e27db5c8477c990c93af
> CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
> Locale: en-US (en_US.UTF-8); UI: en-US
> Calc: threaded
> 
> @Miklos, thanks for fixing this issue!!

oh, rereading the commit message, i found it was fixed by another commit. anyway, thanks for investigating it and providing the unittest