Bug 137719 - FILEOPEN: images appear blurred in edit mode (but not presentation mode) (7.0 regression)
Summary: FILEOPEN: images appear blurred in edit mode (but not presentation mode) (7.0...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
7.0.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.4.0 target:7.3.0.0.beta2 tar...
Keywords: bibisected, bisected, regression
: 138152 (view as bug list)
Depends on:
Blocks: Regressions-cairo-speedup
  Show dependency treegraph
 
Reported: 2020-10-24 14:54 UTC by Gerald Pfeifer
Modified: 2021-12-29 11:56 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
Sample document (ODP format) (3.70 MB, application/vnd.oasis.opendocument.presentation)
2020-10-24 14:54 UTC, Gerald Pfeifer
Details
Screenshot with LibreOffice 7.0 / 7.1 - note the blurred images (1.31 MB, image/png)
2020-10-24 15:06 UTC, Gerald Pfeifer
Details
Screenshot with LibreOffice 6.4 - before the regression (1.51 MB, image/png)
2020-10-24 15:06 UTC, Gerald Pfeifer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gerald Pfeifer 2020-10-24 14:54:53 UTC
Created attachment 166675 [details]
Sample document (ODP format)

Viewing slide 3 of the attached document in edit mode two or three images
appear blurred.

This is a regression between LibreOffice 6.4 and 7.0 / 7.1.

How to reproduce:

 - open document
 - use <PageDown> tfwice to move to slide 3
 - observe two or three of the images appearing blurred
 - observe how nothing appears blurred by invoking presentation mode
   with <Shift><F2>

Broken in  7.0.3.0.0+
  Build ID: 4ee6b9857d651d4bc7667227de4381286f3a9233
  CPU threads: 8; OS: Linux 5.8; UI render: default; VCL: gtk3
  Locale: en-US (en_US.UTF-8); UI: en-US
  TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:libreoffice-7-0, Time: 2020-10-13_18:31:04

Works just fine in 6.4.8.0.0+
  Build ID: 99b065ec31d032fc08ab14f66430dac4fef904a5
  CPU threads: 8; OS: Linux 5.8; UI render: default; VCL: gtk3; 
  TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:libreoffice-6-4, Time: 2020-10-08_08:57:08
Comment 1 Gerald Pfeifer 2020-10-24 15:01:38 UTC
This is *not* Bug 129244 ("FILEOPEN: Blurred EMF image") since those 
images are not EMFs, but JPEGs. 

Axel, this is a bit similar to bug 137472 you reported.
Comment 2 Gerald Pfeifer 2020-10-24 15:06:17 UTC
Created attachment 166676 [details]
Screenshot with LibreOffice 7.0 / 7.1 - note the blurred images
Comment 3 Gerald Pfeifer 2020-10-24 15:06:57 UTC
Created attachment 166677 [details]
Screenshot with LibreOffice 6.4 - before the regression
Comment 4 Telesto 2020-10-25 08:50:34 UTC
Looking fine on Windows
Version: 7.1.0.0.alpha0+ (x64)
Build ID: 94e6e140491de31c0788c91af855a75a3bb12709
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 5 Axel Braun 2020-10-25 08:57:08 UTC
(In reply to Gerald Pfeifer from comment #2)
> Created attachment 166676 [details]
> Screenshot with LibreOffice 7.0 / 7.1 - note the blurred images

yes, same here:
Version: 7.0.2.2
Build ID: 00(Build:2)
CPU threads: 12; OS: Linux 5.8; UI render: default; VCL: kf5
Locale: de-DE (de_DE.UTF-8); UI: de-DE
Calc: threaded
Comment 6 Attila Baraksó (NISZ) 2020-10-25 09:12:59 UTC
Reproduced in:

Version: 7.1.0.0.alpha0+
Build ID: f1d798151048dde3f48b124ef406416668d1e9c5
CPU threads: 6; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: threaded

One of the images appeared blurry in:

Version: 7.1.0.0.alpha0+
Build ID: f1d798151048dde3f48b124ef406416668d1e9c5
CPU threads: 6; OS: Linux 5.4; UI render: default; VCL: kf5
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: threaded

All images is fine in:

Version: 7.1.0.0.alpha0+
Build ID: f1d798151048dde3f48b124ef406416668d1e9c5
CPU threads: 6; OS: Linux 5.4; UI render: default; VCL: x11
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: threaded
Comment 7 Aron Budea 2020-10-25 09:55:42 UTC
Bibisected to the following commit using repo bibisect-linux-64-7.0. Adding CC: to Armin Le Grand.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=7c0378c0bea935c0aac2f519c53c30b2e4d8bbf9
author		Armin Le Grand <armin.le.grand@me.com>	2020-02-28 15:25:58 +0100
committer	Armin Le Grand <Armin.Le.Grand@me.com>	2020-02-29 14:43:00 +0100

tdf#130768 add a pre-scale version for cairo
Comment 8 Attila Baraksó (NISZ) 2020-11-14 13:16:53 UTC
*** Bug 138152 has been marked as a duplicate of this bug. ***
Comment 9 Commit Notification 2021-12-06 21:24:20 UTC
Luboš Luňák committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f8ffc971545bb54aaebd227fa841f83660dba99c

fix overflow in cairo downscaled bitmap cache (tdf#137719)

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2021-12-07 07:20:01 UTC
Luboš Luňák committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/a48b95e57f4f7c71664cb97942d5f7f284a94cef

fix overflow in cairo downscaled bitmap cache (tdf#137719)

It will be available in 7.3.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Gerald Pfeifer 2021-12-07 16:12:12 UTC
As the original reporter I wanted to verify the fix - thank you, Lubos!
- alas cannot reproduce the issue with all older versions I have installed
(7.0 - 7.3 builds).

This doesn't mean there was no issue (others confirmed) nor that the fix
is not real - just that *I* am not able to confirm the fix.

-> Attila or Axel?
Comment 12 Commit Notification 2021-12-07 16:25:19 UTC
Luboš Luňák committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/81f61fb61e4a1374957e5b42e46edf114fb24b37

fix overflow in cairo downscaled bitmap cache (tdf#137719)

It will be available in 7.2.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 Axel Braun 2021-12-29 11:08:58 UTC
(In reply to Gerald Pfeifer from comment #11)
> As the original reporter I wanted to verify the fix - thank you, Lubos!
> - alas cannot reproduce the issue with all older versions I have installed
> (7.0 - 7.3 builds).
> 
> This doesn't mean there was no issue (others confirmed) nor that the fix
> is not real - just that *I* am not able to confirm the fix.
> 
> -> Attila or Axel?

Sorry no, I was unable to install the daily snapshot...

But as we are on 7.2.5 in TW in between I can confirm that the fix works -> no more issues with the sample document!
Comment 14 Aron Budea 2021-12-29 11:54:42 UTC
I could verify the fix with a different sample I had at hand. The issue is gone in 7.4.0.0.alpha0+ (c13db6e792cc347ffff4585f23866f195651f21f) / Ubuntu, thanks Luboš!

And indeed, with the original sample, attachment 166675 [details], the bug isn't reproducible for me anymore even in older builds, before the fix.