Bug 137840 - GTK3 selection is different between Sidebar and Notebookbar
Summary: GTK3 selection is different between Sidebar and Notebookbar
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.1.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: gtk3-themeing
  Show dependency treegraph
 
Reported: 2020-10-28 23:37 UTC by andreas_k
Modified: 2024-03-21 03:15 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Bold and Align Center are selected (180.38 KB, image/png)
2020-10-28 23:37 UTC, andreas_k
Details

Note You need to log in before you can comment on or make changes to this bug.
Description andreas_k 2020-10-28 23:37:40 UTC
Created attachment 166823 [details]
Bold and Align Center are selected

As you can see in the screenshot the selected icon is different between sidebar and notebookbar at GTK3 backend. On QT5 they look the same.

I prefer the sidebar layout (better contrast)
Comment 1 Caolán McNamara 2020-10-29 09:25:28 UTC
The sidebar is true gtk, the notebookbar is not, this would be resolved if/when the notebookbar is also "welded". This is somewhat tricky because the notebookbar has grown a large collection of unique special widgets which don't have obvious gtk counterparts. (The other option is improving the pseudo-gtk theming, but I have no enthusiasm for persisting with that approach).
Comment 2 andreas_k 2020-10-29 09:27:40 UTC
Thanks for the feedback.

Where is the pseudo-gtk theming located?
Comment 3 Caolán McNamara 2020-10-29 09:31:24 UTC
vcl/unx/gtk3/gtk3salnativewidgets-gtk.cxx
Comment 4 Buovjaga 2021-07-27 11:54:44 UTC
I see there was a wip patch for preparing notebookbar for welding https://gerrit.libreoffice.org/c/core/+/105265
I also saw some patches from Szymon Kłos about welding notebookbar
Comment 5 QA Administrators 2024-03-21 03:15:04 UTC
Dear andreas_k,

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
 
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug