Bug 137885 - FILEOPEN: DOCX: frames with tables move to another position after opening the file
Summary: FILEOPEN: DOCX: frames with tables move to another position after opening the...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.1.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: DOCX-Textbox
  Show dependency treegraph
 
Reported: 2020-10-30 17:58 UTC by Xisco Faulí
Modified: 2020-12-09 18:51 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
sample file (32.91 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2020-10-30 17:58 UTC, Xisco Faulí
Details
The bugdoc in the bibisect version and in the nightly (324.42 KB, image/png)
2020-11-02 14:06 UTC, NISZ LibreOffice Team
Details
The original document in Word and in LO 7.2alpha (174.97 KB, image/png)
2020-12-08 12:13 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2020-10-30 17:58:29 UTC
Created attachment 166880 [details]
sample file

Steps to reproduce:
1. Open attached document

-> The tables on page 2 move to page 1

Reproduced in

Version: 7.1.0.0.alpha1+
Build ID: fdb6d6ccf45e679ff3e369a876482b6801e08e25
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

[Bug found by office-interoperability-tools]
Comment 1 Xisco Faulí 2020-10-30 17:59:38 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=c9eb53f200225f2ee6ca695e1326843a487aee51

author	Daniel Arato (NISZ) <arato.daniel@nisz.hu>	2020-10-14 15:46:23 +0200
committer	László Németh <nemeth@numbertext.org>	2020-10-27 13:27:55 +0100
commit c9eb53f200225f2ee6ca695e1326843a487aee51 (patch)
tree a9bcf31a6e32b81a4fd42cb7a65936a075928213
parent ebea072fa7d7081ba9d1e549f5aa629c749d8c0e (diff)
tdf#135198 sw editing: text box fell out of its shape

Bisected with: bibisect-linux64-7.1

Adding Cc: to Daniel Arato
Comment 2 Dániel Arató (NISZ) 2020-11-02 08:24:28 UTC
I have an old master checkout (a16f2d2bc1865dfbf8e755e683624843337c59da) and the bisected commit Xisco Faulí mentioned on top of it. I don't seem to be able to reproduce the bug on my system.
Comment 3 NISZ LibreOffice Team 2020-11-02 14:05:21 UTC
I see this problem with nightly version:

Version: 7.1.0.0.alpha1+ (x64)
Build ID: ec1f4d3253963ac16d638734ac70dde033e82154
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL
https://git.libreoffice.org/core/+log/ec1f4d3253963ac16d638734ac70dde033e82154

But not in slightly older bibisect-win64-7.1:

Version: 7.1.0.0.alpha1+ (x64)
Build ID: a4d4ed86991e2901ac86189e95966d4e99be4944
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL

https://git.libreoffice.org/core/+log/a4d4ed86991e2901ac86189e95966d4e99be4944

This already contains the bibisected fix.
I don't think the bibisect found the correct commit.
Comment 4 NISZ LibreOffice Team 2020-11-02 14:06:51 UTC
Created attachment 166938 [details]
The bugdoc in the bibisect version and in the nightly
Comment 5 NISZ LibreOffice Team 2020-12-08 12:13:15 UTC
Created attachment 167937 [details]
The original document in Word and in LO 7.2alpha

This first page seems to be better now in:

Version: 7.2.0.0.alpha0+ (x64)
Build ID: 796c7f612603490dda9277ced0f6ab3cce3bc116
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
Locale: en-US (hu_HU); UI: en-US
Calc: CL

Two problems still:
- the very first empty paragraph does not have the same font name & size as in Word. This is a 7.1 regression, it was good in 7.0
- the top left Wordart (or its placeholder image) has incorrect height, 1.66 cm instead of 2.59

Manually correcting these pushes the second pages start and layout in the correct place. So it may worth filing new bugs for these.
Comment 6 NISZ LibreOffice Team 2020-12-09 18:51:54 UTC
This seems to have been fixed with:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=59fec754a1523eede0f19a59e4eeeff593a4d688

author	Daniel Arato (NISZ) <arato.daniel@nisz.hu>	2020-11-16 11:53:47 +0100
committer	László Németh <nemeth@numbertext.org>	2020-11-26 14:41:53 +0100

tdf#135198 tdf#138050 sw editing: fix text box position sync

Other two problems from comment #5 are filed. Fun fact: this file looked quite good in 5.4, only an extra empty paragraph went to the extra third page. 
That still happens after manually fixing up things.