Bug 138162 - FILEOPEN: DOCX: texbox inside shape has incorrect position
Summary: FILEOPEN: DOCX: texbox inside shape has incorrect position
Status: RESOLVED DUPLICATE of bug 135198
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.4 all versions
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: DOCX-Textbox
  Show dependency treegraph
 
Reported: 2020-11-12 13:03 UTC by Xisco Faulí
Modified: 2020-11-13 18:38 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
The example file in nightly and bb71 versions (232.04 KB, image/png)
2020-11-13 08:24 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2020-11-12 13:03:39 UTC
Steps to reproduce:
1. Open attachment 167237 [details] from bug 137822

-> The textboxes inside the blue shape have incorrect position. if the shape changes its positioned, then the textbox's position gets updated and it moves inside the shape. See comparison image -> attachment 167238 [details]

Reproduced in

Version: 7.1.0.0.alpha1+
Build ID: 03cafc2ab6b1678f82e9a30b6f81e505660ee702
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 1 Xisco Faulí 2020-11-12 13:05:45 UTC
The textboxes are outside the shapes since

https://cgit.freedesktop.org/libreoffice/core/commit/?id=c00d81612e128b74c23c95e011b482dc3918fca4

author	Miklos Vajna <vmiklos@collabora.co.uk>	2014-06-27 13:47:11 +0200
committer	Miklos Vajna <vmiklos@collabora.co.uk>	2014-06-27 15:56:05 +0200
commit c00d81612e128b74c23c95e011b482dc3918fca4 (patch)
tree d41b6e7f31820532337822956000df2eb5c638f2
parent 4f33a0961d69feba72806d105da65a4dc841ca5e (diff)
SwFlyFrm::Format: inform our custom shape about size changes if needed

before this commit ( or if it's reverted ), the shapes have an incorrect height.

Bisected with: bibisect-44max

Adding Cc: to Miklos Vajna
Comment 2 NISZ LibreOffice Team 2020-11-13 08:24:33 UTC
Created attachment 167249 [details]
The example file in nightly and bb71 versions

This is strange, yesterdays nightly shows the blue X out of shape: 

Version: 7.1.0.0.alpha1+ (x64)
Build ID: 693553210828538680408832157faad9654758c8
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL

but in bibisect-7.1 from about two weeks ago its okay:

Version: 7.1.0.0.alpha1+ (x64)
Build ID: a4d4ed86991e2901ac86189e95966d4e99be4944
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL
Comment 3 Miklos Vajna 2020-11-13 08:28:11 UTC
Might make sense to re-test this once bug 137980 is fixed, which sounds similar. Possibly the root cause will be the same, you can never know.
Comment 4 Xisco Faulí 2020-11-13 13:06:04 UTC
(In reply to NISZ LibreOffice Team from comment #2)
> Created attachment 167249 [details]
> The example file in nightly and bb71 versions
> 
> This is strange, yesterdays nightly shows the blue X out of shape: 
> 
> Version: 7.1.0.0.alpha1+ (x64)
> Build ID: 693553210828538680408832157faad9654758c8
> CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
> Locale: hu-HU (hu_HU); UI: en-US
> Calc: CL
> 
> but in bibisect-7.1 from about two weeks ago its okay:
> 
> Version: 7.1.0.0.alpha1+ (x64)
> Build ID: a4d4ed86991e2901ac86189e95966d4e99be4944
> CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
> Locale: hu-HU (hu_HU); UI: en-US
> Calc: CL

Indeed, this was fixed and reintroduced by

author	Daniel Arato (NISZ) <arato.daniel@nisz.hu>	2020-11-03 11:22:40 +0100
committer	László Németh <nemeth@numbertext.org>	2020-11-09 19:05:20 +0100
commit f2eef84ff03660cbb46a76c317e640e054ed0a56 (patch)
tree f92ef8082e5b2cf545f9f675d545b437c0a52e75
parent 36d14442b25bd3d700d95879e5775cce6ed0836d (diff)
tdf#137881 sw: fix text box size regression
Comment 5 Xisco Faulí 2020-11-13 13:11:00 UTC
This issue got fixed by https://git.libreoffice.org/core/commit/c9eb53f200225f2ee6ca695e1326843a487aee51
Comment 6 Xisco Faulí 2020-11-13 18:38:20 UTC
This can be closed as dupe of bug 135198

*** This bug has been marked as a duplicate of bug 135198 ***