Bug 138327 (redlinehide-regressions) - [META] sw_redlinehide regressions (track changes)
Summary: [META] sw_redlinehide regressions (track changes)
Status: NEW
Alias: redlinehide-regressions
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.3 all versions
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on: 132738 133655 134759 135061 135130 135168 135257 135978 136206 136409 136451 136452 136930 137318 138618 138743 139687 141175 141837 100691 118219 118414 120991 121031 122452 122722 123285 123446 123855 124720 124722 125039 125261 125319 125624 125660 125754 126340 126627 127635 127652 128138 128188 129529 129553 130274 130680 130685 131684 132160 132187 132236 132326 132911 132944 133358 133981 133990 134021 134250 134252 134436 134752 134770 134839 134931 134965 135001 135009 135018 135056 135260 135963 136453 136704 136833 137241 137567 138354
Blocks: Track-Changes
  Show dependency treegraph
 
Reported: 2020-11-19 11:04 UTC by Xisco Faulí
Modified: 2021-07-16 20:42 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2020-11-19 11:04:32 UTC
Regressions from work done by Michael Stahl on Redlines -> https://cgit.freedesktop.org/libreoffice/core/log/?qt=grep&q=sw_redlinehide
Comment 1 Aron Budea 2021-03-22 02:32:29 UTC
The feature moved out of experimental mode with the following two commits in 6.3 / 6.2:
"sw_redlinehide: make layout based Show/Hide mode the default"

6.3:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=32902f66e7749b2d06d13f50416be5323a0c0ea9

bibisect-linux-64-6.3:
commit 63dec39f2e1dab30a4c3ea8bdcea290600cf6983
Author: Jenkins Build User <tdf@pollux.tdf>
Date:   Tue Dec 18 22:07:56 2018 +0100

    source sha:32902f66e7749b2d06d13f50416be5323a0c0ea9

6.2:
https://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-6-2&id=94c1af65367dcbc7272455cf6d4940252a289b62

bibisect-linux-64-6.2:
commit ae82aa93d4536e9529688f412def4a23908f1d40
Author: Jenkins Build User <tdf@pollux.tdf>
Date:   Wed Dec 19 08:07:30 2018 +0100

    source sha:94c1af65367dcbc7272455cf6d4940252a289b62


Even before experimental mode, earlier in 6.2 it was available by setting an environment variable.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=ae3150b1e1863e854224c2e41c7e50991f945dad
"sw_redlinehide_2: replace SW_REDLINEHIDE with ExperimentalMode config"

bibisect-linux-64-6.2:
commit 4bbbfbcef6c5450afe0ce58b1cd5da3da04133ed
Author: Jenkins Build User <tdf@pollux.tdf>
Date:   Wed Sep 19 22:08:58 2018 +0200

    source sha:ae3150b1e1863e854224c2e41c7e50991f945dad

Talks:
https://archive.fosdem.org/2019/schedule/event/are_we_optimiert_yet/
https://conference.libreoffice.org/assets/Conference/Tirana/AreOptimiertMStahl.pdf