Bug 138388 - Calc functions ODDFPRICE and ODDFYIELD do not appear to work correctly
Summary: Calc functions ODDFPRICE and ODDFYIELD do not appear to work correctly
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Calc-Function
  Show dependency treegraph
 
Reported: 2020-11-21 08:49 UTC by Steve Fanning
Modified: 2023-02-11 03:24 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Fanning 2020-11-21 08:49:33 UTC
Description:
Unable to find any combination of arguments that give a meaningful result for either function. Constantly return #VALUE!

Code inspection of GetOddfprice and GetOddfyield functions in file source/analysis/analysishelper.cxx seems to indicate that both unconditionally throw a runtime exception.

AOO Bugzilla #92177 also refers.

Steps to Reproduce:
See Description

Actual Results:
See Description

Expected Results:
See Description


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.0.2.2 (x64)
Build ID: 8349ace3c3162073abd90d81fd06dcfb6b36b994
CPU threads: 6; OS: Windows 10.0 Build 19041; UI render: Skia/Vulkan; VCL: win
Locale: en-GB (en_GB); UI: en-US
Calc: threaded
Comment 1 Julien Nabet 2020-11-21 09:29:01 UTC
Seems like that since:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=2f0d97cd957cdb3113d98cbc441a923a43367547
author	Daniel Rentz <dr@openoffice.org>	2001-09-26 12:22:24 +0000
committer	Daniel Rentz <dr@openoffice.org>	2001-09-26 12:22:24 +0000
commit 2f0d97cd957cdb3113d98cbc441a923a43367547 (patch)
tree d13dfd89a8e98f081692a92c7fb56bb33dfc0ae2
parent f5b732c43a9ed9ace11412d85dacd96d849fcde1 (diff)
#87380# return error for ODDF(PRICE|YIELD) due to faulty algorithms

Eike: should we remove these functions or should we still wait for someone try to implement them?
(I found these links from MS:
https://support.microsoft.com/en-us/office/oddfprice-function-d7d664a8-34df-4233-8d2b-922bcf6a69e1
http://www.mit.edu/~mbarker/formula1/f1help/05-n-s18.htm
)
Comment 2 Eike Rathke 2020-11-23 18:37:13 UTC
Removing the functions wouldn't help anything except changing the error from #VALUE! to #NAME? ...

Keeping them has the benefit that when a document is saved as old .xls binary format then the macro class is preserved due to the implementation as Add-In and it would (continue to) work in Excel.
Comment 3 Julien Nabet 2020-11-23 18:44:05 UTC
(In reply to Eike Rathke from comment #2)
> Removing the functions wouldn't help anything except changing the error from
> #VALUE! to #NAME? ...
Just decruftify a bit the code
> 
> Keeping them has the benefit that when a document is saved as old .xls
> binary format then the macro class is preserved due to the implementation as
> Add-In and it would (continue to) work in Excel.
Didn't know about this part.
Ok I understand better now why this thing is still there unimplemented after so many years.
Thank you for the feedback! :-)
Comment 4 Olivier Hallot 2021-02-10 09:39:30 UTC
Both functions are in ODFF standard.

https://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part2.html#__RefHeading__1018292_715980110
Comment 5 QA Administrators 2023-02-11 03:24:00 UTC
Dear Steve Fanning,

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
 
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug