Bug 138578 - View > Freeze Cells menu is empty after upgrade
Summary: View > Freeze Cells menu is empty after upgrade
Status: RESOLVED DUPLICATE of bug 57466
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.1.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
: 142195 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-11-30 19:04 UTC by sdc.blanco
Modified: 2022-11-01 01:33 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments
Attached screnshoot (42.18 KB, image/png)
2020-12-04 14:24 UTC, m_a_riosv
Details
Screenshot (daily build, 12-04, Win) (59.32 KB, image/png)
2020-12-04 16:06 UTC, Aron Budea
Details
Attached screnshoot (50.47 KB, image/png)
2020-12-04 16:28 UTC, m_a_riosv
Details
registrymodifications.xcu having the issue with no visible entries. (1.93 MB, application/xml)
2020-12-04 16:58 UTC, m_a_riosv
Details
two views of freeze cells (96.03 KB, application/vnd.oasis.opendocument.graphics)
2020-12-04 17:10 UTC, sdc.blanco
Details

Note You need to log in before you can comment on or make changes to this bug.
Description sdc.blanco 2020-11-30 19:04:56 UTC
In Calc, View > Freeze Cells > (submenu)

Shows only grey fields -- no commandnames

Version: 7.2.0.0.alpha0+ (x64)
Build ID: a45ea4f7939e7ca2e5c071ad209c957702b527e6
CPU threads: 8; OS: Windows 10.0 Build 19041; UI render: Skia/Vulkan; VCL: win
Locale: fr-CH (en_DK); UI: en-US
Calc: threaded
Comment 1 m_a_riosv 2020-11-30 22:38:06 UTC
Repro
Version: 7.2.0.0.alpha0+ (x64)
Build ID: f7e2f5bca938aa916830e07895d2da6820282055
CPU threads: 4; OS: Windows 10.0 Build 20180; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL
Comment 2 m_a_riosv 2020-11-30 22:42:05 UTC
Repro also
Version: 7.1.0.0.beta1 (x64)
Build ID: 828a45a14a0b954e0e539f5a9a10ca31c81d8f53
CPU threads: 4; OS: Windows 10.0 Build 20180; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL

But not with:
Version: 7.0.4.0.0+ (x64)
Build ID: e5b019d12043712c2d2a5ac424102e9861d21ad2
CPU threads: 4; OS: Windows 10.0 Build 20180; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL
Comment 3 Julien Nabet 2020-12-02 20:23:55 UTC
On pc Debian x86-64 with master sources updated yesterday, I don't reproduce this with gtk3 or gen rendering but noticed these logs:
warn:vcl:7656:7656:vcl/source/image/ImplImage.cxx:82: Failed to load scaled image from cmd/sc_formattingmarkmenu.png at 1
warn:vcl:7656:7656:vcl/source/image/ImplImage.cxx:105: Failed to load stock icon cmd/sc_formattingmarkmenu.png
warn:vcl:7656:7656:vcl/source/image/ImplImage.cxx:82: Failed to load scaled image from cmd/sc_toolbarmodeui.png at 1
warn:vcl:7656:7656:vcl/source/image/ImplImage.cxx:105: Failed to load stock icon cmd/sc_toolbarmodeui.png
warn:vcl:7656:7656:vcl/source/image/ImplImage.cxx:82: Failed to load scaled image from cmd/sc_freezepanescolumn.png at 1
warn:vcl:7656:7656:vcl/source/image/ImplImage.cxx:105: Failed to load stock icon cmd/sc_freezepanescolumn.png
warn:vcl:7656:7656:vcl/source/image/ImplImage.cxx:82: Failed to load scaled image from cmd/sc_freezepanesrow.png at 1
warn:vcl:7656:7656:vcl/source/image/ImplImage.cxx:105: Failed to load stock icon cmd/sc_freezepanesrow.png
warn:vcl:7656:7656:vcl/source/image/ImplImage.cxx:82: Failed to load scaled image from cmd/sc_tipoftheday.png at 1
warn:vcl:7656:7656:vcl/source/image/ImplImage.cxx:105: Failed to load stock icon cmd/sc_tipoftheday.png

Andreas: thought you might be interested in this one.
Comment 4 andreas_k 2020-12-02 20:28:28 UTC
which icon theme?
Comment 5 Julien Nabet 2020-12-02 20:30:57 UTC
(In reply to andreas_k from comment #4)
> which icon theme?

Sorry, I can't tell for the moment, just launched a "make clean && make".
Comment 6 Aron Budea 2020-12-04 12:37:02 UTC
Bibisected to the following commit using repo bibisect-linux-64-7.1. Adding CC: to Dennis Francis.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=7b4802070ac6fb930255536bf3ed2c52428b4181
author		Dennis Francis <dennis.francis@collabora.com>	2020-07-15 15:55:45 +0530
committer	Dennis Francis <dennis.francis@collabora.com>	2020-07-24 15:19:40 +0200

lok-freezepanes: Generalize FreezePanes* uno-commands...
Comment 7 Aron Budea 2020-12-04 12:43:24 UTC
For the record, I used 'gen' VCL plugin, and what I saw is the lack of icons.

I'm not sure what "Shows only grey fields -- no commandnames" and "View > Freeze Cells menu is empty" is supposed to mean. If it's a different issue, feel free to mark my previous comment obsolete.
Comment 8 m_a_riosv 2020-12-04 14:24:17 UTC
Created attachment 167832 [details]
Attached screnshoot
Comment 9 Aron Budea 2020-12-04 16:06:45 UTC
Created attachment 167833 [details]
Screenshot (daily build, 12-04, Win)

This is what I see.
Comment 10 m_a_riosv 2020-12-04 16:28:48 UTC
Created attachment 167835 [details]
Attached screnshoot

Version: 7.2.0.0.alpha0+ (x64)
Build ID: 761a672d62df1891b9f4f367a499b220ab2b33fa
CPU threads: 4; OS: Windows 10.0 Build 20180; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL

With a clean profile the issue change, but the option for rows/columns is missing, so not exactly the same bug, but a bug with that submenu.

Difference it's Skia/Raster or Skia/Vulkan
Version: 7.2.0.0.alpha0+ (x64)
Build ID: 761a672d62df1891b9f4f367a499b220ab2b33fa
CPU threads: 4; OS: Windows 10.0 Build 20180; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: es-ES Calc: CL
Comment 11 m_a_riosv 2020-12-04 16:58:50 UTC
Created attachment 167837 [details]
registrymodifications.xcu having the issue with no visible entries.
Comment 12 sdc.blanco 2020-12-04 17:10:54 UTC
Created attachment 167838 [details]
two views of freeze cells

(In reply to Aron Budea from comment #7)
> I'm not sure what "Shows only grey fields -- no commandnames" and "View >
> Freeze Cells menu is empty" is supposed to mean. If it's a different issue,
> feel free to mark my previous comment obsolete.
See attached.

(In reply to m.a.riosv from comment #11)
> registrymodifications.xcu having the issue with no visible entries.
I think you are right.  I restarted in safe mode -- and the problem disappeared. So maybe my report is "invalid" (profile problem).  (but it is curious that you also had that problem -- also with windows -- though in my case w/o Skia)

About "missing icons" -- that is a UI design decision -- so nothing is missing there.
Comment 13 Julien Nabet 2020-12-04 17:22:41 UTC
Sorry Andreas, I think the logs I get (only with gen rendering whatever the icon theme) is unrelated to the bugtracker. I'll stop here to hijack it :-)
Comment 14 sdc.blanco 2020-12-10 12:03:59 UTC
(In reply to sdc.blanco from comment #12)
> About "missing icons" -- 
A. Correction needed about icons.

1. "Freeze First Column" and "Freeze First Row" do not appear to have any icons.  (Judged by looking in Tools>Customize>Menus tab, search with "Freeze")

2. Icons should/would be shown (if they existed) -- according to source code:
https://opengrok.libreoffice.org/xref/core/sc/uiconfig/scalc/menubar/menubar.xml?r=7109b69f#169

B. New information about "grey menu".

1. Tools>Customize>Menus tab - Target: View|Freeze Cells
2. In my case, this menu had two empty entries. 
3. Added back "Freeze First Column" and "Freeze First Row"
4. Everything looks "right" again. (the two empty entries made the "grey" appearance)


In sum: 

If everyone (using the various backends that you use) is able to see the submenu for "Freeze Cells" with two items in the submenu, like this:

Freeze Cells
   Freeze First Column
   Freeze First Row

then maybe there is no problem.

OTOH -- if this was just a "profile" problem on my end  (because the submenu was displayed properly in safe mode), then how did comment 1 and comment 2 repro this?

Will leave the decision to others about whether to close this report as INVALID or to make a better analysis.
Comment 15 m_a_riosv 2021-05-10 15:47:04 UTC
Still
Version: 7.1.3.2 (x64) / LibreOffice Community
Build ID: 47f78053abe362b9384784d31a6e56f8511eb1c1
CPU threads: 4; OS: Windows 10.0 Build 21370; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL
Comment 16 m_a_riosv 2021-05-10 15:48:35 UTC
*** Bug 142195 has been marked as a duplicate of this bug. ***
Comment 17 Roman Kuznetsov 2022-10-31 18:31:16 UTC
No repro in

Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 02db1642c9ce4394f4f85755c4a0a831e547e4fb
CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: threaded
Comment 18 Aron Budea 2022-10-31 19:00:37 UTC
(In reply to Aron Budea from comment #7)
> For the record, I used 'gen' VCL plugin, and what I saw is the lack of icons.
I'm still not seeing the icons in a recent 7.5 build.
Comment 19 Roman Kuznetsov 2022-10-31 20:29:37 UTC
(In reply to Aron Budea from comment #18)
> (In reply to Aron Budea from comment #7)
> > For the record, I used 'gen' VCL plugin, and what I saw is the lack of icons.
> I'm still not seeing the icons in a recent 7.5 build.

The description was about empty items in submenu, look at the screenshot.
If we talk about icons for menu items, then let's change Summary , but I saw Heiko's opinion like "we don't need icon for every menu item, we need it only for important things"
Comment 20 Aron Budea 2022-11-01 01:32:49 UTC
(In reply to Roman Kuznetsov from comment #19)
> The description was about empty items in submenu, look at the screenshot.
That's bug 57466.

> If we talk about icons for menu items, then let's change Summary , but I saw
> Heiko's opinion like "we don't need icon for every menu item, we need it
> only for important things"
On second thought, let's just close this cleanly as duplicate. If someone would like to open a bug report on the icons, they're welcome to.

*** This bug has been marked as a duplicate of bug 57466 ***