Bug 138743 - Hiding track changes shows a spurious image frame
Summary: Hiding track changes shows a spurious image frame
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.2.0.3 release
Hardware: All All
: medium normal
Assignee: Michael Stahl (allotropia)
URL:
Whiteboard: target:7.4.0 target:7.3.0.2 target:7.2.5
Keywords: bibisected, regression
: 141837 (view as bug list)
Depends on:
Blocks: redlinehide-regressions
  Show dependency treegraph
 
Reported: 2020-12-08 16:34 UTC by Telesto
Modified: 2022-08-10 19:24 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-12-08 16:34:29 UTC
Description:
Hiding track changes shows a spurious image frame

Steps to Reproduce:
1. Open attachment 165730 [details]
2. Edit -> Track Changes -> Disable show

Actual Results:
Empty frame on page 2

Expected Results:
No frame at all (as in 6.1)


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.2.0.0.alpha0+ (x64)
Build ID: 796c7f612603490dda9277ced0f6ab3cce3bc116
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

and in
6.2

not in
6.1
Comment 1 Xisco Faulí 2020-12-09 20:37:56 UTC
The document started to crash scrolling to page 2 after  https://cgit.freedesktop.org/libreoffice/core/commit/?id=c0f51bdf3896473962702c01968a133c927aed4a. Later the crash was fixed in https://cgit.freedesktop.org/libreoffice/core/commit/?id=f609eba8b979620dc8f1c4a47d710360f8aae9e6.
Since then, this issue is reproducible

Adding Cc: to Michael Stahl
Comment 2 Telesto 2020-12-09 20:50:43 UTC
(In reply to Xisco Faulí from comment #1)
> The document started to crash scrolling to page 2 after 
> https://cgit.freedesktop.org/libreoffice/core/commit/

The font issue might be still present: 
https://bugs.documentfoundation.org/show_bug.cgi?id=136929#c9
Comment 3 Commit Notification 2021-12-23 19:54:00 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2954039767e1adab7a65838b61a449b701f244a4

tdf#138743 sw_redlinehide: delete FlyFrames when hiding tracked changes

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Michael Stahl (allotropia) 2021-12-23 19:55:10 UTC
fixed on master
Comment 5 Commit Notification 2021-12-24 00:45:26 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/15bb6eede17160a84674ce4911bd0fdcee3c7747

tdf#138743 sw_redlinehide: delete FlyFrames when hiding tracked changes

It will be available in 7.3.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2021-12-24 00:46:41 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/cc33e4d46cb43ba9285ea3deaacbd4ee6374dd0f

tdf#138743 sw_redlinehide: delete FlyFrames when hiding tracked changes

It will be available in 7.2.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2021-12-28 20:07:15 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-7-2-5":

https://git.libreoffice.org/core/commit/330324e943b1b228d90b637d2f273d441b0773f9

tdf#138743 sw_redlinehide: delete FlyFrames when hiding tracked changes

It will be available in 7.2.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Gabor Kelemen (allotropia) 2022-02-09 23:18:10 UTC
*** Bug 141837 has been marked as a duplicate of this bug. ***
Comment 9 Gabor Kelemen (allotropia) 2022-08-10 19:24:46 UTC
Verified in

Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 4e2ce2a460458f17ee4360c45a2da2fc4b4d753e
CPU threads: 14; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: en-US (hu_HU); UI: en-US
Calc: threaded

No empty frame is visible after hiding tracked changes.