Bug 138801 - FILEOPEN DOCX Image in table disappears after opening
Summary: FILEOPEN DOCX Image in table disappears after opening
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.1.0.3 release
Hardware: All All
: medium normal
Assignee: Miklos Vajna
URL:
Whiteboard: target:7.2.0 target:7.1.0.2 target:7.0.5
Keywords: bibisected, bisected, filter:docx, regression
Depends on:
Blocks: DOCX-Images
  Show dependency treegraph
 
Reported: 2020-12-10 14:05 UTC by NISZ LibreOffice Team
Modified: 2021-01-25 14:21 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file from Word (131.21 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2020-12-10 14:05 UTC, NISZ LibreOffice Team
Details
Screenshot of the original document side by side in Word and Writer (176.73 KB, image/png)
2020-12-10 14:05 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description NISZ LibreOffice Team 2020-12-10 14:05:06 UTC
Created attachment 168036 [details]
Example file from Word

Attached document contains a resized image anchored inside a table.
When opening in Writer the image is visible for a split second during opening, then disappears and only an empty rectangle is visible, with a tiny bit of the original image rendered in the top left corner.

Steps to reproduce:
    1. Open attached document

Actual results:
Image not visible.

Expected results:
Image should be entirely visible.

LibreOffice details:
Version: 7.2.0.0.alpha0+ (x64)
Build ID: 796c7f612603490dda9277ced0f6ab3cce3bc116
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
Locale: en-US (hu_HU); UI: en-US
Calc: CL

Also in:
Version: 6.1.0.3
Build ID: efb621ed25068d70781dc026f7e9c5187a4decd1
CPU threads: 4; OS: Windows 6.3; UI render: default; 
Locale: en-US (hu_HU); Calc: CL

Not yet in:
Version: 6.0.0.3
Build ID: 64a0f66915f38c6217de274f0aa8e15618924765
CPU threads: 4; OS: Windows 6.3; UI render: default; 
Locale: en-US (hu_HU); Calc: CL

Additional Information: 

Bibisected using bibisect-win32-6.1 to:
URL: https://cgit.freedesktop.org/libreoffice/core/commit/?id=edda1e5fc8113aa4744e32f97c96a3cc311485ca
author	Miklos Vajna <vmiklos@collabora.co.uk>	2018-04-20 16:32:00 +0200
committer	Miklos Vajna <vmiklos@collabora.co.uk>	2018-04-20 21:04:35 +0200

DOCX import: lazy-read images without external headers

Adding CC to: Miklos Vajna
Comment 1 NISZ LibreOffice Team 2020-12-10 14:05:26 UTC
Created attachment 168037 [details]
Screenshot of the original document side by side in Word and Writer
Comment 2 Xisco Faulí 2020-12-10 14:23:16 UTC
Reproduced in

Version: 7.2.0.0.alpha0+
Build ID: 84af20ef3ea72190784e9e7be820684c2558ba8c
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

Adding Cc: to Miklos Vajna
Comment 3 Commit Notification 2020-12-22 08:08:41 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c24d9447b809416575972585a5ad48e14f8d9ad9

tdf#138801 vcl: fix lazy-loading of GIF images with logic size

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Xisco Faulí 2021-01-04 11:27:16 UTC
Verified in

Version: 7.2.0.0.alpha0+
Build ID: 2c9708cbb870483a8a1c93d722085be5f789d234
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

@Miklos, thanks for fixing this issue!!
Comment 5 Commit Notification 2021-01-04 11:28:51 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/0417f8c2b89903d9d2c1d21593cf9ec2ea8a226e

tdf#138801 vcl: fix lazy-loading of GIF images with logic size

It will be available in 7.1.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2021-01-04 18:26:19 UTC
Miklos Vajna committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/bc8fa345ff2a20d9f39c22afa67cf158e6368efd

tdf#138801 vcl: fix lazy-loading of GIF images with logic size

It will be available in 7.0.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 NISZ LibreOffice Team 2021-01-25 14:21:35 UTC
Verified in: 
Version: 7.2.0.0.alpha0+ (x64)
Build ID: 96bafa464ebdbce3ef04bec9beae5e745bb37794
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: en-GB
Calc: threaded

Thanks for fixing!