Bug 138812 - Introduce "reset crop" command
Summary: Introduce "reset crop" command
Status: RESOLVED DUPLICATE of bug 86628
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-11 08:39 UTC by Telesto
Modified: 2023-04-21 17:19 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file (249.49 KB, application/vnd.oasis.opendocument.text)
2020-12-11 08:40 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-12-11 08:39:50 UTC
Description:
UI: Reset crop button

Steps to Reproduce:
1. Open the attached file
2. Context menu -> Crop & crop it
3. Now how to reset crop?

Format -> Image -> Properties -> Crop & setting crop borders to 0 is the existing option

Actual Results:
Manually reset crop size to 0

Expected Results:
1) Button in Format -> Image -> Properties -> Crop tab for resetting crop
2) Tendency to 'reset crop menu item'. In Format -> Image. And maybe even the context menu (but limited number of entry issue).. Maybe dynamic, for image which have crop?


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.2.0.0.alpha0+ (x64)
Build ID: 796c7f612603490dda9277ced0f6ab3cce3bc116
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2020-12-11 08:40:10 UTC
Created attachment 168043 [details]
Example file
Comment 2 S.Zosgornik 2020-12-11 11:13:04 UTC
I would agree that a reset-button inside the crop tap would be convenient.
But an extra menu-entry under Format > Image and the image context menu would just clutter the UI.
Comment 3 Telesto 2020-12-11 12:35:22 UTC
(In reply to Sascha Z from comment #2)
> I would agree that a reset-button inside the crop tap would be convenient.
> But an extra menu-entry under Format > Image and the image context menu
> would just clutter the UI.

I personally find easier to have it right click context menu (because it's by far more comfortable to use.. Obviously only in cases where crop being actually applied. It's worth the clutter 

The alternative compromise would be to make it accessible from modify.. however not sure if there is a possibility for context depend menu items
Comment 4 Heiko Tietze 2020-12-14 13:20:40 UTC
Let's realize the uncrop function, add a button to the dialog and a UNO command for customization. I tend to agree with Telesto that uncrop inn the context menu is desirable - but please only if crop has been applied.

The dialog is cui/uiconfig/ui/croppage.ui, for code inspiration search for SID_ATTR_GRAF_CROP
Comment 5 Telesto 2020-12-14 21:47:49 UTC
(In reply to Heiko Tietze from comment #4)
> Let's realize the uncrop function, add a button to the dialog and a UNO
> command for customization. I tend to agree with Telesto that uncrop inn the
> context menu is desirable - but please only if crop has been applied.
> 
> The dialog is cui/uiconfig/ui/croppage.ui, for code inspiration search for
> SID_ATTR_GRAF_CROP

Small note: the desire for 'reset crop' mostly vanishes at the point writer is getting the draw/impress crop. Where you actually can see the full image (in the case if it's cropped already) The writer implementation kind of bad in that perspective..

So the necessity for "reset crop" kind of vanishes with the 'impress/draw' crop which will come to writer eventually. So this is more an ad interim suggestion in the first place.

If it's still needed after the move is made.. open for debate IMHO.
Comment 6 Telesto 2020-12-14 21:58:01 UTC
In a way off-topic
Nuance to my previous comment. Somehow it's possible to increase the image with crop in Impress/Draw.. So crop handles can go outside the actual dimensions of the image..

In this stage it would even make sense in Draw/Impress to have reset crop (which kind of awful work around) but not sure if this way on purpose..

@Heiko
Any knowledge
Comment 7 Deb 2020-12-22 06:11:02 UTC
I will try to add a context menu command.
Comment 8 Deb 2020-12-28 07:10:40 UTC
I'm not sure what to do about zoom mode aka Keep image size radio button. If user has cropped in this mode, the scale has changed. Should I reset the scale? If so, does the program still know what the original scale was?

Is there anywhere else that can edit the scale? Is it going to be surprising that the reset crop button also resets the scale?
Comment 9 Buovjaga 2021-02-03 06:41:34 UTC Comment hidden (off-topic)
Comment 10 ahmethcelik 2021-03-12 12:26:23 UTC
I would like to work on this.
Comment 11 Hossein 2022-09-20 13:27:03 UTC
Re-evaluating the EasyHack in 2022

This enhancement is still relevant. As per comment 2 and comment 3, I think it would be good to have "Reset Crop" both in the dialog and right click context menu.
Comment 12 Stéphane Guillou (stragu) 2023-04-21 17:19:56 UTC
Already requested in bug 86628.
Moved keywords over there.

*** This bug has been marked as a duplicate of bug 86628 ***