Bug 138835 - Image in table anchored to paragraph/character deleted when deleting the last character below (but not in older versions)
Summary: Image in table anchored to paragraph/character deleted when deleting the last...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.2.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Michael Stahl (allotropia)
URL:
Whiteboard: target:7.4.0 target:7.3.5
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Writer-Tables Writer-Images
  Show dependency tree / graph
 
Reported: 2020-12-11 22:26 UTC by Telesto
Modified: 2022-08-06 14:51 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:

Attachments
Example file (2.02 MB, application/vnd.oasis.opendocument.text)
2020-12-11 22:27 UTC, Telesto 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-12-11 22:26:58 UTC 
Description:
Image in table anchored to paragraph/character deleted when deleting the last character below (but not in older versions)

Steps to Reproduce:
1. Open the attached file
2. Type something below the image
3. Press backspace.. On the last character the image will be gone too.. this wasn't the case in early versions

Actual Results:
Image disappears with last character

Expected Results:
It should be possible to delete the last character without including the anchor


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.2.0.0.alpha0+ (x64)
Build ID: 796c7f612603490dda9277ced0f6ab3cce3bc116
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2020-12-11 22:27:25 UTC 
Created attachment 168084 [details]
Example file
Comment 2 Telesto 2020-12-11 22:43:39 UTC 
Still fine with
Version: 6.4.0.0.beta1+ (x64)
Build ID: 20be5cd0bdc57d812bf34a2debfe48caa51de881
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: GL; VCL: win; 
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: CL
Comment 3 Dieter 2021-06-28 05:18:25 UTC 
I confirm it with

Version: 7.1.4.2 (x64) / LibreOffice Community
Build ID: a529a4fab45b75fefc5b6226684193eb000654f6
CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL
Comment 4 raal 2021-07-01 15:42:38 UTC 
This seems to have begun at the below commit.
Adding Cc: to Michael Stahl ; Could you possibly take a look at this one?
Thanks
linux-64-7.1$ 4e5d31bd4352ae55cae5c7d16e6ed16ec8a2110f is the first bad commit
commit 4e5d31bd4352ae55cae5c7d16e6ed16ec8a2110f
Author: Jenkins Build User <tdf@pollux.tdf>
Date:   Wed Jun 10 19:40:03 2020 +0200

    source 32c162ad1723512763b74d01eaec32c1296f3a55

https://git.libreoffice.org/core/+/32c162ad1723512763b74d01eaec32c1296f3a55
  tdf#132725 sw: SwUndoDelete: don't group if flys are be deleted
Comment 5 Michael Stahl (allotropia) 2022-06-08 18:29:50 UTC 
fixed on master
Comment 6 Michael Stahl (allotropia) 2022-06-21 12:09:10 UTC 
notification didn't happen, apparently i need to put all the bugs into subject line:

commit a6832b836e6905362c85d1a90c8779cf7ce821fe
Author:     Michael Stahl <michael.stahl@allotropia.de>
AuthorDate: Tue Jun 7 19:01:24 2022 +0200
Commit:     Michael Stahl <michael.stahl@allotropia.de>
CommitDate: Tue Jun 21 10:03:07 2022 +0200

    tdf#133957 sw: don't delete flys on Backspace/Delete keys
    
    Also fixes: tdf#134007 tdf#138835 tdf#139514
Comment 7 Dieter 2022-08-06 14:51:55 UTC 
VERIFIED with

Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: a56d0c34716f381accbd9d2e3040a62d3583d18d
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL

Michael, thank you for fixing it!