Bug 138846 - Add label to "Settings" button in Template Manager and change label to "Categories"
Summary: Add label to "Settings" button in Template Manager and change label to "Categ...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.2.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.2.0
Keywords:
Depends on:
Blocks: Template-Manager
  Show dependency treegraph
 
Reported: 2020-12-12 10:00 UTC by sdc.blanco
Modified: 2021-01-14 16:51 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Mockup (29.38 KB, image/png)
2020-12-18 15:01 UTC, Heiko Tietze
Details

Note You need to log in before you can comment on or make changes to this bug.
Description sdc.blanco 2020-12-12 10:00:47 UTC
Summary says it all.

Reasons: 

1.  No label on icon creates a problem for screen readers (see bug 115847)
2.  Dropdown menu has nothing to do with settings, and everything to do with Categories
Comment 1 Heiko Tietze 2020-12-14 17:30:00 UTC
Dealing with the categories is not prime in my opinion. Saving space and clutter compensates less accessibility. But open for arguments. What do you think, Susanne?
Comment 2 jan d 2020-12-15 21:41:38 UTC
I agree that the label or mouseover text should be categories. To the icon vs. labeled button I have no particular opinion. 
 
What about moving the gear button up to the upper right corner next to the categories dropdown? That might at least help semantically a bit, as then the both category-concerned elements would be next to each other.
Comment 3 sdc.blanco 2020-12-17 01:35:01 UTC
(In reply to jan d from comment #2)
> To the icon vs. labeled button I have no particular opinion. 
Neither do I, beyond acknowledging the general issue raised in bug 115847 with exactly this icon.

> What about moving the gear button up to the upper right corner next to the
> categories dropdown? That might at least help semantically a bit, as then
> the both category-concerned elements would be next to each other.
Interesting idea.  

Also for semantic reasons, if "Settings" ("Categories") icon stays in lower left, then move "Move" next to "Gear"  (because "Move" is a "categories" operation).  

Or to reduce even more clutter, put "move" command into Settings dropdown menu as "Move Template"  (or "Move to Category..." )
Comment 4 Heiko Tietze 2020-12-18 15:01:34 UTC
Created attachment 168299 [details]
Mockup

We discussed the topic in the design meeting. Jan's proposal in comment 2 sounds like the best solution, then still without label. But we should also consider to use not a menu but a standard button and have all interactions in a dialog. It would list all categories with the related functions in one dialog.
Comment 5 sdc.blanco 2020-12-18 15:37:52 UTC
Was there any decision about the *name* of the label for the "gear" icon (which will remain visible only by tooltip)?

The Category actions (New, Rename, Delete) in the submenu are not "settings"  

otoh  "Refresh" and "Reset default..." are not category-related

... so neither label is good.

Not advocating any direction, just need to know if it will change, so that I can finish updating the template manager help page.
Comment 6 Heiko Tietze 2021-01-11 03:59:41 UTC
(In reply to sdc.blanco from comment #5)
> Was there any decision about the *name* of the label for the "gear" icon
No. Just pick a label and fix it later, if needed.
Comment 7 Commit Notification 2021-01-13 13:11:48 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/008cf21683f2b072532ab706f25a7a6bd1126231

tdf#138846 change "Settings" to "Tools" in Template Manager dialog

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 sdc.blanco 2021-01-13 15:49:24 UTC
@Heiko - my patch only changes the "label" on the "gear" -- but discussion in this ticket yielded other ideas for the UI in relation to categories in the template manager.  See comment 4.

==> neutral query about whether you want to keep this bug open (possibly with an adjusted summary) to preserve that idea.
Comment 9 Commit Notification 2021-01-14 16:51:40 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/319b987c6acfd51ba009e6c2e63284bf2eec92c7

tdf#107229 (related to tdf#138846) update "settings" label to "tools"