Bug 138876 - User should be able to selectively decide which styles are imported from an updated template
Summary: User should be able to selectively decide which styles are imported from an u...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
7.2.0.0.alpha0+ Master
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: needsDevAdvice
Depends on:
Blocks: Templates
  Show dependency treegraph
 
Reported: 2020-12-13 13:56 UTC by sdc.blanco
Modified: 2021-02-15 15:11 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sdc.blanco 2020-12-13 13:56:40 UTC
In https://help.libreoffice.org/7.2/en-US/text/shared/01/01020000.html, it is written:

"When you open a document that was created from a "sticky template" (as defined above), LibreOfficeDev checks to see if the template has been modified since the document was last opened. If the template was changed a dialog is shown where you can select which styles to apply to the document."

Main Question for this bug:   Is the user supposed to be able to "select which styles to apply"  or is this help page wrong on this point?

Additional information.  

As noted in the next two lines in the help page, the user can choose to "Update Styles" or "Keep Old Styles", but then all styles are imported, without an opportunity for selecting among them.

Here are the two lines in question.

"To apply the new styles from the template to the document, click Update Styles.

To retain the styles that are currently used in the document, click Keep Old Styles."


Secondary question for this bug: In the first of those two lines, shouldn't "apply the new styles" actually be written as "import the new styles"  or just "import the styles"?
Comment 1 Heiko Tietze 2020-12-16 08:43:39 UTC
Rafael, you implemented the dialog in 2012. Remember how it was supposed to work?
Comment 2 sdc.blanco 2020-12-20 09:24:13 UTC
Have tried, without success, to find the relevant place in the source code where "template-checking" is done, when documents are opened.  

In this way, it may be possible to give an empirical "answer" to the question about the accuracy of the help page, so that its updating can be finished.
Comment 3 QA Administrators 2020-12-21 03:45:05 UTC Comment hidden (obsolete)
Comment 4 sdc.blanco 2020-12-28 17:49:16 UTC
I believe this functionality, of selecting which styles to import, used to exist, see bug 60589, but was dropped (or converted) to the current "Load Styles" dialog (which allows selection among different style categories).

But even that slightly less differentiated possibility (offered in "Load Styles") is not offered in the "open file" dialog, which is the question here.
Comment 5 Heiko Tietze 2021-01-11 06:14:28 UTC
(In reply to sdc.blanco from comment #2)
> Have tried, without success, to find the relevant place in the source code
> where "template-checking" is done, when documents are opened.  

sfx2/source/doc/objcont.cxx #527 (-> class QueryTemplateBox #403)

Quite some todo remarks below. Was it ever working?