Bug 138976 - "Cancel" button in Template Manager should be "Close"
Summary: "Cancel" button in Template Manager should be "Close"
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
7.2.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: sdc.blanco
URL:
Whiteboard: target:7.2.0
Keywords:
: 137512 (view as bug list)
Depends on:
Blocks: Template-Manager
  Show dependency treegraph
 
Reported: 2020-12-16 17:09 UTC by sdc.blanco
Modified: 2021-01-27 12:46 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sdc.blanco 2020-12-16 17:09:14 UTC
There is nothing to "cancel" in the Template Manager dialog.
"cancel" gives the (false) impression that some operations can be "undone".
afaik, nothing can be "undone" with this button. 
"close" gives the more accurate impression that the dialog box will be closed.
Comment 1 Commit Notification 2020-12-17 10:26:13 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/4484accf4d331a95ebf8475d6cd91950f4c27bcc

tdf#138976 change "Cancel" button to "Close" in Template Manager dialog

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 2 Heiko Tietze 2020-12-17 10:45:00 UTC
The Open/Close combination of buttons is a bit unusual but I'm not against changing it. Thanks for the patch.
Comment 3 sdc.blanco 2020-12-17 12:55:37 UTC
(In reply to Heiko Tietze from comment #2)
> The Open/Close combination of buttons is a bit unusual.
Good point. (never saw "Open" until now.)

Perhaps "Open" should be "New Document" here?

(given that "Open" in relation to files usually implies an existing document)
Comment 4 Heiko Tietze 2020-12-17 14:40:27 UTC
(In reply to sdc.blanco from comment #3)
> Perhaps "Open" should be "New Document" here?

Or just "New"? Maybe not. Let's see how it fits in the dialog.
Comment 5 sdc.blanco 2020-12-17 18:56:58 UTC
(In reply to Heiko Tietze from comment #4)
> (In reply to sdc.blanco from comment #3)
> > Perhaps "Open" should be "New Document" here?
> 
> Or just "New"? Maybe not. Let's see how it fits in the dialog.
File > New > Templates opens Template Manager.

A "New" button would be meaningful in that workflow.

The button already has a nice quality of being deactivated when no template
is selected.

Probably its "position" should be promoted/improved.

Reason: If primary (dominant) use of Template Manager (for most users) is to open new documents (until something like bug 137906 is implemented), then it should be easy to "notice" that button.  Possibly by itself in middle bottom of Template Manager.

File new ticket?  or stay here?
Comment 6 Heiko Tietze 2020-12-18 07:40:15 UTC
(In reply to sdc.blanco from comment #5)
> Probably its "position" should be promoted/improved.
> 
> ...Possibly by itself in middle bottom of Template Manager.

I disagree here. Uncommon button position makes the button not outstanding but adds confusion. It will just look like a misplaced control. The button behaves as standard function for the dialog and is quite clear and prominent by that.
Comment 7 sdc.blanco 2020-12-18 09:45:58 UTC
(In reply to Heiko Tietze from comment #6)
> (In reply to sdc.blanco from comment #5)
> > Probably its "position" should be promoted/improved.
> > 
> > ...Possibly by itself in middle bottom of Template Manager.
> 
> I disagree here.
No problem.  Was responding to "Let's see how it fits in the dialog." in comment 4.  Independently of my naive suggestion, it seems like a better location could be found.

But you did not respond to the question/issue of what the button should be called.

Would be useful to have a decision, one way or another, about button name (independent of its location), because it has consequences for an almost finished update to the help page for template manager.
Comment 8 Heiko Tietze 2020-12-18 10:23:15 UTC
(In reply to sdc.blanco from comment #5)
> File > New > Templates opens Template Manager.
> 
> A "New" button would be meaningful in that workflow.

I read this as if you think "New" is fine. I wondered in comment 4 if this might be mistaken as New Template given New Document is too long. Just pick one, the doer is always right.
Comment 9 sdc.blanco 2021-01-27 12:46:10 UTC
*** Bug 137512 has been marked as a duplicate of this bug. ***