Bug 139002 - FILEOPEN - don't hang opening a .pptx / SVG path with 2699660320 elements
Summary: FILEOPEN - don't hang opening a .pptx / SVG path with 2699660320 elements
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
4.1 all versions
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.2.0 target:7.1.1
Keywords: filter:pptx, perf
Depends on:
Blocks:
 
Reported: 2020-12-17 15:53 UTC by cloud019998
Modified: 2021-08-08 12:29 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
.pptx file (13.62 MB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2020-12-17 15:54 UTC, cloud019998
Details

Note You need to log in before you can comment on or make changes to this bug.
Description cloud019998 2020-12-17 15:53:56 UTC
Description:
Can't open this file

Actual Results:
White page and LibreOffice doesn't respond

Expected Results:
Opening the file


Reproducible: Always


User Profile Reset: No



Additional Info:
Windows 10 64bit
Comment 1 cloud019998 2020-12-17 15:54:52 UTC
Created attachment 168260 [details]
.pptx file
Comment 2 Xisco Faulí 2020-12-18 18:08:28 UTC
Reproduced in

Version: 7.2.0.0.alpha0+
Build ID: 8b3982681e98818388c09233960ad6eaacee205a
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

Version: 5.2.0.0.alpha1+
Build ID: 5b168b3fa568e48e795234dc5fa454bf24c9805e
CPU Threads: 4; OS Version: Linux 4.8; UI Render: default; 
Locale: ca-ES (ca_ES.UTF-8)

Version 4.1.0.0.alpha0+ (Build ID: efca6f15609322f62a35619619a6d5fe5c9bd5a)
Comment 3 Noel Grandin 2021-01-31 19:37:47 UTC
This document contains an SVG path with 2699660320 elements.

I'm inclined to say that the most useful thing we can do here is to simply return an error and say that we cannot process such a pathological document.
Comment 4 Commit Notification 2021-02-02 06:13:27 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8bb759e22e564a9076fdffee8705e62fbe545a35

tdf#139002 dont hang opening pathological SVGs

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2021-02-05 18:43:14 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/cfcd3db7d67d70e547a11141fa6cc91c38825e8b

tdf#139002 dont hang opening pathological SVGs

It will be available in 7.1.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.