Bug 139031 - Some dropdowns in the PDF export dialog should be aligned better (kf5)
Summary: Some dropdowns in the PDF export dialog should be aligned better (kf5)
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.0.3.1 release
Hardware: All Linux (All)
: lowest trivial
Assignee: Michael Weghorn
URL:
Whiteboard: target:7.3.0
Keywords: needsUXEval
Depends on:
Blocks: KDE, KF5
  Show dependency treegraph
 
Reported: 2020-12-18 11:50 UTC by medmedin2014
Modified: 2021-11-17 19:35 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
image 1 (71.43 KB, image/png)
2020-12-18 11:50 UTC, medmedin2014
Details
image 2 (136.43 KB, image/png)
2020-12-18 11:51 UTC, medmedin2014
Details
Bad tab titles alignement (92.39 KB, image/png)
2021-11-12 22:24 UTC, medmedin2014
Details
Screenshot with https://gerrit.libreoffice.org/c/core/+/125104 (v1) in place (59.49 KB, image/png)
2021-11-15 08:22 UTC, Michael Weghorn
Details
screenshot (71.85 KB, image/png)
2021-11-17 19:33 UTC, BogdanB
Details

Note You need to log in before you can comment on or make changes to this bug.
Description medmedin2014 2020-12-18 11:50:44 UTC
Created attachment 168289 [details]
image 1

See attached images for more info.

Version: 7.0.3.1
Build ID: 00(Build:1)
CPU threads: 2; OS: Linux 5.4; UI render: default; VCL: kf5
Locale: en-US (en_US.UTF-8); UI: en-US
7.0.3-2
Calc: threaded

Operating System: Manjaro Linux
KDE Plasma Version: 5.20.4
KDE Frameworks Version: 5.76.0
Qt Version: 5.15.2
Kernel Version: 5.4.80-2-MANJARO
OS Type: 64-bit
Comment 1 medmedin2014 2020-12-18 11:51:06 UTC
Created attachment 168290 [details]
image 2
Comment 2 mulla.tasanim 2020-12-18 16:40:05 UTC
Thank you for reporting the bug. 
Unfortunately without clear steps to reproduce it, we cannot track down the origin of the problem. 
Please provide a clearer set of step-by-step instructions on how to reproduce the problem.
I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' once the requested information is provided.
Comment 3 medmedin2014 2020-12-18 16:42:40 UTC
(In reply to mulla.tasanim from comment #2)
> Thank you for reporting the bug. 
> Unfortunately without clear steps to reproduce it, we cannot track down the
> origin of the problem. 
> Please provide a clearer set of step-by-step instructions on how to
> reproduce the problem.
> I have set the bug's status to 'NEEDINFO'. Please change it back to
> 'UNCONFIRMED' once the requested information is provided.

What steps ! you just need to open pdf export dialog from Writer and you will see the bugs.
Comment 4 Buovjaga 2021-11-11 15:19:42 UTC
I confirm the misalignment of PDF/A Version and Submit Format dropdowns in kf5. Their left edges are aligned perfectly in gen and gtk3 backends. The other cosmetic problems are gone. I could add the missing ':' to the string later.

Arch Linux 64-bit
Version: 7.3.0.0.alpha1+ / LibreOffice Community
Build ID: 9f8e4bd8501e9bb9e286cffed5f35d0f0075e9b8
CPU threads: 8; OS: Linux 5.14; UI render: default; VCL: kf5 (cairo+xcb)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Built on 11 November 2021
Comment 5 Michael Weghorn 2021-11-12 12:59:09 UTC
(In reply to Buovjaga from comment #4)
> I confirm the misalignment of PDF/A Version and Submit Format dropdowns in
> kf5. Their left edges are aligned perfectly in gen and gtk3 backends. The
> other cosmetic problems are gone. I could add the missing ':' to the string
> later.

"gen" is not perfectly left-aligned for me either.

Does https://gerrit.libreoffice.org/c/core/+/125104 result in the desired behaviour wrt alignment?
Comment 6 Buovjaga 2021-11-12 15:05:00 UTC
(In reply to Michael Weghorn from comment #5)
> (In reply to Buovjaga from comment #4)
> > I confirm the misalignment of PDF/A Version and Submit Format dropdowns in
> > kf5. Their left edges are aligned perfectly in gen and gtk3 backends. The
> > other cosmetic problems are gone. I could add the missing ':' to the string
> > later.
> 
> "gen" is not perfectly left-aligned for me either.
> 
> Does https://gerrit.libreoffice.org/c/core/+/125104 result in the desired
> behaviour wrt alignment?

Much better, not pixel perfect (checked in Gimp by pulling out a reference line from the ruler), but I guess it is enough.
Comment 7 phv 2021-11-12 16:43:05 UTC
Regarding the forgotten colon punctuation mark mentioned in this report, I think the wording should be:

"Reduce image resolution to:"

Because this label is using a verb and requires a value. Or, alternatively:

"Image resolution:"

I note that there are slight inconsistencies in the display of LibreOffice options, which makes it unclear what the relevant rules are. Here is a list of missing colons:

- LibreOffice Writer & LibreOffice Writer/Web → View → "Horizontal ruler" and "Vertical ruler"
- LibreOffice Writer/Web → View → "Measurement unit"
- LibreOffice Writer → Comparison → "Ignore piece of length"
- LibreOffice Base → Connections → "Timeout (seconds)"

It is therefore a very minor and tolerable issue, but recurrent in the presentation of the options.
Comment 8 medmedin2014 2021-11-12 18:25:40 UTC
I think in General tab, the wrong horizontal alignment for "JPEG Compression Quality" text label is due to the use of two text labels (instead of one) : one containing "JPEG Compression" and new one containing "Quality".
Comment 9 medmedin2014 2021-11-12 18:28:44 UTC
Another problem that catches the eye is the mix of alignment rule applied to tabs titles, for example the tabs titles : "User Interface" and "Digital Signature" are left aligned while others are centered.
Comment 10 Michael Weghorn 2021-11-12 22:07:11 UTC
(In reply to Buovjaga from comment #6)
> > Does https://gerrit.libreoffice.org/c/core/+/125104 result in the desired
> > behaviour wrt alignment?
> 
> Much better, not pixel perfect (checked in Gimp by pulling out a reference
> line from the ruler), but I guess it is enough.

Thanks for checking. You're right. Making it pixel perfect might be possible by doing a larger redesign, e.g. putting everything into the same grid (but I'm not an expert here). Currently, there are different "groups" of UI elements, which is used e.g. to make the "formsframe" sensitive or not ("gray it out") from C++ side.

(In reply to medmedin2014 from comment #8)
> I think in General tab, the wrong horizontal alignment for "JPEG Compression
> Quality" text label is due to the use of two text labels (instead of one) :
> one containing "JPEG Compression" and new one containing "Quality".

Those are indeed two different elements, the alignment is fine in my current master build with the Breeze style, though. Might be that those are 2 different elements by design, since its the option "JPEG Compression", and then a related (but separate) option to set the quality when that option has been selected, rather than a "JPEG Compression Quality" label.

(In reply to medmedin2014 from comment #9)
> Another problem that catches the eye is the mix of alignment rule applied to
> tabs titles, for example the tabs titles : "User Interface" and "Digital
> Signature" are left aligned while others are centered.

I quickly tried with a master build, all tabs look centered there (with the Breeze style at least and I'd say it's the same in the screenshot). To me, it just looks like "User Interface" and "Digital Signature" are the longest texts, and everything is fine so far. When you click on those tabs, the same "margin" can be seen on the left and right tab for that tab itself.


(In reply to phv from comment #7)
> Regarding the forgotten colon punctuation mark mentioned in this report, I
> think the wording should be:
> 
> "Reduce image resolution to:"
> 
> Because this label is using a verb and requires a value. Or, alternatively:
> 
> "Image resolution:"
> 
> I note that there are slight inconsistencies in the display of LibreOffice
> options, which makes it unclear what the relevant rules are. Here is a list
> of missing colons:
> 
> - LibreOffice Writer & LibreOffice Writer/Web → View → "Horizontal ruler"
> and "Vertical ruler"
> - LibreOffice Writer/Web → View → "Measurement unit"
> - LibreOffice Writer → Comparison → "Ignore piece of length"
> - LibreOffice Base → Connections → "Timeout (seconds)"
> 
> It is therefore a very minor and tolerable issue, but recurrent in the
> presentation of the options.

Let's ask for UX advice here.
@Heiko: Do you possibly have any opinion/suggestion on this?
Comment 11 Michael Weghorn 2021-11-12 22:14:45 UTC
(In reply to Michael Weghorn from comment #10)
> (In reply to medmedin2014 from comment #8)
> > I think in General tab, the wrong horizontal alignment for "JPEG Compression
> > Quality" text label is due to the use of two text labels (instead of one) :
> > one containing "JPEG Compression" and new one containing "Quality".
> 
> Those are indeed two different elements, the alignment is fine in my current
> master build with the Breeze style, though. Might be that those are 2
> different elements by design, since its the option "JPEG Compression", and
> then a related (but separate) option to set the quality when that option has
> been selected, rather than a "JPEG Compression Quality" label.

Having 2 elements instead of just one e.g. makes a difference for screen readers, I just tested with Orca and the gtk3 VCL plugin: "Quality, enter the ..." is only announced by the screen reader when the focus is actually on the spin button where the quality can be set, which is presumably desirable.
Comment 12 Michael Weghorn 2021-11-12 22:16:24 UTC
(In reply to Michael Weghorn from comment #10)
> Let's ask for UX advice here.
> @Heiko: Do you possibly have any opinion/suggestion on this?

Now actually adding Heiko to CC...
Comment 13 medmedin2014 2021-11-12 22:24:46 UTC
Created attachment 176223 [details]
Bad tab titles alignement

(In reply to Michael Weghorn from comment #10)

> I quickly tried with a master build, all tabs look centered there (with the
> Breeze style at least and I'd say it's the same in the screenshot). To me,
> it just looks like "User Interface" and "Digital Signature" are the longest
> texts, and everything is fine so far. When you click on those tabs, the same
> "margin" can be seen on the left and right tab for that tab itself.

See attached image for more info.

Version: 7.3.0.0.alpha1+ / LibreOffice Community
Build ID: 23214f1c14c4d3981dad90b6e3ba6e4ca2c8c30e
CPU threads: 2; OS: Linux 5.4; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 14 Heiko Tietze 2021-11-13 06:47:37 UTC
(In reply to phv from comment #7)
> I note that there are slight inconsistencies ... of missing colons:

The HIG is clear on that: "Add a colon after labels that have a relation to buddy controls."

https://wiki.documentfoundation.org/Design/Guidelines/PropertyDialog

(In reply to Michael Weghorn from comment #10)
> Let's ask for UX advice here.

You need to add the keyword and CC to libreoffice-ux-advise@lists.freedesktop.org
Comment 15 Buovjaga 2021-11-13 12:34:03 UTC
Patch for reported missing colons: https://gerrit.libreoffice.org/c/core/+/125147
Comment 16 Michael Weghorn 2021-11-15 07:42:49 UTC
(In reply to medmedin2014 from comment #13)
> Created attachment 176223 [details]
> Bad tab titles alignement
> 
> (In reply to Michael Weghorn from comment #10)
> 
> > I quickly tried with a master build, all tabs look centered there (with the
> > Breeze style at least and I'd say it's the same in the screenshot). To me,
> > it just looks like "User Interface" and "Digital Signature" are the longest
> > texts, and everything is fine so far. When you click on those tabs, the same
> > "margin" can be seen on the left and right tab for that tab itself.
> 
> See attached image for more info.

Thanks. I still think that the two tabs mentioned are "centred" as the others are, it's just that all tabs are not "perfectly" centred. Looking at the image, the left and right margins of the "General" tab are also not exactly the same size, the right-hand one is a few pixels wider, and I think that's the same that's happening  for the "User Interface" and "Digital Signature" tabs, but it's more visible there. To me, this doesn't look like a problem in that specific dialog.
I think there was already a similar discussion about that in another ticket in the past.
Currently, the qt5/kf5 VCL plugin doesn't use native Qt widgets, which would probably be the best way forward in the long run, s. tdf#130857 .
Comment 17 Michael Weghorn 2021-11-15 08:22:32 UTC
Created attachment 176256 [details]
Screenshot with https://gerrit.libreoffice.org/c/core/+/125104 (v1) in place

Screenshot of the dialog with https://gerrit.libreoffice.org/c/core/+/125104 (v1) in place, for discussion in Gerrit
Comment 18 Michael Weghorn 2021-11-15 09:54:44 UTC
(In reply to Michael Weghorn from comment #16)
> I think there was already a similar discussion about that in another ticket
> in the past.

I've found it, but it turns out that was about vertical alignment in Notebookbar tabs: bug 131099
Comment 19 Commit Notification 2021-11-15 12:01:45 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5470514db7993b4c9f079a961adc30d70fb77fba

tdf#139031 Better align dropdowns in PDF export dialog

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 20 Commit Notification 2021-11-16 13:52:52 UTC
Ilmari Lauhakangas committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/fcbf3841c534aa7a96e0ff893ecc1c1c4af961e5

Related tdf#139031: add missing colons

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 21 BogdanB 2021-11-17 19:33:28 UTC
Created attachment 176324 [details]
screenshot

Jus a note:
"JPEG compression Quality" seems to be formed from 2 expresions OR there is a double space between "JPEG compression" and "Quality". I thing this expresion should be just one.

Version: 7.3.0.0.alpha1+ / LibreOffice Community
Build ID: fcad2503ede92b515076f9bb3162855dcc2c575d
CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 22 BogdanB 2021-11-17 19:35:20 UTC
On help pages they are separated terms, in the image.
In this case ignore my previous comment.

https://help.libreoffice.org/7.3/en-US/text/shared/01/ref_pdf_export_general.html?System=UNIX&DbPAR=CALC&HID=filter/ui/pdfgeneralpage/PdfGeneralPage#bm_id1033968