Bug 139094 - UI: Border selector still in selected state after clicking different border
Summary: UI: Border selector still in selected state after clicking different border
Status: RESOLVED NOTABUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-20 14:13 UTC by Telesto
Modified: 2021-01-18 10:44 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-12-20 14:13:51 UTC
Description:
Border selector still in selected state after clicking different border

Steps to Reproduce:
1. Open Writer
2. Insert a table say 2x2
3. Table -> Properties
4. Borders tab
5. Press in the middle of the user border picker tool (inner horizontal/vertical gets selected).. getting gray bar (fine)
6. No click the left or right border.. 

Actual Results:
1. First click on left border -> still black line visible (initial selection not deselected; still gray)
2, Second click (left border selected. Inner border similar highlighted (but deselected)


Expected Results:
Left border should deselect inner border.. and highlight the left border (so grayish look)

If the idea is to be able to select multiple borders at once for say color change.. something else should be figured out.. this doesn't work (and never worked)


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.2.0.0.alpha0+ (x64)
Build ID: 315c7570c4a72f4c834086082825533b1e50d1bf
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Regina Henschel 2020-12-20 15:09:59 UTC
Please have a look at help topic "User Defined Borders in Text Documents".
gray bar does not mean "selected" but means "do not change".
Comment 2 Telesto 2020-12-20 15:39:54 UTC
(In reply to Regina Henschel from comment #1)
> Please have a look at help topic "User Defined Borders in Text Documents".
> gray bar does not mean "selected" but means "do not change".

Thanks for extreme faster reply

Ok, you're talking about this:
https://help.libreoffice.org/7.2/en-US/text/swriter/guide/borders.html?&DbPAR=WRITER&System=WIN

While I was looking at: 
https://help.libreoffice.org/7.2/en-US/text/shared/guide/border_table.html?&DbPAR=WRITER&System=WIN

A pointer in border table would be nice :-)-> But that's a documentation issue

---
But back to the topic: still not reaching enlightenment after reading the help :-(. And still having the feeling something being off somewhere.. At least tried couple of things... I still not getting how to make use of the triple state

1. Click in the middle of user defined image.. -> gray cross
2. Pick a color -> Color applied to inner selected borders (Supposed to do this?). Or should the inverse happen (as gray means unchanged?)
3. Set no border template
4. Click all borders template 
5. Click in the middle of user defined image again (first click makes gray)
6. Click the left border -> first click makes it black (so cycling through states differently?)
Comment 3 Heiko Tietze 2021-01-11 04:29:48 UTC
The sequence if empty is
* Set, DontChange, None
and if set
* DontChange, None, Set

Makes perfectly sense to me.

If you click from one border line to another it always Set. Sounds not too unreasonable to me. => NAB
Comment 4 Telesto 2021-01-11 20:38:18 UTC
(In reply to Heiko Tietze from comment #3)
> and if set
> * DontChange, None, Set

What should I expect from DontChange in this situation (so border set)
Comment 5 Telesto 2021-01-12 12:55:01 UTC
Setting to UNCONFIRMED.. I know.. Bug tracker is not help.. but tend to see flakyness

What's DontChange supposed to be of an state..
Comment 6 Heiko Tietze 2021-01-18 10:37:47 UTC
(In reply to Telesto from comment #4)
> (In reply to Heiko Tietze from comment #3)
> > and if set
> > * DontChange, None, Set
> 
> What should I expect from DontChange in this situation (so border set)

Keep it set. Whether the line is set or not is kept when you chose DontChange. I don't see an issue here, rather a (small) regression if we follow your implicit suggestion to drop this state and toggle lines just on or off. I guess the state was introduced in first place to make the presets more powerful, eg. use red lines for all borders and blue for the outer edges.
Comment 7 Telesto 2021-01-18 10:44:14 UTC
FW(In reply to Heiko Tietze from comment #6)
> (In reply to Telesto from comment #4)
> > (In reply to Heiko Tietze from comment #3)
> > > and if set
> > > * DontChange, None, Set
> > 
> > What should I expect from DontChange in this situation (so border set)
> 
> Keep it set. Whether the line is set or not is kept when you chose
> DontChange. I don't see an issue here, rather a (small) regression if we
> follow your implicit suggestion to drop this state and toggle lines just on
> or off. I guess the state was introduced in first place to make the presets
> more powerful, eg. use red lines for all borders and blue for the outer
> edges.

FWIW, my suggestions are mostly simply a direction. Mostly blind-guessing if it's feature or not.. But assuming 'DontChange' being actual thing.. it would like certain illustration how it supposed to work (screencast)