Bug 139174 - [UI] elementary: icons for (work)sheet does not represent actual sheet
Summary: [UI] elementary: icons for (work)sheet does not represent actual sheet
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.2.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Rizal Muttaqin
URL:
Whiteboard: target:7.2.0 target:7.1.0.2
Keywords:
Depends on:
Blocks: Icon-Theme-Elementary
  Show dependency treegraph
 
Reported: 2020-12-23 04:43 UTC by Rizal Muttaqin
Modified: 2021-01-04 04:44 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Sheet related icons in elementary theme (127.31 KB, image/png)
2020-12-23 04:43 UTC, Rizal Muttaqin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rizal Muttaqin 2020-12-23 04:43:54 UTC
Created attachment 168441 [details]
Sheet related icons in elementary theme

Using elementary icon in Calc, I notice that icons for sheet related command are not looked like an actual sheet, rather than a plain table

Step to reproduce
1. Change icon theme to elementary (Tools > Options > View)
2. Open up Calc, right click on sheet list in the bottom
3. Change UI to Tabbed, go to Layout, see some icons with Sheet name
4. Enable menubar, go to Edit > Select
5. See of each icon there

Version: 7.0.4.2
Build ID: 00(Build:2)
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: kf5
Locale: id-ID (id_ID.UTF-8); UI: en-US
Ubuntu package version: 1:7.0.4~rc2-0ubuntu0.20.04.2
Calc: threaded
Comment 1 Ming Hua 2020-12-23 12:12:39 UTC
This doesn't seem to be a Elementary-specific issue.

I checked all the bundled themes in 7.1.0 Beta1, and Breeze and Sifr also use icons that just look like plain tables.  Colibre, Karasa Jaga, and Sukapura are good.

I can attach screenshots if needed.  Though I use standard toolbar UI and only checked the context menu for sheet tab (the bottom left part of Rizal's screenshot), not others.
Comment 2 Rizal Muttaqin 2020-12-23 12:39:10 UTC
(In reply to Ming Hua from comment #1)
> This doesn't seem to be a Elementary-specific issue.
> 
> I checked all the bundled themes in 7.1.0 Beta1, and Breeze and Sifr also
> use icons that just look like plain tables.  Colibre, Karasa Jaga, and
> Sukapura are good.
> 
> I can attach screenshots if needed.  Though I use standard toolbar UI and
> only checked the context menu for sheet tab (the bottom left part of Rizal's
> screenshot), not others.

Yes I have already know it also. What we need just other bug reports. ;)
Comment 3 Commit Notification 2020-12-23 21:49:26 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/4b143449bfb8bf3959bf9cf02a9e8d8f8a3582f6

elementary: tdf#139174 update sheet related icons to be real sheet

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2020-12-28 05:06:32 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/11b5980ef1cec9e6cf54c963328fb9b3edd3a896

elementary: tdf#139174 update sheet in Calc's Navigator

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2021-01-02 04:59:27 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c186398cfae53bd95a8926849e1a8623d93b888b

elementary: tdf#139174 update sheet: sync color with table related icons

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2021-01-04 04:44:43 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/8971b4ca5db46720079dd3239c9465dcc2d42190

tdf#139056 tdf#139353 tdf#139020 tdf#139219 tdf#139174 tdf#139048 tdf#139046 tdf#139052

It will be available in 7.1.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.