Bug 139229 - Tracking changes: rejecting change will make shape disappear (anchored to paragraph)
Summary: Tracking changes: rejecting change will make shape disappear (anchored to par...
Status: RESOLVED NOTABUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.4.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Track-Changes-Shape
  Show dependency treegraph
 
Reported: 2020-12-25 17:21 UTC by Telesto
Modified: 2021-06-24 10:45 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file (10.06 KB, application/vnd.oasis.opendocument.text)
2020-12-25 17:21 UTC, Telesto
Details
Similar example file from Word (15.50 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2021-06-24 10:40 UTC, NISZ LibreOffice Team
Details
The example file opened in Word and Writer (88.59 KB, image/png)
2021-06-24 10:40 UTC, NISZ LibreOffice Team
Details
The example file in Word and Writer after rejecting the change (77.09 KB, image/png)
2021-06-24 10:42 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-12-25 17:21:18 UTC
Description:
Tracking changes: rejecting change will make image disappear (anchored to paragraph) 

Steps to Reproduce:
1. Open the attached file
2. Edit -> Track Changes -> Reject

Actual Results:
Image/shape gone

Expected Results:
Not so


Reproducible: Always


User Profile Reset: No



Additional Info:
Found in
Version: 7.2.0.0.alpha0+ (x64)
Build ID: 315c7570c4a72f4c834086082825533b1e50d1bf
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL


and in
Version: 6.4.0.0.beta1+ (x64)
Build ID: 20be5cd0bdc57d812bf34a2debfe48caa51de881
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win; 
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: CL


not in
Version: 6.3.0.0.alpha0+
Build ID: 994b41a6c69d20637dcb95894c385f5c0102d600
CPU threads: 4; OS: Windows 6.3; UI render: GL; VCL: win; 
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: CL
Comment 1 Telesto 2020-12-25 17:21:29 UTC
Created attachment 168484 [details]
Example file
Comment 2 NISZ LibreOffice Team 2020-12-30 10:54:38 UTC
Confirming with:

Version: 7.2.0.0.alpha0+ (x64)
Build ID: c0eee433e079d8e3413f4691607e075b99af92b0
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL

Seems to have started in 6.4 with:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=e75dd1fc992f168f24d66595265a978071cdd277

author	Michael Stahl <Michael.Stahl@cib.de>	2019-12-05 16:49:33 +0100
committer	Michael Stahl <michael.stahl@cib.de>	2019-12-06 14:44:42 +0100

tdf#121300 sw: consistent fly at-pargraph selection

Adding CC to: Michael Stahl
Comment 3 NISZ LibreOffice Team 2021-06-23 13:01:35 UTC
This is actually a drawing shape, changing title.
Comment 4 NISZ LibreOffice Team 2021-06-24 10:40:23 UTC
Created attachment 173154 [details]
Similar example file from Word

Looking at this a bit more Word does the same: when a shape is anchored to an added paragraph, they are considered one change.

This example file demonstrates that. Import of this works the same in Writer (the shape is considered anchored to paragraph), and export of the original attachment works the same in Word.
Comment 5 NISZ LibreOffice Team 2021-06-24 10:40:56 UTC
Created attachment 173155 [details]
The example file opened in Word and Writer
Comment 6 NISZ LibreOffice Team 2021-06-24 10:42:30 UTC
Created attachment 173156 [details]
The example file in Word and Writer after rejecting the change

With:

Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 6805efdecb240fad8c82a5c1756a2a0e92f12b7d
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: default; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL
Comment 7 NISZ LibreOffice Team 2021-06-24 10:45:02 UTC
I think this and bug 139228 are not real bugs, the behavior is now correct.

When a shape is anchored to a not change tracked part of text when added/deleted then it's not change tracked. I opened the meta bug 143033 for such cases.