Bug 139283 - Two undo steps for single Clear formatting action
Summary: Two undo steps for single Clear formatting action
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: low minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Undo-Redo Clear-Formatting
  Show dependency treegraph
 
Reported: 2020-12-28 15:46 UTC by Telesto
Modified: 2023-05-26 09:25 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file (8.90 KB, application/vnd.oasis.opendocument.text)
2020-12-28 18:54 UTC, Telesto
Details
Screencast (617.79 KB, video/mp4)
2021-01-30 14:13 UTC, Telesto
Details
No repro? (20.62 MB, video/mp4)
2023-05-26 08:10 UTC, Sophie Sipasseuth
Details
Screencast (346.41 KB, image/gif)
2023-05-26 09:21 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-12-28 15:46:19 UTC
Description:
Two undo steps for single Clear formatting action 

Steps to Reproduce:
1. Open attachment 166889 [details] (bug 137894)
2. CTRL+A
3. Clear formatting in the paragraph style drop down in toolbar
4. Undo -> Nothing
5. Undo -> Now working

Actual Results:
2 undo steps

Expected Results:
1 undo step


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.2.0.0.alpha0+ (x64)
Build ID: 315c7570c4a72f4c834086082825533b1e50d1bf
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2020-12-28 15:47:24 UTC
Also in
LibreOffice 3.5.7.2 
Build ID: 3215f89-f603614-ab984f2-7348103-1225a5b
Comment 2 Aron Budea 2020-12-28 16:13:08 UTC
Not reproducible for me, I get a single undo step, and it does undo the clear formatting action.

Version: 7.2.0.0.alpha0+
Build ID: 2577d9ecea199ca2c10d852cf279053a1b22faf7
CPU threads: 16; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 3 Telesto 2020-12-28 16:23:15 UTC
Updating to fresh master build
Comment 4 Telesto 2020-12-28 16:46:25 UTC
Still the same
Version: 7.2.0.0.alpha0+ (x64)
Build ID: 4e3ce9dd6ace0b22f7b3f45cf2338b201f4dc305
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 5 mulla.tasanim 2020-12-28 17:11:23 UTC
Thank you for reporting the bug.

I can not reproduce the bug in

Version: 7.0.3.1 (x64)
Build ID: d7547858d014d4cf69878db179d326fc3483e082
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL

Version: 7.2.0.0.alpha0+ (x64)
Build ID: 761a672d62df1891b9f4f367a499b220ab2b33fa
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL
Comment 6 Telesto 2020-12-28 17:43:46 UTC
Hmm has this something to do with fall back fonts?
Comment 7 Telesto 2020-12-28 18:54:14 UTC
Created attachment 168538 [details]
Example file

Slightly reduced file.. 

Steps I get
Applied styles: Default paragraph style
Reset attributes
Comment 8 Laurynas 2021-01-24 16:40:23 UTC
I can not reproduce the bug in:

Version: 7.0.4.2 (x64)
Build ID: dcf040e67528d9187c66b2379df5ea4407429775
CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win
Locale: en-GB (en_GB); UI: en-US
Calc: threaded

and in:

Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 8df14a82cee4fe0c4ca6f994c7c3f92373b411a3
CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win
Locale: en-GB (en_GB); UI: en-US
Calc: threaded
Comment 9 Dave Potter 2021-01-30 13:30:32 UTC
Problem cannot be reproduced in 
Ubuntu 20.04.1
Writer Version: 6.4.6.2 - Build ID: 1:6.4.6-0 ubuntu0.20.04.1
or
Windows 10
Writer Version: 6.4.6.2 - Build ID: 1:6.4.6-0ubuntu0.20.04.1
Comment 10 Telesto 2021-01-30 14:13:01 UTC
Created attachment 169298 [details]
Screencast
Comment 11 Aron Budea 2021-05-23 02:18:18 UTC
Okay, this was a slight misunderstanding, Clear Formatting (not to be confused with Clear Direct Formatting) seems to perform:
1. Reset Attributes (= Clear Direct Formatting)
2. Apply Default Paragraph Style.

(In reply to Telesto from comment #0)
> 3. Clear formatting in the paragraph style drop down in toolbar
> 4. Undo -> Nothing
> 5. Undo -> Now working
In step 4 it doesn't do "nothing," just the document only has the Default Paragraph Style set (plus direct formatting), therefore there is nothing to undo. But yeah, these should be a single undo step.

Reproduced in LO Version: 7.2.0.0.alpha1+ (b238522ca121ca8f863fe4d3394ade088a65ad01), 3.3.0 / Ubuntu.
Comment 12 Sophie Sipasseuth 2023-05-22 08:48:32 UTC
No repro:
- with ctrl+z, 
- with the edition menu then undo, 
- and with a right-click on the text and choose the option "erase direct formatting" (in French "effacer le formatage direct")

Version: 7.6.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: f4c24da1e7f11664e0d2f688d2531f068e4a3bc0
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: fr-FR (fr_FR); UI: fr-FR
Calc: CL threaded
Comment 13 Buovjaga 2023-05-25 09:26:04 UTC
(In reply to Sophie Sipasseuth from comment #12)
> No repro:
> - with ctrl+z, 
> - with the edition menu then undo, 
> - and with a right-click on the text and choose the option "erase direct
> formatting" (in French "effacer le formatage direct")

Steps are wrong. Original steps don't have right-click to clear direct formatting, but: "Clear formatting in the paragraph style drop down in toolbar"

Still repro with original steps.

Arch Linux 64-bit, X11
Version: 7.6.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 85a47bbb8340e65a19dc1ceaac768902a771ee77
CPU threads: 8; OS: Linux 6.3; UI render: default; VCL: kf5 (cairo+xcb)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Built on 17 May 2023
Comment 14 Sophie Sipasseuth 2023-05-26 08:10:44 UTC
Created attachment 187517 [details]
No repro?
Comment 15 Telesto 2023-05-26 09:21:23 UTC
Created attachment 187518 [details]
Screencast
Comment 16 Sophie Sipasseuth 2023-05-26 09:25:49 UTC
Ok, sorry, Repro also in this version of LibreOffice

Version: 7.6.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: f4c24da1e7f11664e0d2f688d2531f068e4a3bc0
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: fr-FR (fr_FR); UI: fr-FR
Calc: CL threaded