Bug 139537 - Image drops out of frame when moving image & caption frame to certain spot
Summary: Image drops out of frame when moving image & caption frame to certain spot
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.4.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: DOCX-Textbox
  Show dependency treegraph
 
Reported: 2021-01-11 12:21 UTC by Telesto
Modified: 2023-06-08 15:45 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file (1.16 MB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2021-01-11 12:22 UTC, Telesto
Details
Screencast (310.34 KB, video/mp4)
2021-01-11 12:22 UTC, Telesto
Details
The original document in Writer after pulling the second image a bit right (260.21 KB, image/png)
2021-02-08 09:18 UTC, NISZ LibreOffice Team
Details
Screencast (320.35 KB, video/mp4)
2021-02-08 15:09 UTC, Telesto
Details
Example file (1.16 MB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2021-02-08 15:10 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2021-01-11 12:21:46 UTC
Description:
Image drops out of frame when moving image & caption frame to certain spot

Steps to Reproduce:
1. Open the attached file
2. Drag the image as in screencast

Actual Results:
Image & caption frame seperaed

Expected Results:
Not so


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.2.0.0.alpha0+ (x64)
Build ID: f2171af6ce3516598d9f8bac8294025a21a5b1a2
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2021-01-11 12:22:01 UTC
Created attachment 168815 [details]
Example file
Comment 2 Telesto 2021-01-11 12:22:29 UTC
Created attachment 168816 [details]
Screencast
Comment 3 Telesto 2021-01-11 12:23:51 UTC
Based on recent history..
Comment 4 Telesto 2021-01-11 12:25:08 UTC
Also in
Version: 6.2.4.0.0+
Build ID: 5c5eab3522368d6baa7ab6ef1b6c9f5eaaab4fad
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: CL
Comment 5 Telesto 2021-01-11 12:27:02 UTC
Also in 
4.4.7.2

still OK in
Versie: 4.2.0.4 
Build ID: 05dceb5d363845f2cf968344d7adab8dcfb2ba71
Comment 6 Telesto 2021-01-12 22:09:04 UTC
Wrap dysfunction (which later got fixed again, but maybe related
 64c8b13f248fe7ea3808c7f8e62d0d656f170378 is the first bad commit
commit 64c8b13f248fe7ea3808c7f8e62d0d656f170378
Author: Matthew Francis <mjay.francis@gmail.com>
Date:   Sat Mar 14 21:42:08 2015 +0800

    source-hash-d379d18666aa42031359ca8eb34b0021960347ae
    
    commit d379d18666aa42031359ca8eb34b0021960347ae
    Author:     Miklos Vajna <vmiklos@collabora.co.uk>
    AuthorDate: Wed Jun 18 11:57:31 2014 +0200
    Commit:     Miklos Vajna <vmiklos@collabora.co.uk>
    CommitDate: Wed Jun 18 12:09:15 2014 +0200
    
        oox: import WPS shape with text as shape with textbox
    
        This allows having real shapes (like having rounded corners) and complex
        content (like containing a table) at the same time.
    
        WPS shapes are wrappers around drawingML markup in DOCX files, so this
        only affects the DOCX import.
    
        Change-Id: Iad1c1c61233be1c17efa1821e680927aa9587215

:040000 040000 529a5c3ebc7c866c86be0c93a0b6a58ee22501a1 14e07ed25ffce284ed57439d86f382777554d6ee M	opt
Comment 7 Telesto 2021-01-12 22:14:17 UTC
Detaching started with
bibisect-44max$ git bisect good 61a02ce9cb6491b832cffd74c65196133ec769aa is the first bad commit
commit 61a02ce9cb6491b832cffd74c65196133ec769aa
Author: Matthew Francis <mjay.francis@gmail.com>
Date:   Sat Mar 14 22:08:24 2015 +0800

    source-hash-7596e26fd259ce5445212949403e7cd32303b2bd
    
    commit 7596e26fd259ce5445212949403e7cd32303b2bd
    Author:     Miklos Vajna <vmiklos@collabora.co.uk>
    AuthorDate: Tue Jun 24 17:11:25 2014 +0200
    Commit:     Miklos Vajna <vmiklos@collabora.co.uk>
    CommitDate: Tue Jun 24 17:47:40 2014 +0200
    
        Add SwTextBoxHelper::findShapes
    
        It builds a textbox -> shape map, so methods interested to pick the
        shape instead of a shape's textbox can call it and act accordingly if
        their textbox is in the map.
    
        Change-Id: I0f30d64a284eb461f462ed6c0a36c88271153f04

:040000 040000 66d15d46ba19a20eb3b99bed74f33b492299f211 972e5f90a36adfcb690c2a6bfdfe55158f8afa46 M	opt
Comment 8 Xisco Faulí 2021-01-13 19:36:47 UTC
Reproduced in

Version: 7.2.0.0.alpha0+
Build ID: e027a91010a4517cfa907f3d80c9188f026b3823
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 9 Telesto 2021-01-21 15:51:43 UTC Comment hidden (obsolete)
Comment 10 Telesto 2021-01-21 15:52:11 UTC
(In reply to Telesto from comment #9)
> Still around, probably in different form..
> 
> 1. Open the attached file
> 2. Select figure 1
> 3. Drag it to the left (fine with left arrow)
> 
> Frame and image split.. frame going off page

Same happens also when increasing the size of frame 1
Comment 11 NISZ LibreOffice Team 2021-02-08 09:18:49 UTC
Created attachment 169578 [details]
The original document in Writer after pulling the second image a bit right

No repro in nightly version:

Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 3ed9bba283a6a67864c0928186e277240be0d9ba
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: en-US (hu_HU); UI: en-GB
Calc: CL

But repro in slightly older bibisect-7.2:

Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 380ab85b6594a013f34f5e6ec69fb569336bbb48
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL

I suspect the fix to bug #136516 also fixed this.
Comment 12 Telesto 2021-02-08 15:09:28 UTC
Created attachment 169590 [details]
Screencast
Comment 13 Telesto 2021-02-08 15:10:08 UTC
Created attachment 169591 [details]
Example file

Slightly modified example file seen in second screencast
Comment 14 NISZ LibreOffice Team 2021-04-23 12:35:24 UTC
Reproduced in

Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: db1cf111666847ce5ce93d18ae5ae8c29a4c44d6
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: threaded

Pulling Figure 1 makes the image and frame separate from each other.
Comment 15 Gabor Kelemen (allotropia) 2021-05-27 16:32:55 UTC
Strange... I can't reproduce this in the latest bibisect-7.2 master.

https://git.libreoffice.org/core/+/c96c386c5db45dc4d5e358915caad7474e373068

tdf#136516 add positioning to SwTextBoxHelper::syncProperty()

seemed to be the first to fix this problem in February, but then it was somehow broken again per comment #14.

Now it seems to be fixed again since:

https://git.libreoffice.org/core/+/5812fb81013cc124a9b6a0b9912a34cc715fc495

tdf#138782 DOCX import: fix frame positions of old docs

which would be somewhat unrelated by nature.
Comment 16 Justin L 2023-06-08 15:45:24 UTC
(In reply to Gabor Kelemen (allotropia) from comment #15)
> Strange... I can't reproduce this in the latest bibisect-7.2 master.
Still fixed in LO 7.6.

There are oddles of similar reports. Closing this one as fixed.