Bug 139590 - EDITING: Drag and drop doesn't work in editview
Summary: EDITING: Drag and drop doesn't work in editview
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
6.4.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.2.0 target:7.1.1 target:7.0.5
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2021-01-13 16:39 UTC by Xisco Faulí
Modified: 2021-01-26 09:39 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2021-01-13 16:39:45 UTC
Steps to reproduce:
1. Open impress
2. Type "Hello there" in the title
3. Select "there" and drag&drop it to beginning

-> Nothing happens

Reproduced in ( also in X11 )

Version: 7.2.0.0.alpha0+
Build ID: 5adc93a9a9426ef79054751be2904896f787a8a2
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 1 Xisco Faulí 2021-01-13 16:41:34 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=1ef15ad4b5d43ee338909b818b00a468bbc44234

author	Caolán McNamara <caolanm@redhat.com>	2019-06-26 17:15:20 +0100
committer	Caolán McNamara <caolanm@redhat.com>	2019-06-26 21:37:31 +0200
commit 1ef15ad4b5d43ee338909b818b00a468bbc44234 (patch)
tree 3b1523fe91303422f771e39abc8fa007ae092792
parent 8e5982d799e23bee86404f3ccb3aaed524ae9675 (diff)
allow welded drag and drop into editview

Bisected with: bibisect-linux64-6.4

Adding Cc: to Caolán McNamara
Comment 2 Commit Notification 2021-01-22 14:50:02 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/bc9478602d81dcd0a3bbddd8658c1f0d54d10a7a

tdf#139590 Drag and drop doesn't work in SdrObjEditView

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Caolán McNamara 2021-01-22 14:53:33 UTC
fixed in master, backport to 7-1 and 7-0 in gerrit
Comment 4 Commit Notification 2021-01-26 09:39:06 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/0c52361286d11d34544ec0deedc6962103b3e832

tdf#139590 Drag and drop doesn't work in SdrObjEditView

It will be available in 7.1.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2021-01-26 09:39:21 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/a288ce4786665889f39049e551bed38c896a8218

tdf#139590 Drag and drop doesn't work in SdrObjEditView

It will be available in 7.0.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.