Bug 139693 - LISTS: Clear Direct Formatting doesn't remove lists
Summary: LISTS: Clear Direct Formatting doesn't remove lists
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.0.4.2 release
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Clear-Formatting
  Show dependency treegraph
 
Reported: 2021-01-17 07:51 UTC by Dieter
Modified: 2023-05-31 06:42 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
SAmple file with overlapping list styles (11.52 KB, application/vnd.oasis.opendocument.text)
2021-07-14 18:26 UTC, Olivier Hallot
Details
Style inspecto says there is a para direct formatting on list (153.06 KB, image/png)
2021-07-14 18:31 UTC, Olivier Hallot
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dieter 2021-01-17 07:51:00 UTC
Steps to reproduce:
1. Write two or three lines in an new document
2. Select text and press "Toggle Numbered List" button
3. Select text and remove Direct Formatting (Strg + M)

Actual result:
List is still there

Expected result:
List is removed

This leeds to a problem, if you have a paragraph style with a list style (see for example bug 138639)
Comment 1 Dieter 2021-01-17 07:55:10 UTC
cc: Design-Team, because there might be some reasons for the current situation, that I don't know.
Comment 2 Roman Kuznetsov 2021-01-17 09:03:16 UTC
Because lists are always STYLES. And that button enables a List style for selected text. Unfortunately it isn't a style from list's styles list in Sidebar, yes, but some hardcoded list style

NOTABUG
Comment 3 Dieter 2021-01-17 10:52:08 UTC
Roman, thanks for fast reply and explanation. The problem is, that - at least for normal users - it is unclear, that every list has a style. But we have a similar discussion with tables (see bug 107555 comment 15).
Comment 4 Olivier Hallot 2021-07-14 18:25:24 UTC
The issue exist and is very annoying.

The sample file has a list with 3 items. All list items has Parag style "List 1" with list style "Bullet -"

Item 2 and 3 has extra Paragraph direct formatting property "List Style Name" = "List 2" as indicated in the Style Inspector.

Therefore and extra list is applied directly on top of the existing list.

On cleaning the paragraph (Ctrl+M) this extra, direct formatted, applied list is not removed.
Comment 5 Olivier Hallot 2021-07-14 18:26:53 UTC
Created attachment 173583 [details]
SAmple file with overlapping list styles
Comment 6 Olivier Hallot 2021-07-14 18:31:30 UTC
Created attachment 173584 [details]
Style inspecto says there is a para direct formatting on list
Comment 8 Heiko Tietze 2021-07-20 07:15:07 UTC
Clear _direct_ formatting does not clear the list style.
 
If you talk about lists only, the shortcut shift+ctrl+F12 (Numbering Off) comes in handy.

The only enhancement I can think of is a UNO command that purges all formatting, on any level. Except the page style maybe. But I would resolve the request as NAB. No, WF. It's an enhancement since the functionality is correctly implemented.
Comment 9 Heiko Tietze 2021-07-20 07:22:27 UTC
(In reply to Olivier Hallot from comment #6)
> Created attachment 173584 [details]
> Style inspecto says there is a para direct formatting on list

Yes, true. It's a shortcoming from the fact that we do not ship PS with list style. We should add PS "Bullet list" and "Numbered List" with proper assignment of list styles. And as a follow-up I could agree that keeping direct formatted lists should be removed with the clear command.
Comment 10 Mike Kaganski 2021-07-20 07:28:14 UTC
(In reply to Dieter from comment #1)
> ... there might be some reasons for the current situation, that I don't know.

This is completely a UX problem. We have quite a few special-cased exceptions in Clear DF code. I am 100% sure it comes from user demand, where most users do not expect some things cleared when clearing DF... so IMO it all could be changed, IIF UX decides so (and be prepared with negative UX feedback ;-P)
Comment 11 Heiko Tietze 2021-07-23 10:21:53 UTC
Let's add dedicated paragraph styles with bullet and numbered lists first. This should also extend the "Formatting (Styles)" toolbar. And clear the direct formatted lists too when this is done. 

Can do the first part but for the clear formatting I'd need a code pointer at least.