Bug 139768 - The "no fill" checkbox in Highlight Color dialog does not show its actual status
Summary: The "no fill" checkbox in Highlight Color dialog does not show its actual status
Status: RESOLVED NOTABUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
6.3.6.2 release
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: needsUXEval
Depends on:
Blocks: Highlight-Color
  Show dependency treegraph
 
Reported: 2021-01-19 15:57 UTC by sdc.blanco
Modified: 2022-03-27 07:02 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sdc.blanco 2021-01-19 15:57:13 UTC
1. Open Formatting bar
2. Select Highlight Color icon and select some text.
3. Open dropdown menu of Highlight Color and set to "no fill"

Actual result:  The status of the "no fill" checkbox never changes.
               (but color on toolbar changes)

Expected result: Checkbox should correspond to current state 

Additional information

Maybe it is not meant to be a checkbox, but some status indicator would be appropriate and useful.
Comment 1 sdc.blanco 2021-02-03 12:03:33 UTC
Probably the "icon" used with "No Fill" is not a checkbox -- even if it appears so.  

This can be understood by seeing that the same icon is used in Paragraph dialog, Borders Tab, Line section, Style dropdown box. Not a problem in that context, because "None" gets shown in the control when it is selected. 

Here are some observations, finishing with a proposal sketch.

1.  The "No Fill" box seems to always have a dotted border, no matter whether it is selected or a colour is selected.

2.  While the "empty" colour on the Toolbar is supposed to signal "no fill", try to choose "white" or some lighter grey colour, and see how it looks on toolbar.

3.  "Font Color"  has a similar situation (and same icon). 

4.  Admittedly, not a serious disrupter in workflow. But it was confusing to see what looked like a "checkbox" , only to discover that it could not be "checked" or unchecked. 

Hmmm.....could it work to make a real checkbox in the Character Highlighting dialog?  and maybe a cross-hatch:   ////  or xxxx  in the toolbar when "no fill" is selected?
Comment 2 Harshita Nag 2021-05-19 03:25:59 UTC
CONFIRMED on Ubuntu 18.04 LTS and LibreOffice 6.0.0.3


Version: 6.0.0.3
Build ID: 64a0f66915f38c6217de274f0aa8e15618924765
CPU threads: 8; OS: Linux 5.3; UI render: default; VCL: gtk2; 
Locale: en-IN (en_IN); Calc: group
Comment 3 Harshita Nag 2021-05-19 03:28:45 UTC
CONFIRMED on Ubuntu 18.04 LTS and LibreOffice 6.4.7.2

Version: 6.4.7.2
Build ID: 639b8ac485750d5696d7590a72ef1b496725cfb5
CPU threads: 8; OS: Linux 5.3; UI render: default; VCL: gtk3; 
Locale: en-IN (en_IN); UI-Language: en-US
Calc: threaded
Comment 4 Harshita Nag 2021-05-19 03:31:20 UTC
CONFIRMED on Ubuntu 18.04 LTS and LibreOffice 7.0.5.2

Version: 7.0.5.2
Build ID: 64390860c6cd0aca4beafafcfd84613dd9dfb63a
CPU threads: 8; OS: Linux 5.3; UI render: default; VCL: gtk3
Locale: en-IN (en_IN); UI: en-US
Calc: threaded
Comment 5 Harshita Nag 2021-05-19 03:33:58 UTC Comment hidden (obsolete)
Comment 6 Harshita Nag 2021-05-19 03:37:08 UTC
Doesn't happen in 7.1.2.2 

Version: 7.1.2.2 / LibreOffice Community
Build ID: 8a45595d069ef5570103caea1b71cc9d82b2aae4
CPU threads: 8; OS: Linux 5.3; UI render: default; VCL: gtk3
Locale: en-IN (en_IN); UI: en-US
Calc: threaded
Comment 7 Harshita Nag 2021-05-21 07:30:33 UTC Comment hidden (obsolete)
Comment 8 Harshita Nag 2021-05-21 07:31:26 UTC
(In reply to Harshita Nag from comment #6)
> Doesn't happen in 7.1.2.2 
> 
> Version: 7.1.2.2 / LibreOffice Community
> Build ID: 8a45595d069ef5570103caea1b71cc9d82b2aae4
> CPU threads: 8; OS: Linux 5.3; UI render: default; VCL: gtk3
> Locale: en-IN (en_IN); UI: en-US
> Calc: threaded

As this bug is not in the fresh version, I will be closing it as RESOLVED WORKSFORME.
Comment 9 Telesto 2021-05-21 07:50:42 UTC
I'm not seeing any reason for WFM. It's still the same as described as far I can tell.
Version: 7.2.0.0.alpha1+ (x64) / LibreOffice Community
Build ID: 05366b8e6683363688de8708a3d88cf144c7a2bf
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

Something else is the opinion what the ideal situation would be or the current being as good as it gets.. I'm not any big feeling here.. 

But well we have UX for that type of question 

Note: I do have issues with 'reverting' back. So Enabling highlighting and "No Fill' not being the same as 'revert to state before highlighting'. 

So the topic brought up in relation to 'bold/unbold' not being the same (in perspective of styles). So lack of true 'toggle off'. But well that obviously not limited to highlighting. [And more problematic to solve]
Comment 10 Heiko Tietze 2021-05-25 09:05:58 UTC
Color picker do not indicate the state, we had this discussion frequently in the past. It rather keeps the last used color and allows by that to easily apply that color to other places. Imagine the marker workflow: you want to highlight parts while skimming through of the text. And every time you select something the picker switches back to "No Fill".