Bug 139781 - Community/Enterprise flavor breaks the StartCenter
Summary: Community/Enterprise flavor breaks the StartCenter
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.1.0.1 rc
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.2.0 target:7.1.1
Keywords: bibisectNotNeeded, regression
: 139640 139988 140043 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-01-20 10:46 UTC by Jean-Baptiste Faure
Modified: 2021-02-04 14:39 UTC (History)
11 users (show)

See Also:
Crash report or crash signature:


Attachments
7.0.4.2 vs 7.1.0.2 (243.29 KB, image/png)
2021-01-20 14:51 UTC, Xisco Faulí
Details
startcenter with "replacement icons" (239.94 KB, image/png)
2021-01-20 15:48 UTC, Jean-Baptiste Faure
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Baptiste Faure 2021-01-20 10:46:35 UTC
Description:
Since the commit https://git.libreoffice.org/core/commit/bd319954e82da64d1ca037df2f32982af6ddb0e2 the startcenter is missing the 4 first icons (Open File, Remote Files, Recent Documents and Templates). It's ok in master.

Steps to Reproduce:
1. Launch LO 7.1.1.0.0+
2. Look at the StartCenter
3.

Actual Results:
4 icons are missing

Expected Results:
0 icons missing


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Already reported in bug 139343 for Ubuntu 18.04 :
https://bugs.documentfoundation.org/show_bug.cgi?id=139343#c7
Confirmed for Windows 7:
https://bugs.documentfoundation.org/show_bug.cgi?id=139343#c8
Comment 1 Heiko Tietze 2021-01-20 10:56:13 UTC
Seeking confirmation (actually the real cause) since I didn't touch the icons with https://gerrit.libreoffice.org/c/core/+/108980
Comment 2 Rizal Muttaqin 2021-01-20 13:45:13 UTC
Confirmed with 

Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: 56f26399df894d05f24874a3cdc90694158e03bc
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: kf5
Locale: id-ID (id_ID.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-01-16_03:41:06
Calc: threaded

Strangely, after installing icon by .zip file the icon came back (at least for elementary theme). I even checked icon-themes/elementary/framework/res directory and  the icon files are there, not deleted.

Only Sukapura icon theme which still show Open File, Remote Files and Templates (Recent Documents lost) while all other icon themes show nothing.
Comment 3 Telesto 2021-01-20 14:00:30 UTC
FWIW:
No icons in Master for me
Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 2081eac430ac69619149e44b453a2d7dda41fc83
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 4 Xisco Faulí 2021-01-20 14:39:18 UTC
Not reproducible in

Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: 4e1294b7d6f8de981147f15d4ca1b4e4853249eb
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

I'm wondering if it's a problem with the daily builds...
Comment 5 Xisco Faulí 2021-01-20 14:51:17 UTC
Created attachment 169053 [details]
7.0.4.2 vs 7.1.0.2

ok, so it's happening with the official builds as well
Comment 6 V Stuart Foote 2021-01-20 15:31:49 UTC
Seen on 2021-01-20 TB77 Windows daily, changing icon theme(s) does not restore.

Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 6ee7a3b2c0565c2871d32d704cb2899445b9f88d
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded
Comment 7 Xisco Faulí 2021-01-20 15:39:10 UTC
Not reproducible in

Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 45e8dcec908878c07e3835fde7aa9db754d45ace
CPU threads: 16; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: en-GB (en_GB); UI: en-US
Calc: threaded

(bisect repositories)
Comment 8 Jean-Baptiste Faure 2021-01-20 15:44:28 UTC
Did not test again on master when filing this bug report, but now I reproduce with master built at home last night :

Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: 6ee7a3b2c0565c2871d32d704cb2899445b9f88d
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3
Locale: fr-FR (fr_FR.UTF-8); UI: en-US
Ubuntu_18.04_x86-64
Calc: threaded

Best regards. JBF
Comment 9 Jean-Baptiste Faure 2021-01-20 15:48:40 UTC
Created attachment 169055 [details]
startcenter with "replacement icons"
Comment 10 BogdanB 2021-01-20 17:26:02 UTC
*** Bug 139640 has been marked as a duplicate of this bug. ***
Comment 11 Hussam Al-Tayeb 2021-01-20 17:37:28 UTC
On my computer:
https://bugs.documentfoundation.org/attachment.cgi?id=168909

Version: 7.2.0.0.alpha0+
Build ID: 61f5add790fad40b1e3f7a3a45b96d52f784f69c
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: CL
Comment 12 Jean-Baptiste Faure 2021-01-22 08:51:40 UTC
bibisectRequest: useless. Read the description.

Best regards. JBF
Comment 13 Maxim Monastirsky 2021-01-28 09:27:28 UTC
I gave it a try with https://gerrit.libreoffice.org/c/core/+/110048.
Comment 14 Commit Notification 2021-01-28 11:05:47 UTC
Maxim Monastirsky committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ed28902e2d2b8929617c92226be985e322147569

tdf#139781 Handle also "icon-name" property name

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 15 Maxim Monastirsky 2021-01-28 11:35:42 UTC
It appears that editing startcenter.ui with glade 3.38.2 changed all "icon_name" properties into "icon-name" (hyphen instead of underscore), and icons defined like that weren't packaged into icons zip files. I added handling for "icon-name", so everything should be back to normal now. Note that this doesn't affect just the start center - e.g. the paste special dialog in Calc was also affected.

Also note that people doing incremental builds might not see the bug, unless they do 'make clean' or at least 'rm -r workdir/UIImageListTarget'.
Comment 16 Heiko Tietze 2021-01-28 12:10:47 UTC
(In reply to Maxim Monastirsky from comment #15)
> Also note that people doing incremental builds might not see the bug, unless
> they do 'make clean' or at least 'rm -r workdir/UIImageListTarget'.

This was likely the reason why I've never seen a problem. Guess it's fixed now.

Caolan, for your info (solved glade unscore hyphen issue).
Comment 17 Commit Notification 2021-01-28 16:56:09 UTC
Maxim Monastirsky committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/9fb11584425d692136c3c83d4e02a78432738f6b

tdf#139781 Handle also "icon-name" property name

It will be available in 7.1.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 18 Maxim Monastirsky 2021-01-29 10:02:49 UTC
*** Bug 139988 has been marked as a duplicate of this bug. ***
Comment 19 Rizal Muttaqin 2021-01-30 07:59:44 UTC
Verified fixed in

Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: b7175495249958c430e16c0bad358eee0032b65a
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: kf5
Locale: id-ID (id_ID.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-01-28_20:31:16
Calc: threaded
Comment 20 Ming Hua 2021-02-01 00:45:55 UTC
*** Bug 140043 has been marked as a duplicate of this bug. ***
Comment 21 Adolfo Jayme Barrientos 2021-02-04 13:33:37 UTC
It’s such a pity that release management refused to respin 7.1.0 for this; this kind of issues greatly impact our product image.
Comment 22 Rizal Muttaqin 2021-02-04 13:37:57 UTC
(In reply to Adolfo Jayme from comment #21)
> It’s such a pity that release management refused to respin 7.1.0 for this;
> this kind of issues greatly impact our product image.

Yes, an at-your-face UI bug will question QA task force also.
Comment 23 Telesto 2021-02-04 14:39:38 UTC
(In reply to Rizal Muttaqin from comment #22)
> (In reply to Adolfo Jayme from comment #21)
> > It’s such a pity that release management refused to respin 7.1.0 for this;
> > this kind of issues greatly impact our product image.
> 
> Yes, an at-your-face UI bug will question QA task force also.

This is many ways horrible. 
* it makes Quality Control/ Quality Assurance bit of joke; can't even avoid this, seriously
* Another flow of bug reports.. 
* Bad for product experience/ product image/ branding (marketing)

But OK we are now a community project.. Why should Enterprises not use Community.. well..

And what's the reason we can't do a silent respin? Fixed release schedule? Rolling, Rolling Release please..