Bug 139803 - highlight and font colours are always reset to defaults (after print preview) without asking!
Summary: highlight and font colours are always reset to defaults (after print preview)...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
3.6.0.4 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, regression
Depends on:
Blocks: Split-Group-Buttons-Color Highlight-Color
  Show dependency treegraph
 
Reported: 2021-01-21 07:11 UTC by Quintao
Modified: 2022-03-27 07:02 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Quintao 2021-01-21 07:11:31 UTC
Description:
When entering print preview and then returning to edit view, the highlight and font colours are always reset to defaults (yellow highlight/red font).

Which is not helpful in my opinion, as I often use a set font/hihlight for marking areas to check and switch between the print preview and edit windows to find these highlights.

Steps to Reproduce:
1.Select text and change font to blue/highlight to Pink
2.open print preview
3.close print preview

Actual Results:
highlight and font colours are reset to yellow highlight/red font

Expected Results:
I would expect my last chosen colours to remain active, ie. the blue font and pink highlight I used.


Reproducible: Always


User Profile Reset: No



Additional Info:
V 7.1.0.2rc
Linux 4.9
UI default, gtk3
Comment 1 Telesto 2021-01-21 21:25:00 UTC
Confirm
Version: 7.1.0.0.alpha1+
Build ID: c784b3da15102caf1022e83371863a86766e69cd
CPU threads: 4; OS: Mac OS X 10.12.6; UI render: default; VCL: osx
Locale: nl-NL (nl_NL.UTF-8); UI: en-US
Calc: threaded
Comment 2 Telesto 2021-01-24 08:03:52 UTC
Also in
4.4.7.2

and in
Versie 4.0.0.3 (Bouw-id: 7545bee9c2a0782548772a21bc84a9dcc583b89)


but not in
LibreOffice 3.5.7.2 
Build ID: 3215f89-f603614-ab984f2-7348103-1225a5b
Comment 3 Justin L 2021-01-25 09:01:01 UTC
Using Linux's bibisect43all, I cleanly narrowed it down to LO 3.6 with the single bibisect commit d202b17d88ecb0b608d81518624021c832c7dfdb. Unfortunately, the next bibisect commit was two months later, so the range is huge.

https://cgit.freedesktop.org/libreoffice/core/log/?id=1efeb17837c22499f00299c033ae59ba3910f7d7&qt=range&q=43c7830b03d141ae11d8617c0fdabefa32dd243c..ce97851773a06103504972eb2771eecd7dd81e36
Comment 4 Justin L 2021-01-25 13:50:25 UTC
It appears that the toolbar is thrown away during print preview, and re-created again from defaults. Perhaps somehow it could be saved and re-used?

Otherwise, to accomplish what OP is asking for would require a fairly radical re-design of these widgets. Currently there is no tracking value for each button. They share a common recent colour set - but since it is common we have no idea which button to apply it to - so taking the most recent colour would make it the same for both font colour and font highlight.

A key function here is PaletteManager::ReloadRecentColorSet which loads
officecfg::Office::Common::UserColors::RecentColor::get().

Don't hold your breath for this - it would end up affecting ~everything. Better to find a different work flow - perhaps reducing the zoom to 25% and then back to 100%.
Comment 5 Quintao 2021-02-08 04:21:06 UTC
Hmmm, I see, so just zoom out scroll about and zoom in again... that's not difficult actually.

What about the Preview pops up a s a floating window instead of replacing the prog window? would that create a nightmare for programming?