Bug 139982 - EDITING: Image anchored "To Character" inside misspelled word is removed when word is corrected with Spell checking and track changes enabled
Summary: EDITING: Image anchored "To Character" inside misspelled word is removed when...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.4.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Michael Stahl (allotropia)
URL:
Whiteboard: target:7.5.0 target:7.4.0.0.beta2 tar...
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Anchor-and-Text-Wrap Spell-Checking Track-Changes-Image
  Show dependency treegraph
 
Reported: 2021-01-28 20:55 UTC by Xisco Faulí
Modified: 2022-08-10 19:41 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments
sample file (16.05 KB, application/vnd.oasis.opendocument.text)
2021-01-28 20:55 UTC, Xisco Faulí
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2021-01-28 20:55:42 UTC
Created attachment 169251 [details]
sample file

This is a follow-up of bug 131912

Steps to reproduce:
1. Open the attached document
2. Correct the misspelled word

-> The image disappears.

Reproduced in

Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: f2389a70da606768a39ee599de6a5b24058734aa
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: zh-TW (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 1 Xisco Faulí 2021-01-28 21:00:07 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=28b77c89dfcafae82cf2a6d85731b643ff9290e5

author	Michael Stahl <Michael.Stahl@cib.de>	2019-07-11 18:37:28 +0200
committer	Michael Stahl <Michael.Stahl@cib.de>	2019-07-22 08:32:07 +0200
commit 28b77c89dfcafae82cf2a6d85731b643ff9290e5 (patch)
tree 4d26e493cebd1d83025094a3a97b9e878bc2b930
parent 22f2ecbcabf3928d5486690ca6465b7b37bc8a10 (diff)
tdf#117185 tdf#110442 sw: bring harmony & peace to fly at-char selection

Bisected with: bibisect-linux64-6.4

Adding Cc: to Michael Stahl
Comment 2 Michael Stahl (allotropia) 2022-06-13 15:59:29 UTC
fixed on master
Comment 3 Commit Notification 2022-06-13 15:59:47 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/646c6ddd91a98afddf914e3889cb269fc814c060

tdf#139982 sw: preserve flys in Replace with redlining enabled

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2022-06-14 12:25:45 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/f3093d19db98ad06b7bc92ca193682d6292aa4ea

tdf#139982 sw: preserve flys in Replace with redlining enabled

It will be available in 7.4.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2022-06-15 22:10:05 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/b7ab83bd96c70932c2223c8d0b3bc0f24327cef2

tdf#139982 sw: preserve flys in Replace with redlining enabled

It will be available in 7.3.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Gabor Kelemen (allotropia) 2022-08-10 19:41:05 UTC
Verified in

Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 4e2ce2a460458f17ee4360c45a2da2fc4b4d753e
CPU threads: 14; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: en-US (hu_HU); UI: en-US
Calc: threaded

Selecting a spell check suggestion from the popup menu does not remove the image.