Bug 139988 - Some icons are missing in template manager
Summary: Some icons are missing in template manager
Status: RESOLVED DUPLICATE of bug 139781
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
7.2.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.2.0
Keywords:
Depends on:
Blocks:
 
Reported: 2021-01-29 01:54 UTC by Rizal Muttaqin
Modified: 2021-01-29 10:02 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Karasa Jaga has no icons for Move, Export and Import (72.42 KB, image/png)
2021-01-29 01:54 UTC, Rizal Muttaqin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rizal Muttaqin 2021-01-29 01:54:40 UTC
Created attachment 169254 [details]
Karasa Jaga has no icons for Move, Export and Import

Some action icons in Template Manager lost, even though the file(s) or the definition in links.txt are there.

Step to reproduce
1. Open Template Manager (File > New > Templates)
2. See the action icons 

Breeze, elementary, Karasa Jaga, Sifr, Sukapura has no icon for Move while Karasa Jaga fall backed to Colibre for Export and Import icon

Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: 91029cb6ed0413bff5cdea79153c8477406b88b7
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: kf5
Locale: id-ID (id_ID.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-01-27_06:12:11
Calc: threaded
Comment 1 Rizal Muttaqin 2021-01-29 02:11:44 UTC
I am  sure this Move icons used to be sfx2/res/actiontemplates017.png file and other than Sifr, every theme has the icon.

For Karasa Jaga, the icons for Export and Import are not defined in links.txt, instead it has actiontemplates020.png for Export and actionview010.png for import. While other icons than Sifr placed them in links.txt. It's a bit strange why a real file can't even be read
Comment 2 Rizal Muttaqin 2021-01-29 02:16:25 UTC
@Maxim, could this have something to do with Glade? Similar to what's happen with tdf#139781 (https://bugs.documentfoundation.org/show_bug.cgi?id=139781)?

I can not see something wrong in /core/sfx2/uiconfig/ui/templatedlg.ui
Comment 3 Commit Notification 2021-01-29 07:42:13 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/977f66ccd6161da8ec37d4eac0f85515e0cf1df0

KJ: tdf#139988: make Export and Import icon in Template Manager show up

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Maxim Monastirsky 2021-01-29 10:02:49 UTC
(In reply to Rizal Muttaqin from comment #2)
> @Maxim, could this have something to do with Glade? Similar to what's happen
> with tdf#139781 (https://bugs.documentfoundation.org/show_bug.cgi?id=139781)?
Yes it is. Should be fixed with my commit, please try with a newer build. No changes are required from your side.

*** This bug has been marked as a duplicate of bug 139781 ***