Bug 140023 - Screen quality of low res images bad; Skia (fine with GDI)
Summary: Screen quality of low res images bad; Skia (fine with GDI)
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.2.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.2.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Skia
  Show dependency treegraph
 
Reported: 2021-01-30 15:03 UTC by Telesto
Modified: 2021-02-08 12:31 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file (48.53 KB, application/vnd.oasis.opendocument.text)
2021-01-30 15:03 UTC, Telesto
Details
canvas rendered with Skia Vulkan (75.77 KB, image/png)
2021-01-30 18:34 UTC, V Stuart Foote
Details
canvas rendered with default GDI (314.01 KB, image/png)
2021-01-30 18:37 UTC, V Stuart Foote
Details
canvas rendered with Skia raster (75.94 KB, image/png)
2021-01-30 18:46 UTC, V Stuart Foote
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2021-01-30 15:03:21 UTC
Description:
Screen quality of low res images bad; Skia (fine with GDI)

Steps to Reproduce:
1. Open the attached file
2. Compare with GDI or older version

Actual Results:
Pixelated

Expected Results:
Smooth


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 66013201749df7d5ac5ddaf377a7b3732518a93b
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2021-01-30 15:03:49 UTC
Created attachment 169303 [details]
Example file
Comment 2 Telesto 2021-01-30 15:05:18 UTC
Still OK with
Version: 7.1.0.0.beta1+ (x64)
Build ID: f9fab4203c1aa0b9a3f27ce2713b6d5addc7df19
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: nl-NL
Calc: CL
Comment 3 V Stuart Foote 2021-01-30 18:34:52 UTC
Created attachment 169310 [details]
canvas rendered with Skia Vulkan
Comment 4 V Stuart Foote 2021-01-30 18:37:25 UTC
Created attachment 169311 [details]
canvas rendered with default GDI

Confirm a noticeable degradation with Skia rendering of raster images

testing Windows 10
RenderMethod: vulkan
Vendor: 0x8086
Device: 0x5916
API: 1.2.151
Driver: 0.402.591
DeviceType: integrated
DeviceName: Intel(R) HD Graphics 620
Denylisted: no


Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 66013201749df7d5ac5ddaf377a7b3732518a93b
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded
Comment 5 V Stuart Foote 2021-01-30 18:46:25 UTC
Created attachment 169312 [details]
canvas rendered with Skia raster

For completeness here is the canvas with Skia raster only rendering, the same.
Comment 6 NISZ LibreOffice Team 2021-02-04 08:46:39 UTC
Just checked that this started with the same commit as my bug #140129 :

Bibisected using bibisect-win64-7.2 to:
URL: https://cgit.freedesktop.org/libreoffice/core/commit/?id=2cf9b8e265e9694803f55e30f2f392abfa512a5a 

author
Luboš Luňák <l.lunak@collabora.com> Mon Jan 18 19:38:03 2021 +0100 
committer
Luboš Luňák <l.lunak@collabora.com> Wed Jan 20 11:55:23 2021 +0100 

update Skia to chrome/m89
Comment 7 NISZ LibreOffice Team 2021-02-04 08:46:55 UTC
*** Bug 140129 has been marked as a duplicate of this bug. ***
Comment 8 Commit Notification 2021-02-08 12:30:19 UTC
Luboš Luňák committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0a76b8ebbaf934faad27ddb3a4e951b9c743e536

Revert "update Skia to chrome/m89" (tdf#140023)

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Luboš Luňák 2021-02-08 12:31:51 UTC
I have reverted back to chrome/m88. I'll try again when the next milestone comes out again in about a month, there will be further API changes related to this, so I'll take a deeper look at this then.