Description: Undo to change of 'as character' produces wrong results Steps to Reproduce: 1. Open the attached file 2. Save as DOCX 3. Select frame figure 1 4. Change anchor to 'as character' 5. Undo Actual Results: Somewhere in the document Expected Results: Old position Reproducible: Always User Profile Reset: No Additional Info: Found in 7.2 and in Version: 7.1.0.0.beta1+ (x64) Build ID: f9fab4203c1aa0b9a3f27ce2713b6d5addc7df19 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: nl-NL Calc: CL and in Version: 7.0.0.0.beta1+ (x64) Build ID: 2891e91a513520d68ea2b8c59c14335861a15253 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL and in 6.2 and in Versie: 4.4.7.2 Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600 Locale: nl_NL Looks ok with (again different layout.., but undo does work) Versie: 4.2.0.4 Build ID: 05dceb5d363845f2cf968344d7adab8dcfb2ba71
Created attachment 169356 [details] Example file
Likely already reported.. but well everything looks the same.. but sometimes it slightly different after all
Still present Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 3ed9bba283a6a67864c0928186e277240be0d9ba CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL
Created attachment 169611 [details] Screenshot of the original document and its docx version side by side in Writer The frames horizontal and vertical positioning survives saving to docx...
Created attachment 169612 [details] Screenshot of the original document and its docx version after changing anchoring and undoing it in Writer ...but not a change to anchor type and undoing it in: Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 44b914b1e2616ca8f70e896e653a46ca93610234 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win Locale: en-US (hu_HU); UI: en-GB Calc: CL
Looks good to me, please retest Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 8279d89d6e037def78f50c72fab2116ca56bef52 CPU threads: 4; OS: Linux 5.13; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded Jumbo
(In reply to raal from comment #6) Still repro Steps to Reproduce: 1. Open the attached file 2. Save as DOCX 2. File reload (Lacking in Comment 0) 3. Select frame figure 1 4. Change anchor to 'as character' 5. Undo Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 4659fc2f0a7223a89446edff0b77e58758b5edf5 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: en-US (nl_NL); UI: en-US Calc: CL
This seems to have begun at the below commit in bibisect repository/OS bibisect-44max. Adding Cc: to Miklos Vajna; Could you possibly take a look at this one? Not sure if bibisect is 100% correct, because layout in 4.4 is different, but undo works. Thanks 61a02ce9cb6491b832cffd74c65196133ec769aa is the first bad commit commit 61a02ce9cb6491b832cffd74c65196133ec769aa Author: Matthew Francis <mjay.francis@gmail.com> Date: Sat Mar 14 22:08:24 2015 +0800 source-hash-7596e26fd259ce5445212949403e7cd32303b2bd commit 7596e26fd259ce5445212949403e7cd32303b2bd Author: Miklos Vajna <vmiklos@collabora.co.uk> AuthorDate: Tue Jun 24 17:11:25 2014 +0200 Commit: Miklos Vajna <vmiklos@collabora.co.uk> CommitDate: Tue Jun 24 17:47:40 2014 +0200 Add SwTextBoxHelper::findShapes It builds a textbox -> shape map, so methods interested to pick the shape instead of a shape's textbox can call it and act accordingly if their textbox is in the map. Change-Id: I0f30d64a284eb461f462ed6c0a36c88271153f04
Miklos Vajna committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/5a25d9252791409f5e73616ff752a9ae8227aaf7 tdf#140066 sw: fix bad position of textbox after anchor type change + undo It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.