Bug 140086 - LO will many times the master password for open or save action an a remote server (webdav)
Summary: LO will many times the master password for open or save action an a remote se...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: framework (show other bugs)
Version:
(earliest affected)
7.1.0.2 rc
Hardware: All All
: medium normal
Assignee: Michael Stahl (allotropia)
URL:
Whiteboard: target:7.3.0 target:7.2.5
Keywords: bibisected, bisected, regression
: 140310 140438 141086 144517 (view as bug list)
Depends on:
Blocks: WebDAV
  Show dependency treegraph
 
Reported: 2021-02-02 09:51 UTC by Dr. Fred Albrecht
Modified: 2021-12-06 13:28 UTC (History)
13 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dr. Fred Albrecht 2021-02-02 09:51:48 UTC
Description:
LO 7.1.0.2 linux 64 bit (opensuse 15.2) german

open or save on a remote server 2 times the LO will have the master password for every step in the filebrowser

If I start from dolphin only one master password is necessary

Steps to Reproduce:
1. start LO
2. open/save remote file
3. masterpasword-dialog 2 times
4. every change directory masterpasword-dialog 2 times
.

n. open or save the file

Actual Results:
Kennwort eingeben

Expected Results:
only one ask for master password


Reproducible: Always


User Profile Reset: No



Additional Info:
I dont know
Comment 1 Roberto Balutsos 2021-03-04 15:48:35 UTC
The same bug also on windows
Comment 2 Christoph Schultz 2021-07-01 19:04:55 UTC
can confirm that bug, on my mashine LO 7.1 Windows 10 64-bit, I will be asked many times before I'm able to access or store datas on my owncloud.
Comment 3 Dieter 2021-07-02 09:47:48 UTC
*** Bug 140310 has been marked as a duplicate of this bug. ***
Comment 4 Dieter 2021-07-02 09:52:56 UTC
(In reply to Christoph Schultz from comment #2)
> can confirm that bug, on my mashine LO 7.1 Windows 10 64-bit, I will be
> asked many times before I'm able to access or store datas on my owncloud.

Christoph, if you can reproduce the bug, you are allowed to chhange status to NEW.

=> NEW because of comment 2
Comment 5 mala 2021-08-24 21:22:06 UTC
Hello, i checked some versions using ubuntu 21.04 64bit

error-description:
Libreoffice calc, function "save remote", connection with webdav to an owncloud server works not as described. Masterpassword will be requested during browsing through the directories. Each directory change causes a request of the Password.

expectation: Masterpassword should only requested one time

version x64 - error appears
6.4.7.2 - no
7.0.0.1 - no
7.0.6.2 - no
7.1.0.1 - yes
7.1.5.2 - yes
7.2.0   - yes
Comment 6 Buovjaga 2021-08-26 07:48:03 UTC
For those who can reproduce, you could try bisecting the problem with the 7.1 repository:
https://wiki.documentfoundation.org/QA/Bibisect/Linux
https://wiki.documentfoundation.org/QA/Bibisect/Windows
Comment 7 Gabor Kelemen (allotropia) 2021-11-18 16:38:06 UTC
Bibisected with linux-7.1 to:

https://git.libreoffice.org/core/+/7256ff08bc46840bb85fa255ace6541dca91329e

author	Noel Grandin <noelgrandin@gmail.com>	Mon Jul 13 22:30:36 2020 +0200
committer	Noel Grandin <noel.grandin@collabora.co.uk>	Tue Jul 14 18:31:18 2020 +0200

svl/passwordcontainer: create instances with uno constructors

Adding CC to: Noel Grandin
Comment 8 Gabor Kelemen (allotropia) 2021-11-18 16:42:28 UTC
*** Bug 141086 has been marked as a duplicate of this bug. ***
Comment 9 Commit Notification 2021-11-18 20:13:36 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/dd43c74ee5778109f860e18419fc37fd9ab1c7dd

tdf#140086 svl: restore PasswordContainer to single-instance

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Gabor Kelemen (allotropia) 2021-11-18 22:24:27 UTC
*** Bug 144517 has been marked as a duplicate of this bug. ***
Comment 11 Christoph Schultz 2021-11-18 23:57:15 UTC
I tested the Bug with LibreOfficeDev_7.3.0.0_alpha1_x64, from master/Win_x86_64@tb77-TDF. and LO will ask me always 2 times for the masterpassword if I go to an WebDAV Server and also I dive into a directory.
Comment 12 Commit Notification 2021-11-19 03:53:17 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/67d8c6ecb3873a8dfc789221764d7688596f09cc

tdf#140086 svl: restore PasswordContainer to single-instance

It will be available in 7.2.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 Aron Budea 2021-11-19 05:45:11 UTC
(In reply to Christoph Schultz from comment #11)
> I tested the Bug with LibreOfficeDev_7.3.0.0_alpha1_x64, from
> master/Win_x86_64@tb77-TDF. and LO will ask me always 2 times for the
> masterpassword if I go to an WebDAV Server and also I dive into a directory.
The latest build there is from 2021-11-18 06:28:59, which is before the fix, please try again with the next one.
Comment 14 Christoph Schultz 2021-11-20 09:02:19 UTC
I tested it now with the current build (20.11.21 04:14:48) and it works fine.
Comment 15 Michael Stahl (allotropia) 2021-11-22 15:53:11 UTC
*** Bug 140438 has been marked as a duplicate of this bug. ***
Comment 16 Christian Lohmaier 2021-12-06 13:28:48 UTC
7.2.4 was a hotfix release, updating target in status-whiteboard