Bug 140129 - FILEOPEN DOCX PNG image rendered ugly with Skia
Summary: FILEOPEN DOCX PNG image rendered ugly with Skia
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: filters and storage (show other bugs)
Version:
(earliest affected)
7.2.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.2.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Skia
  Show dependency treegraph
 
Reported: 2021-02-03 15:39 UTC by NISZ LibreOffice Team
Modified: 2021-06-10 11:41 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Example file from Word with PNG image (65.22 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2021-02-03 15:39 UTC, NISZ LibreOffice Team
Details
Screenshot of the original document side by side in Word and Writer (179.87 KB, image/png)
2021-02-03 15:40 UTC, NISZ LibreOffice Team
Details
The example file in Writer after upgrade to chrome/m90 (139.07 KB, image/png)
2021-03-23 08:47 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description NISZ LibreOffice Team 2021-02-03 15:39:32 UTC
Created attachment 169440 [details]
Example file from Word with PNG image

Attached file has a PNG logo that started to render quite ugly with Skia enabled.

Steps to reproduce:
    1. Open attached file

Actual results:
Image looks washed out.

Expected results:
Sharp image.

LibreOffice details:
Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 318d384c596c1593667d6c936f55bf6ebd0c5db6
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: en-US (hu_HU); UI: en-GB
Calc: CL

Looks good without Skia.

Additional Information: 

Bibisected using bibisect-win64-7.2 to:
URL: https://cgit.freedesktop.org/libreoffice/core/commit/?id=2cf9b8e265e9694803f55e30f2f392abfa512a5a 

author
Luboš Luňák <l.lunak@collabora.com> Mon Jan 18 19:38:03 2021 +0100 
committer
Luboš Luňák <l.lunak@collabora.com> Wed Jan 20 11:55:23 2021 +0100 

update Skia to chrome/m89

Adding CC to: Luboš Luňák
Comment 1 NISZ LibreOffice Team 2021-02-03 15:40:07 UTC
Created attachment 169441 [details]
Screenshot of the original document side by side in Word and Writer
Comment 2 NISZ LibreOffice Team 2021-02-04 08:46:55 UTC

*** This bug has been marked as a duplicate of bug 140023 ***
Comment 3 NISZ LibreOffice Team 2021-03-23 08:45:36 UTC
This came back with:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=ad8bff9d2625524999871ace65cfe0382f991f24

update Skia to chrome/m90
Comment 4 NISZ LibreOffice Team 2021-03-23 08:47:55 UTC
Created attachment 170650 [details]
The example file in Writer after upgrade to chrome/m90

Note: the example file of bug #140023 looks good in this version, so after all this is a separate issue.

Also present in yesterdays nightly:

Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 78c33a4c3d1633b97049874305b3b49b820395a2
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: CL
Comment 5 Commit Notification 2021-04-12 13:06:32 UTC
Luboš Luňák committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8043fe3e45c8999c8eaf475ba46d50b125e38b93

use Skia linear+mipmap for quality large downscaling (tdf#140129)

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 NISZ LibreOffice Team 2021-06-10 11:41:50 UTC
Verified in:
Version: 7.2.0.0.alpha1+ (x64) / LibreOffice Community
Build ID: aa9cb8e14749e7fb7a83b55a2bb095501f731a18
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: threaded