Description: Undo doesn't restore original layout (DOCX) Steps to Reproduce: 1. Open attachment 169400 [details] 2. Save as DOCX 3. File reload 4. Change anchor the red frame to 'to character': notice the re-arrangement (reported separately) 5. File reload -> another shape moves 6. Drag the frame somewhere else Right middle of the page 7. Press Undo -> undo not working Actual Results: Undo doesn't undo Expected Results: Should do Reproducible: Always User Profile Reset: No Additional Info: Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 3ed9bba283a6a67864c0928186e277240be0d9ba CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL
Thank you for reporting the bug. I can not reproduce the bug in Version: 7.0.3.1 (x64) Build ID: d7547858d014d4cf69878db179d326fc3483e082 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nb-NO (en_US); UI: en-US Calc: CL Version: 7.2.0.0.alpha0+ (x64) Build ID: 761a672d62df1891b9f4f367a499b220ab2b33fa CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL
No repro and I think the steps are a bit unclear. Step 5 is just "file reload", so I tried both with saving & reloading and just ignoring the step. Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: e6a8d312d3d7e5d81c56d5ccc0508116dd283f1f CPU threads: 8; OS: Linux 5.14; UI render: default; VCL: kf5 (cairo+wayland) Locale: fi-FI (fi_FI.UTF-8); UI: en-US Calc: threaded
Hello, I’ve tried to replicate the bug on the same version of the LO Writer but was unable to see the issue on the undo. I’ve found some issues during replication aside from the re-arrangement of the frames. I’ve found the steps a little bit confusing so here are my replication steps: Using the LO Writer version: Version: 6.2.0.3 (x64) Build ID: 98c6a8a1c6c7b144ce3cc729e34964b47ce25d62 CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; Locale: en-PH (en_PH); UI-Language: en-US Calc: threaded Scenario 1: Click YES on STEP 5 Open the provided file 1. File > Save as DOCX (Word 2007-2019) 2. File > Reload (position of frames re-arranged and the text position inside the frame move from bottom to top) 3. Change the Anchor of the Red frame to “TO CHARACTER” - Select the red frame > Right-click > Anchor > To Character (default value on file is “AS CHARACTER”) 4. File > Reload 5. Pop-up will display, “Cancel all changes?” option is YES or NO - Click YES (notice here that all changes on step 4 were UNDO which is changing of Anchor and the re-arrangement of the frames) 6. Drag the frame somewhere else right middle of the page (unable to move the frame which I think is due to the Anchor being returned to “AS CHARACTER”) Note: frames are re-arranged again when trying to move the frame to the middle of the page (vertically). 7. Press UNDO (undo works fine, no issues, and returned to the position before dragging) 8. PRESS UNDO a couple of times (nothing happened). Scenario 2: Click NO on STEP 5 1. Repeat Steps 1 to 4 on Scenario 1 (noticed that also on step 4 the position of frames was re-arranged and the text position inside the frame moved from bottom to top) 2. File > Reload - Pop-up will display, “Cancel all changes?” option is YES or NO - Click NO (nothing happened, anchor remains “TO CHARACTER”) 3. Drag the frame somewhere else right middle of the page (Able to move the frame to the middle right of the page). 4. Press UNDO (UNDO works but re-arrangement after the dragging did not UNDO and the frame was overlapping or under the image (previously below the red frame before the dragging) I’ve noticed also that the image on the frame was separated from the frame.) 5. Press UNDO 2nd time (works again but frames were re-arranged again and returned from last state/position on STEP 3. The anchor was also reverted back to “AS CHARACTER”. The image which separated from the frame was already returned to its original position.) 6. PRESS UNDO a couple of times (nothing happened since there is no more to undo). Scenario 3: Change the anchor first before saving to .DOCX. 1. Open the provided file 2. Change the Anchor of the Red frame to “TO CHARACTER” 3. Select the red frame > Right-click > Anchor > To Character (default value on file is “AS CHARACTER”) 4. File > Save as DOCX (Word 2007-2019) 5. File > Reload (frames re-arranged. The image inside the frames was separated and overlapped. The red frame was beyond the top of the border.) 6. Drag the frame somewhere else (Notice also that the Anchor of the red frame became “TO PARAGRAPH) 7. Press UNDO a couple of times (reverted back to the last state on STEP 4 after reloading) Scenario 4: Re-create the file and then Repeat Scenario 1 replication steps 1. Repeat Steps 1 to 4: - Noticed in Step 2, the blue frame image overlaps the green frame after Reload, and the text position inside the frame moves from bottom to tap. - Noticed in Step 4, the image of the blue frame overlaps the red frame after changing the anchor. 2. File > Reload - Pop-up will display, “Cancel all changes?” option is YES or NO - Click YES (notice here that all changes on step 4 were UNDO which is changing of Anchor and the image overlaps the frame from changing the anchor return to its last position over the green frame) 3. Drag the frame somewhere else right middle of the page (unable to move the frame which I think is due to the Anchor being returned to “AS CHARACTER”) Note: The blue frame was also moved when trying to move the frame to the middle of the page (vertically). 4. Press UNDO (undo works fine, no issues, and returned to the position before dragging) 5. PRESS UNDO a couple of times (nothing happened). Scenario 5: Re-create the file and then Repeat Scenario 2 replication steps 1. Repeat Steps 1 to 4: - Noticed the same scenario encountered in Steps 2 and 4 with Scenario 4. 2. File > Reload - Pop-up will display, “Cancel all changes?” option is YES or NO - Click NO (nothing happened, anchor remains “TO CHARACTER”, the image of the blue frame remains overlapped in the red frame) 3. Drag the frame somewhere else right middle of the page (Able to move the frame to the middle right of the page). 4. Press UNDO (UNDO works but the image returns to its last state in Step 5) 5. Press UNDO 2nd time (works again but the image on the blue frame still overlaps the red frame but moved upward. The anchor was also reverted back to “AS CHARACTER”. The image which separated from the frame DID NOT return to its original position.) Note: Actual results are not the same in Scenario 2 but still the anchor return to “IN CHARACTER” although the UNDO functions work as expected. PRESS UNDO a couple of times (nothing happened and the image on the blue frame still did not return to its original position). ------------------------------------------------------------------------------ I’ve also tried to replicate to the following versions: Version: 7.4.0.0.beta1 (x64) / LibreOffice Community Build ID: cec1fe9b57a55c032f9f118c907f34e22a63d040 CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: en-PH (en_PH); UI: en-US Calc: CL Latest Release Version: Version: 7.2.7.2 (x64) / LibreOffice Community Build ID: 8d71d29d553c0f7dcbfa38fbfda25ee34cce99a2 CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: en-PH (en_PH); UI: en-US Calc: threaded Version: 7.3.4.2 (x64) / LibreOffice Community Build ID: 728fec16bd5f605073805c3c9e7c4212a0120dc5 CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: en-PH (en_PH); UI: en-US Calc: threaded ------------------------------------------------------------------------------ OVERALL SUMMARY OF REPLICATION STEPS: **Here’s my summary of findings for Version: 6.2.0.3 (x64): - Undo is working. - Right-click is working when changing the anchor. Scenario 1: Click YES on STEP 5: Expected since the changes from STEP 4 was already REDO when “Reload” was triggered. Only 1 redo will do which is the dragging from STEP 6. Scenario 2: Click NO on STEP 5: UNDO also works but noticed that on STEP 7 UNDO, the frame below the red frame was separated from the image inside it. Scenario 3: Change the anchor first before saving to.DOCX: UNDO also works here but the separation of the images from the frames was not reverted after the reload. Scenario 4: Re-create the file and then Repeat Scenario 1 replication steps: Same findings in scenario 1 but this time only the red and blue frames were moved. Other behavior is the same and UNDO works fine. Scenario 5: Re-create the file and then Repeat Scenario 2 replication steps: Noticeable here that the image on the blue frame did not return to the original frame after the UNDO, but still the UNDO other changes. Based on the replication for Version: 6.2.0.3 (x64), there might be an issue with the Reload, Changing the anchor, and Dragging (which is due to the anchor setup) and not the UNDO function. The issue on the changing of the anchor is related to this Bug 140304 - Changing the anchor from 'as character 'to character' changes the whole position of the image. Here’s my summary of findings for the Beta version: Right-click is not working, so you have to use the toolbar to change the anchor The text in the frame was not also changed its position from bottom to top. And still, the UNDO function works here. (So undo issue is not reproducible here) Scenario 1: Click YES on STEP 5: noticed the same behavior but in Step 2 after reload, the frames barely move their position (slightly move but did not overlap). When the anchor was changed to “TO CHARACTER” in Step 4, the frames moved and overlapped the frames above it but when reload it returned to its original position. In Step 6, when I dragged the red frame, still UNABLE to move to the right but was able to move the middle vertically (same behavior on the 6.2.0.3 (x64)). When UNDO was pressed, still it does its function and undo the frames and return to its original position before dragging. Scenario 2: Click NO on STEP 5: Noticed the same behavior but in Step 2 after reload, the frames barely move their position (slightly move but did not overlap). When the anchor was changed to “TO CHARACTER” in Step 4, the frames moved and overlapped the frames above it but when reload it returned to its original position. In Step 6, when I dragged the red frame, still I was ABLE to move since the reload did not revert the anchor to “AS CHARACTER” (same behavior on the 6.2.0.3 (x64)). When UNDO was pressed, still it does its function and undo the frames and return to its original position before dragging. Scenario 3: Change the anchor first before saving to .DOCX: after changing the anchor to “TO CHARACTER”, 3 frames overlapped in the middle including the red frame. In Step 4, after reloading, the frames only moved a bit and still overlapped in the middle. After pressing UNDO after dragging the frame in Step 5, undo works and return to its original position in Step 2. Scenario 4: Re-create the file and then Repeat Scenario 1 replication steps: the same actual results happened but the frames did not move after they move from the first reload. The frames did not move when the anchor is changed and reloaded again. The frames only move when dragged vertically (unable to move to the right since the anchor was reverted to AS CHARACTER). When the UNDO was pressed, it works and returns the frames to their original position before dragging. Scenario 5: Re-create the file and then Repeat the Scenario 2 replication steps, the same actual results happened but the frames did not move after they move from the first reload. The frames did not move when the anchor is changed and reloaded again. The frames only move when dragged to the middle right of the page (able to move since the anchor was not reverted after the reload). When the UNDO was pressed, it works and returns the frames to their original position before dragging. **Here’s my summary of findings for the 7.2.7.2 (x64)version and 7.3.4.2 (x64): - Same behavior for both versions. - Right-click is now working again here. - Options on Anchor are lessened (To page is not available). - The first letter of the text inside the frame goes up, to the same level as the image. - And still, the UNDO function works here. (So undo issue is not reproducible here) Scenario 1: Click YES on STEP 5: noticed the same behavior but in Step 2 after reload, the frames barely move their position (slightly move but did not overlap). When the anchor was changed to “TO CHARACTER” in Step 4, the frames moved and overlapped the frames above it (except for the red frame and the one below it) but when reloaded again it returned to its original position. In Step 6, when I dragged the red frame, still UNABLE to move to the right but was able to move the middle vertically (same behavior on the 6.2.0.3 (x64)). When UNDO was pressed, still it does its function and undo the frames and return to their original position before dragging but the image of the red frame did not return to its original place. Scenario 2: Click NO on STEP 5: Noticed the same behavior but in Step 2 after reload, the frames barely move their position (slightly move but did not overlap). When the anchor was changed to “TO CHARACTER” in Step 4, the frames moved and overlapped the frames above it (except for the red frame and the one below it) but when reloaded again it returned to its original position. In Step 6, when I dragged the red frame, the red frame was able to move to the middle right since the anchor was not reverted during the reload (Reload > No) (same behavior on the 6.2.0.3 (x64)). When UNDO was pressed, still it does its function and undo the frames and return to their original position before dragging and when UNDO was pressed again it returns to its original place after the first reload. Scenario 3: Change the anchor first before saving to .DOCX: after changing the anchor to “TO CHARACTER”, 3 frames overlapped in the middle including the red frame. In Step 4, after reloading, the frames only moved a bit and still overlapped in the middle. After pressing UNDO after dragging the frame in Step 5, undo works and return to its original position in Step 2. (the same happened with the Beta version) Scenario 4: Re-create the file and then Repeat Scenario 1 replication steps: the frames only slightly move and the first letter of the text in the frame goes up and to the same level as the image on the first reload but did not move when the anchor is changed and then reloaded again. When undo was pressed, it works as expected and returns to its last position on the first reload. Scenario 5: Re-create the file and then Repeat Scenario 2 replication steps: Aside from its slightly moved during the first reload, the first letter of the text in the frame goes up and to the same level as the image. Frames were not also moved when the anchor was changed. The frame was also able to drag to the middle right. When undo was pressed, it works as expected and returns to its last position on the first reload. --------------------------------------------------------------------------- Overall, the UNDO issue here is not reproducible but the issue on Reload, changing of Anchor does has an issue. We can also eliminate the issue on the file provided as the cause of the issue because we’ve also re-created the file using the same format (scenario 4 and scenario 5) and still the same issue encountered and UNDO function still works. I’ve tried looking for a similar application like MS Word and Google Docs, a different function was used here which is the wrap text. I’ve tried opening the odt file in MS Word and the frames were displayed differently and not in the position when opened in LO Writer. Changing the anchor to “To Character” is not possible also here since the function is different here. But I’ve tried to change the wrap setting and then tried to UNDO, and the UNDO works. I’ve tried opening the file in Google Docs but the image of the shapes/frames did not display properly and when I change the wrap setting and then hit the UNDO, the wrap settings reverted to the original setting. I’ve tried also opening the file on the same free writer application, the OpenOffice Writer, but the same behavior was encountered in LO Writer. Undo works but the changing of anchor and reloading change the position of the shapes/frames. On the separate issue on the right-click when changing the anchor on Beta version (7.4), tried to look for the documentation of the writer in 7.4 but was unable to find it. Tried to check on the 7.3 LO Writer documentation and it states there that right-click should be working when changing the anchor. https://help.libreoffice.org/7.3/he/text/swriter/guide/anchor_object.html?&DbPAR=SHARED&System=WIN Please see also attached pdf document with the consolidated screenshots of the replication I’ve done on the same version where the bug was encountered (6.2.0.3 (x64)).
Created attachment 181072 [details] Bug 140193 Replication Sreenshots Attached a PDF document with consolidated screenshots of replication.
Created attachment 181073 [details] Sample document re-created based on the original document provided. I've also attached the sample file I've created for scenarios 4 and 5.
Never confirmed.. so unsure what to pick.. Version: 7.5.0.0.alpha0+ / LibreOffice Community Build ID: 7a89eae97a970939174d59aa58147eaa194acaee CPU threads: 8; OS: Mac OS X 12.3.1; UI render: Skia/Metal; VCL: osx Locale: nl-NL (nl_NL.UTF-8); UI: en-US Calc: threaded
Hello @Telesto, I suggest we can already close this bug since based on my follow-up tests, there is no issue with the undo function. Maybe we could look at the issue of reloading and your bug regarding changing the anchor. Thanks